From 4295c82e457da715eada06cf0d7f4e2c8a788ae4 Mon Sep 17 00:00:00 2001
From: Michal Nowak <mnowak@isc.org>
Date: Thu, 14 Jan 2021 12:09:04 +0100
Subject: [PATCH] Add --enable-option-checking=fatal to ./configure in CI

The --enable-option-checking=fatal option prevents ./configure from
proceeding when an unknown option is used in the ./configure step in CI.
This change will avoid adding unsupported ./configure options or options
with typo or typo in pairwise testing "# [pairwise: ...]" marker.
---
 .gitlab-ci.yml           | 3 ++-
 util/pairwise-testing.sh | 3 +--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index d19b25a048..9e02bd3219 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -214,12 +214,13 @@ stages:
     ${CONFIGURE} \
     --disable-maintainer-mode \
     --enable-developer \
+    --enable-option-checking=fatal \
     --with-cmocka \
     --with-libxml2 \
     --with-json-c \
     --prefix="${BIND_INSTALL_PATH}" \
     $EXTRA_CONFIGURE \
-    || cat config.log
+    || (test -s config.log && cat config.log; exit 1)
 
 .check_readline_setup: &check_readline_setup |
     if [[ -n "${WITHOUT_READLINE}" ]]; then \
diff --git a/util/pairwise-testing.sh b/util/pairwise-testing.sh
index d671e4acf7..9205b5ec47 100755
--- a/util/pairwise-testing.sh
+++ b/util/pairwise-testing.sh
@@ -24,8 +24,7 @@ while read -r -a configure_switches; do
 	mkdir "pairwise-${runid}"
 	cd "pairwise-${runid}"
 	echo "${configure_switches[@]}" | tee "../pairwise-output.${runid}.txt"
-	../configure "${configure_switches[@]}" >> "../pairwise-output.${runid}.txt" 2>&1
-	grep -F "WARNING: unrecognized options:" "../pairwise-output.${runid}.txt" && exit 1
+	../configure --enable-option-checking=fatal "${configure_switches[@]}" >> "../pairwise-output.${runid}.txt" 2>&1
 	make "-j${BUILD_PARALLEL_JOBS:-1}" all >> "../pairwise-output.${runid}.txt" 2>&1
 	cd ..
 	rm -rf "pairwise-${runid}" "pairwise-output.${runid}.txt"