upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-02-12 07:13:35 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

1643. [bug] dns_db_closeversion() could leak memory / node

Browse source 
references. [RT #11163]
This commit is contained in:
Mark Andrews 2004-05-23 11:07:23 +00:00
parent 00d0f780bb
commit 4c7910ecc0
2 changed files with 16 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
CHANGES
View file

@ -1,3 +1,6 @@
1643. [bug] dns_db_closeversion() could leak memory / node
references. [RT #11163]
1642. [port] Support OpenSSL implementations which don't have
DSA support. [RT #11360]

17
lib/dns/rbtdb.c
View file

@ -15,7 +15,7 @@
* PERFORMANCE OF THIS SOFTWARE.
*/
/* $Id: rbtdb.c,v 1.168.2.11.2.15 2004/05/14 05:06:38 marka Exp $ */
/* $Id: rbtdb.c,v 1.168.2.11.2.16 2004/05/23 11:07:23 marka Exp $ */
/*
* Principal Author: Bob Halley
@ -1061,9 +1061,13 @@ closeversion(dns_db_t *db, dns_dbversion_t **versionp, isc_boolean_t commit) {
* isn't being used by anyone, we can clean
* it up.
*/
if (rbtdb->current_version->references == 0)
if (rbtdb->current_version->references == 0) {
cleanup_version =
rbtdb->current_version;
APPENDLIST(version->changed_list,
cleanup_version->changed_list,
link);
}
/*
* Become the current version.
*/
@ -1076,6 +1080,7 @@ closeversion(dns_db_t *db, dns_dbversion_t **versionp, isc_boolean_t commit) {
* We're rolling back this transaction.
*/
cleanup_list = version->changed_list;
ISC_LIST_INIT(version->changed_list);
rollback = ISC_TRUE;
cleanup_version = version;
rbtdb->future_version = NULL;
@ -1096,6 +1101,7 @@ closeversion(dns_db_t *db, dns_dbversion_t **versionp, isc_boolean_t commit) {
if (least_greater == NULL)
least_greater = rbtdb->current_version;
INSIST(version->serial < least_greater->serial);
/*
* Is this the least open version?
*/
@ -1116,16 +1122,19 @@ closeversion(dns_db_t *db, dns_dbversion_t **versionp, isc_boolean_t commit) {
version->changed_list,
link);
}
}
} else if (version->serial == rbtdb->least_serial)
INSIST(EMPTY(version->changed_list));
UNLINK(rbtdb->open_versions, version, link);
}
}
least_serial = rbtdb->least_serial;
UNLOCK(&rbtdb->lock);
if (cleanup_version != NULL)
if (cleanup_version != NULL) {
INSIST(EMPTY(cleanup_version->changed_list));
isc_mem_put(rbtdb->common.mctx, cleanup_version,
sizeof(*cleanup_version));
}
if (!EMPTY(cleanup_list)) {
for (changed = HEAD(cleanup_list);