From 4e8b3f9893e8a3f3a554e20131ae36e2a403033d Mon Sep 17 00:00:00 2001 From: Mark Andrews Date: Mon, 7 Aug 2023 09:38:56 +1000 Subject: [PATCH] Set ret=1 if _wait_for_stats does not succeed Errors getting transfer statistics from named.run where not detected as ret was not set to one if there hadn't been a success after looping for a while. (cherry picked from commit 287a1ac09baa8083261ad794033368b3506f886f) --- bin/tests/system/ixfr/tests.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bin/tests/system/ixfr/tests.sh b/bin/tests/system/ixfr/tests.sh index a2ac4256e4..f1e3b62241 100644 --- a/bin/tests/system/ixfr/tests.sh +++ b/bin/tests/system/ixfr/tests.sh @@ -407,13 +407,13 @@ _wait_for_stats () { n=$((n+1)) echo_i "checking whether named calculates incoming IXFR statistics correctly ($n)" ret=0 -retry_quiet 10 _wait_for_stats 10.53.0.3 "Transfer completed" stats.incoming +retry_quiet 10 _wait_for_stats 10.53.0.3 "Transfer completed" stats.incoming || ret=1 if [ $ret != 0 ]; then echo_i "failed"; fi status=$((status+ret)) n=$((n+1)) echo_i "checking whether named calculates outgoing IXFR statistics correctly ($n)" -retry_quiet 10 _wait_for_stats 10.53.0.4 "IXFR ended" stats.outgoing +retry_quiet 10 _wait_for_stats 10.53.0.4 "IXFR ended" stats.outgoing || ret=1 if [ $ret != 0 ]; then echo_i "failed"; fi status=$((status+ret))