From 7dfd4ec61b6287052ea8a90865e31f483b1563cd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= Date: Tue, 28 Feb 2023 12:54:02 +0100 Subject: [PATCH] Add a DNSRPS-enabled build to regular CI pipelines DNSRPS-enabled builds have recently been silently broken a few times due to that feature not being tested in regular CI pipelines. Add the --enable-dnsrps --enable-dnsrps-dl switches to the ./configure invocation in one of the CI jobs run for all merge requests so that DNSRPS-related build issues can be detected in advance. It is important to note that this change by itself does NOT enable actual testing of the DNSRPS feature as doing that requires a DNSRPS provider library to be present on the test host. (cherry picked from commit a4d6f5f6fdf2cee7a362f26566b2d33a687726b4) --- .gitlab-ci.yml | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 174544be74..9a2c10bb57 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -923,7 +923,15 @@ gcc:tumbleweed:amd64: variables: CC: gcc CFLAGS: "${CFLAGS_COMMON} -DDEBUG" - EXTRA_CONFIGURE: "--with-libidn2 ${WITH_READLINE_READLINE}" + # NOTE: Testing DNSRPS-enabled builds currently requires an + # operating system with glibc 2.34+. This requirement will go away + # once the DNSRPS dynamic loading code gets reworked to use libuv's + # dlopen() API. + # + # NOTE: This does *not* enable testing of the DNSRPS feature itself. + # Doing that requires a DNSRPS provider library to be present on the + # test host. + EXTRA_CONFIGURE: "--enable-dnsrps --enable-dnsrps-dl --with-libidn2 ${WITH_READLINE_READLINE}" <<: *tumbleweed_latest_amd64_image <<: *build_job