upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-04-23 23:28:18 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

712. [bug] Sending a large signed update message caused an

Browse source 
assertion failure. [RT #718]

- Resetting a message should clear the TSIG/SIG(0) sections
- Rerendering a message if the first try returned USETCP should not call
  dns_message_settsigkey() again.
This commit is contained in:
Brian Wellington 2001-01-27 02:28:33 +00:00
parent fd73b3a68d
commit 94baac869a
3 changed files with 19 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
CHANGES
View file

@ -1,4 +1,7 @@
712. [bug] Sending a large signed update message caused an
assertion failure. [RT #718]
711. [bug] The libisc and liblwres implementations of
inet_ntop contained an off by one error.

12
lib/dns/message.c
View file

@ -15,7 +15,7 @@
* WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*/
/* $Id: message.c,v 1.173 2001/01/18 00:26:34 bwelling Exp $ */
/* $Id: message.c,v 1.174 2001/01/27 02:28:33 bwelling Exp $ */
/***
*** Imports
@ -1982,6 +1982,16 @@ dns_message_renderreset(dns_message_t *msg) {
}
}
}
if (msg->tsigname != NULL)
dns_message_puttempname(msg, &msg->tsigname);
if (msg->tsig != NULL) {
dns_rdataset_disassociate(msg->tsig);
dns_message_puttemprdataset(msg, &msg->tsig);
}
if (msg->sig0 != NULL) {
dns_rdataset_disassociate(msg->sig0);
dns_message_puttemprdataset(msg, &msg->sig0);
}
}
isc_result_t

7
lib/dns/request.c
View file

@ -15,7 +15,7 @@
* WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*/
/* $Id: request.c,v 1.53 2001/01/23 19:50:10 bwelling Exp $ */
/* $Id: request.c,v 1.54 2001/01/27 02:28:32 bwelling Exp $ */
#include <config.h>
@ -788,6 +788,7 @@ dns_request_createvia(dns_requestmgr_t *requestmgr, dns_message_t *message,
isc_mem_t *mctx;
dns_messageid_t id;
isc_boolean_t tcp;
isc_boolean_t setkey = ISC_TRUE;
REQUIRE(VALID_REQUESTMGR(requestmgr));
REQUIRE(message != NULL);
@ -850,7 +851,8 @@ dns_request_createvia(dns_requestmgr_t *requestmgr, dns_message_t *message,
goto cleanup;
message->id = id;
dns_message_settsigkey(message, request->tsigkey);
if (setkey)
dns_message_settsigkey(message, request->tsigkey);
result = req_render(message, &request->query, options, mctx);
if (result == DNS_R_USETCP &&
(options & DNS_REQUESTOPT_TCP) == 0) {
@ -862,6 +864,7 @@ dns_request_createvia(dns_requestmgr_t *requestmgr, dns_message_t *message,
dns_dispatch_detach(&request->dispatch);
socket = NULL;
options |= DNS_REQUESTOPT_TCP;
setkey = ISC_FALSE;
goto use_tcp;
}
if (result != ISC_R_SUCCESS)