upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-05-04 17:24:47 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Address use before NULL check warning of uvreq

Browse source 
move dereference of uvreq until the after NULL check.

(cherry picked from commit 7079829b84)
This commit is contained in:
Mark Andrews 2021-09-28 10:08:26 +10:00
parent 3859fea828
commit addd580b0a
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/isc/netmgr/netmgr.c
View file

@ -2585,8 +2585,7 @@ isc__nm_async_readcb(isc__networker_t *worker, isc__netievent_t *ev0) {
isc_nmsocket_t *sock = ievent->sock;
isc__nm_uvreq_t *uvreq = ievent->req;
isc_result_t eresult = ievent->result;
isc_region_t region = { .base = (unsigned char *)uvreq->uvbuf.base,
.length = uvreq->uvbuf.len };
isc_region_t region;
UNUSED(worker);
@ -2595,6 +2594,9 @@ isc__nm_async_readcb(isc__networker_t *worker, isc__netievent_t *ev0) {
REQUIRE(VALID_NMHANDLE(uvreq->handle));
REQUIRE(sock->tid == isc_nm_tid());
region.base = (unsigned char *)uvreq->uvbuf.base;
region.length = uvreq->uvbuf.len;
uvreq->cb.recv(uvreq->handle, eresult, &region, uvreq->cbarg);
isc__nm_uvreq_put(&uvreq, sock);