upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-02-27 03:51:16 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove unneded NULL-checking

Browse source 
Fix an issue reported by Coverity by removing the unneded check.

    *** CID 352554:  Null pointer dereferences  (REVERSE_INULL)
    /bin/dig/dighost.c: 3056 in start_tcp()
    3050
    3051     	if (ISC_LINK_LINKED(query, link)) {
    3052     		next = ISC_LIST_NEXT(query, link);
    3053     	} else {
    3054     		next = NULL;
    3055     	}
    >>>    CID 352554:  Null pointer dereferences  (REVERSE_INULL)
    >>>    Null-checking "connectquery" suggests that it may be null, but it
           has already been dereferenced on all paths leading to the check.
    3056     	if (connectquery != NULL) {
    3057     		query_detach(&connectquery);
    3058     	}
    3059     	query_detach(&query);
    3060     	if (next == NULL) {
    3061     		clear_current_lookup();
This commit is contained in:
Aram Sargsyan 2022-06-06 15:12:46 +00:00 committed by Arаm Sаrgsyаn
parent 215f89b669
commit b7cb73160b
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
bin/dig/dighost.c
View file

@ -3053,9 +3053,7 @@ failure_tls:
} else {
next = NULL;
}
if (connectquery != NULL) {
query_detach(&connectquery);
}
query_detach(&connectquery);
query_detach(&query);
if (next == NULL) {
clear_current_lookup();