From d0d9e7dfb25d0482aff3d1647412eec41b4fa1da Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ond=C5=99ej=20Sur=C3=BD?= Date: Wed, 11 Jan 2023 10:17:55 +0100 Subject: [PATCH] Don't honour single read per client isc_nm_read() call in the TLSDNS This reverts commit f17f5e831be6d07cc7476048444befbf1e06d5b6 that made following change: > The TLSDNS transport was not honouring the single read callback for > TLSDNS client. It would call the read callbacks repeatedly in case the > single TLS read would result in multiple DNS messages in the decoded > buffer. Turns out that this change broke XoT, so we are reverting the change until we figure out a proper fix that will keep the design promise and not break XoT at the same time. --- lib/isc/netmgr/tlsdns.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/lib/isc/netmgr/tlsdns.c b/lib/isc/netmgr/tlsdns.c index 177dadd601..19da3353e3 100644 --- a/lib/isc/netmgr/tlsdns.c +++ b/lib/isc/netmgr/tlsdns.c @@ -1120,10 +1120,6 @@ tls_cycle_input(isc_nmsocket_t *sock) { goto failure; } - if (atomic_load(&sock->client)) { - break; - } - if (pending == 0) { break; }