upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-03-22 18:33:11 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

2390 [bug] dispatch.c could make a false warning on 'odd socket'.

Browse source 
[RT #18301].
This commit is contained in:
Tatuya JINMEI 神明達哉 2008-07-18 02:38:32 +00:00
parent 7871069127
commit edffbefe20
2 changed files with 21 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
CHANGES
View file

@ -1,3 +1,6 @@
2390 [bug] dispatch.c could make a false warning on 'odd socket'.
[RT #18301].
2389 [bug] Move the "working directory writable" check to after
the ns_os_changeuser() call. [RT #18326]

31
lib/dns/dispatch.c
View file

@ -15,7 +15,7 @@
* PERFORMANCE OF THIS SOFTWARE.
*/
/* $Id: dispatch.c,v 1.116.18.25 2008/07/03 00:14:39 each Exp $ */
/* $Id: dispatch.c,v 1.116.18.26 2008/07/18 02:38:32 jinmei Exp $ */
/*! \file */
@ -1024,18 +1024,23 @@ udp_recv(isc_event_t *ev_in, dns_dispatch_t *disp, dispsocket_t *dispsock) {
return;
}
if (dispsock != NULL &&
(disp->attributes & DNS_DISPATCHATTR_EXCLUSIVE) != 0) {
resp = dispsock->resp;
id = resp->id;
if (ev->result != ISC_R_SUCCESS) {
/*
* This is most likely a network error on a connected
* socket. It makes no sense to check the address or
* parse the packet, but it will help to return the
* error to the caller.
*/
goto sendresponse;
if ((disp->attributes & DNS_DISPATCHATTR_EXCLUSIVE) != 0) {
if (dispsock != NULL) {
resp = dispsock->resp;
id = resp->id;
if (ev->result != ISC_R_SUCCESS) {
/*
* This is most likely a network error on a
* connected socket. It makes no sense to
* check the address or parse the packet, but it
* will help to return the error to the caller.
*/
goto sendresponse;
}
} else {
UNLOCK(&disp->lock);
isc_event_free(&ev_in);
return;
}
} else if (ev->result != ISC_R_SUCCESS) {
free_buffer(disp, ev->region.base, ev->region.length);