upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-03-25 20:04:05 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Log assertion failures right after test result

Browse source 
The extra messages are typically traceback from assertion failures.
Previously, they'd be printed only after all individual test case
results have been printed. That made it difficult to pair the traceback
to the failing test in some cases, as the node information (aka test
name) might not always be present.

Instead, log any extra messages related to a particular test failure
directly after reporting its result, making the failure details more
readily available and easy to connect with a particular test case.
This commit is contained in:
Nicki Křížek 2025-06-26 18:20:06 +02:00
parent 9f3f6ec38e
commit fcf31417dd
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
bin/tests/system/conftest.py
View file

@ -360,13 +360,13 @@ def system_test_dir(request, system_test_name, expected_artifacts):
if node.nodeid in all_test_results
}
assert len(test_results)
messages = []
for node, result in test_results.items():
isctest.log.debug("%s %s", result.outcome.upper(), node)
messages.extend(result.messages.values())
for message in messages:
if message:
isctest.log.debug("\n" + message)
message = f"{result.outcome.upper()} {node}"
nonempty_extra = [msg for msg in result.messages.values() if msg.strip()]
if nonempty_extra:
message += "\n"
message += "\n\n".join(nonempty_extra)
isctest.log.debug(message)
failed = any(res.outcome == "failed" for res in test_results.values())
skipped = any(res.outcome == "skipped" for res in test_results.values())
if failed: