the length of a key's secret data. Previously
OMAPI only stored secrets up to the first NUL byte.
This change was made to cope with decoded base64 secrets, so in this
revision omapiconf.c and rndc.c also decode the secret.
two or more files in libomapi.a were not namespace
protected using the ISC convention of starting with
the library name and two underscores ("omapi__"...)
Mostly, several functions that take pointers as arguments, almost
always char * pointers, had those pointers qualified with "const".
Those that returned pointers to previously const-qualified arguments
had their return values qualified as const. Some structure members
were qualified as const to retain that attribute from the variables
from which they were assigned.
Cleanup of redundant/useless header file inclusion.
ISC style lint, primarily for function declarations and standalone
comments -- ie, those that appear on a line without any code, which
should be written as follows:
/*
* This is a comment.
*/
from omapi_object_dereference when an object is destroyed.
Provide OMAPI_EVENT_OBJECTFREED definition to be sent as an event when
an object is destroyed.
Callback parameter to omapi_protocol_listen and omapi_listener_listen
changed type to isc_taskaction_t.
omapi_lib_init takes new taskmgr and socketmgr parameters.
do need isc/util.h
mutex and recv_lock no longer needed in connection; wait_lock used instead.
messages_expected no longer needed in connection.
no more omapi_ipv6
connection_send return value changed from void to isc_result_t
connection_wait no longer takes a timeout parameter
new private function, handle_destroy
include isc/region.h and new omapi/types.h
typedefs moved to omapi/types.h
define protocol port to 7912 so as not to conflict with dhcp server;
this clearly needs more thought. the default omapi port will need to be
server specific rather than library specific.
new public functions, omapi_listener_shutdown, omapi_data_getint.
changed API, omapi_string_totext, omapi_value_getint
* no spaces around " -> " in indirect postfix expression.
* no space between function name and open parenthesis.
* no space between array name and open bracket.
* use NULL not 0 for pointers.
* explicitly compare pointers to NULL.
* explicitly compare integers to 0.
* Do not cast NULL.
* return type of function declaration on line by itself.
* open brace of function definition follows close parenthesis if parameters
all fit on one line.
* comment-only lines start with /* on line by itself, and end with */
on line by itself.
* variable names in structures separated from their types in a column.
* name the parameters in function prototypes.
* ifndef multiple header file inclusion.
and other BIND9 conventions not in coding.html:
* private structures defined in relevant source module, not private header.
* RCS /* $Id: $ */ comments.
* Principal Author (Ted Lemon) comments.
* Updated ISC copyrights.
* Parenthesize value of return().
* Parenthesize argument of sizeof().
* "unsigned int foo" not "unsigned foo".
* ISC_LANG_(BEGIN|END)DECLS in header files.
* header files included directly by source/header file that needs them.
* ... and others I am probably forgetting.
and conversion to some libisc.a modules:
* use isc/int.h for isc_uintXX_t types, not u_intXX_t.
* use isc/assertions.h for REQUIRE() and INSIST().
* use isc/error.h for UNEXPECTED_ERROR.
* use isc/boolean.h for isc_boolean_t flags instead of int flags.
* use isc/net.h for networking types.
* use isc/netdb.h for gethostby*.
STILL TO COME ...
* more isc_boolean_t.
* isc/time.h to replace struct timeval.
* isc/socket.h to replace socket/listen/select/etc.
* isc/mem.h to replace malloc/free.
* namespace overhaul & omapi/compatibility.h.
Please collect all your belongings but stand clear of the doors until this
train has come to a complete stop.
