Commit graph

3645 commits

Author SHA1 Message Date
Andreas Gustafsson
10f4e9668a the INSIST condition of 1.145 was too strong, weakened it;
dded another INSIST to help track down the INSIST(!external) crash
2000-07-14 00:37:27 +00:00
Andreas Gustafsson
55da37e18f removed dead code 2000-07-14 00:33:09 +00:00
Brian Wellington
6bc1a64561 If a positive validation fails and it looks like the reason is that there
are no material DNSSEC signatures, try an insecurity proof.
2000-07-13 23:52:04 +00:00
Brian Wellington
4250285838 Return DNS_R_NAMETOOLONG in a few places where less useful errors were
returned before.
2000-07-13 18:10:18 +00:00
Brian Wellington
618e871c2e Add DNS_R_NAMETOOLONG 2000-07-13 02:41:20 +00:00
Andreas Gustafsson
4532e9e7c6 in isc_log_wouldlog(), deal with the possibility of lctx
being NULL
2000-07-13 02:28:18 +00:00
Andreas Gustafsson
0072e42780 use isc_log_wouldlog() in manager_log() 2000-07-13 01:38:40 +00:00
Brian Wellington
2935e25e99 Removed debugging code that is no longer useful. 2000-07-13 01:22:56 +00:00
Andreas Gustafsson
9317787889 use isc_log_wouldlog() 2000-07-13 01:16:22 +00:00
Brian Wellington
febc974d0f Use isc_log_wouldlog() to avoid calling strerror() whenever possible. 2000-07-13 01:13:53 +00:00
Brian Wellington
2e1236ad1e Call isc_log_wouldlog() 2000-07-13 00:30:58 +00:00
Brian Wellington
945c32833b Call isc_log_wouldlog() in a few places. 2000-07-13 00:27:17 +00:00
Andreas Gustafsson
211ac47e07 use isc_log_wouldlog() to avoid unnecessary formatting work
when the debug level does not warrant logging
2000-07-13 00:25:38 +00:00
Andreas Gustafsson
30576c592b 330. [func] New function isc_log_wouldlog(). 2000-07-13 00:19:02 +00:00
Brian Wellington
ecb2897c71 Insist that when a fetch returns a successful event, the rdataset is associated.
A test failed about a week ago because this was not true, and because it
died in the event handler, diagnosing the problem was impossible.
2000-07-12 23:56:06 +00:00
Andreas Gustafsson
2c24bbb10b clarified warning messages 2000-07-12 16:17:38 +00:00
James Brister
8af589aea3 It's no longer a fatal error if a keys{} clause is missing on a control
channel definition, nor if the keys{} clause is empty. Warnings are
issued.
2000-07-12 15:36:09 +00:00
Brian Wellington
a6f31a3fd0 Only install default handlers for SIGTERM and SIGWAIT if we haven't installed
other handlers already.
2000-07-12 01:46:57 +00:00
Andreas Gustafsson
403cc93b27 typo in log message 2000-07-11 22:44:33 +00:00
David Lawrence
ce2be9b721 329. [func] omapi_auth_register() now takes a size_t argument for
the length of a key's secret data.  Previously
			OMAPI only stored secrets up to the first NUL byte.

This change was made to cope with decoded base64 secrets, so in this
revision omapiconf.c and rndc.c also decode the secret.
2000-07-11 22:03:12 +00:00
David Lawrence
9bf765ab3a 328. [func] Added isc_base64_decodestring().
(This is basically bin/named/server.c:base64_cstring_tobuffer(), which I
will remove in another revision that will not need to be pulled up.  I also
would like to change isc_base64_totext() and isc_base64_tobuffer() to be
isc_base64_encoderegion() and isc_base64_decodelexer(), unless there are
exceptions.  I find their existing names to be quite confusing with regard to
what translation function each performs.)
2000-07-11 21:51:13 +00:00
James Brister
f4d9f465cd 327. [bug] rndc.conf parser wasn't correctly recognising an IP
address where a host specification was required.
2000-07-11 20:13:09 +00:00
Brian Wellington
838f13fbdc Set default signal handlers for SIGINT and SIGTERM (SIGHUP already had one).
This doesn't appear to have an effect on any platform, but it seems like a
good idea.
2000-07-11 19:18:05 +00:00
James Brister
adade77942 326. [func] 'keys' in an 'inet' control statement is now
required and must have at least one item in it.

                        warning is issued if a 'unix' control channel is
                        defined (not supported).
2000-07-11 19:09:10 +00:00
Mark Andrews
5c0a406664 325. [bug] isc_lex_gettoken was processing octal strings when
ISC_LEXOPT_CNUMBER was not set.
2000-07-11 02:44:54 +00:00
Andreas Gustafsson
a4db2a47f5 incremented library version numbers to 1.0.0 2000-07-10 22:20:43 +00:00
Michael Graff
d2762d6c37 If the name is a dynamic name, free its memory 2000-07-10 20:46:02 +00:00
Michael Graff
401bea7527 set connected and bound when the connect completes 2000-07-10 19:40:06 +00:00
Andreas Gustafsson
28059de4ef when a master file ends in a place where a newline is expected,
make the warning message say 'file does not end with newline' instead of
'unexpected end of file' to lead the user on the right tracks to fixing
the most likely cause.  Also, don't include the function name in the message.
2000-07-10 19:07:19 +00:00
David Lawrence
d4868faf3f removed the port member from dns_c_ctrl_t; the port is put in the sockaddr. 2000-07-10 11:28:31 +00:00
David Lawrence
838281ed55 318. [func] dns_c_ndcctx_destroy() could never return anything
except ISC_R_SUCCESS; made it have void return instead.
2000-07-10 11:27:12 +00:00
David Lawrence
89e57b472d 317. [func] Use callbacks from libomapi to determine if a
new connection is valid, and if a key requested
			to be used with that connection is valid.
2000-07-10 11:23:00 +00:00
Mark Andrews
fd4810861c Warn on unexpected <eof> if input source is a file, treat as <eol><eof>
regardless of input source.
2000-07-10 05:15:04 +00:00
Mark Andrews
b47f3dc885 Add isc_lex_isfile(). 2000-07-10 05:11:18 +00:00
Mark Andrews
d1e971ba02 316. [bug] EOF mid line should be a error.
315.   [bug]           Handle non-empty blanks lines.
2000-07-09 12:52:34 +00:00
Andreas Gustafsson
f405ffddc8 added missing requirements 2000-07-08 17:27:28 +00:00
James Brister
475c936d4c 314. [func] Inet controls named.conf statement can now have
any non-negative number of keys specified.
2000-07-07 23:11:48 +00:00
James Brister
b4124351ad typo in printing additional-data definition.. 2000-07-07 22:57:53 +00:00
David Lawrence
d20d22616b A socket result of ISC_R_SUCCESS can still possibly be posted even after
isc_socket_cancel() has been called.  resquery_senddone() has been fixed
to account for this (there was a race condition because of the faulty
assumption that only ISC_R_CANCELED would be returned after
isc_socket_cancel()).

The interaction of resquery_response() with the dispatcher now has to be
closely reviewed to make sure it does not have a similar problem with
a canceled query.  If the faulty assumption hadn't been faulty, it was
fine, but now I'm not so sure.
2000-07-07 19:43:14 +00:00
Brian Wellington
0308460880 Some of the lwres functions weren't calling lwres_conf_parse. 2000-07-07 19:43:10 +00:00
Brian Wellington
68aa880dd5 remove unnecessary calls to fcntl(). 2000-07-07 19:10:00 +00:00
Brian Wellington
d8c8722f28 313. [bug] When parsing resolv.conf, don't terminate on an
error.  Instead, parse as much as possible, but
                        still return an error if one was found.
2000-07-07 18:58:46 +00:00
Brian Wellington
03968c0f5e removed dead code 2000-07-07 18:28:58 +00:00
Brian Wellington
4b7167e96a 312. [bug] Increase the number of allowed elements in the
resolv.conf search path from 6 to 8.  If there
                        are more than this, ignore the remainder rather
                        than returning a failure in lwres_conf_parse.
2000-07-07 18:24:11 +00:00
Brian Wellington
a4b496f2ab 311. [bug] lwres_conf_parse failed when the first line of
resolv.conf was empty or a comment.
2000-07-07 18:16:46 +00:00
James Brister
524c8ea0dc typo in print statement. 2000-07-07 14:30:00 +00:00
James Brister
952e9025b0 310. [func] Changes to named.conf "controls" statement (inet
subtype only)

                          - support "keys" clause

                                controls {
                                   inet * port 1024
                                        allow { any; } keys { "foo"; }
                                }

                          - allow "port xxx" to be left out of statement,
                            in which case it defaults to omapi's default port
                            of 953.
2000-07-07 13:56:14 +00:00
Brian Wellington
25496cebad If trying to validate a key set that happens to be a security root, the
validation should only consist of checking that each key in the key set
is also in the list of security root keys.

Strangeness occurs when the key set is signed, since the key set is marked
as secure, but the sig set is not, since it wasn't used in the validation
process.  This means that a query for a key set at a security root will
have the AD bit set if the key set is unsigned and not if the key set is signed.
2000-07-07 00:44:01 +00:00
David Lawrence
3658cf5419 comment cleanup (missing "not", spaces where tabs should have been) 2000-07-07 00:25:47 +00:00
David Lawrence
9fb4b3f08a Do not return an exact match from dns_rbt_findnode() when the exact
match does not have associated data and DNS_RBTFIND_EMPTYDATA is not set.
Return DNS_R_PARTIALMATCH instead if there is a superdomain with
data, or ISC_R_NOTFOUND if no superdomain has data.

Make dns_rbt_findname() honor DNS_RBTFIND_EMPTYDATA, per the rbt.h
documentation that has been saying it will.  It didn't.
2000-07-06 23:54:45 +00:00