Commit graph

10038 commits

Author SHA1 Message Date
Mukund Sivaraman
ef838436ef Don't permit loading meta RR types such as TKEY from master files (#47009)
(cherry picked from commit 8a4ce20172)
(cherry picked from commit c8eb726046)
(cherry picked from commit 6fb3db01ac)
(cherry picked from commit 96456c0834)
2018-01-22 15:03:31 +05:30
Tinderbox User
ecfc27bf6d update copyright notice / whitespace 2018-01-21 23:49:55 +00:00
Mark Andrews
2f346f4275 4869. [bug] Address some cases where NULL with zero length could
be passed to memmove which is undefined behaviour and
                        can lead to bad optimisation. [RT #46888]

(cherry picked from commit fdd8838bf9)
2018-01-22 09:42:25 +11:00
Tinderbox User
8d5a01a868 update copyright notice / whitespace 2018-01-13 23:50:30 +00:00
Mukund Sivaraman
4f47e5fd63 Fix various bugs reported by valgrind --tool=memcheck (#46978)
(cherry picked from commit f96133826e)
(cherry picked from commit 0374e1c3fd)
(cherry picked from commit 929329d2d6)
(cherry picked from commit d072be0691)
2018-01-13 12:02:18 +05:30
Tinderbox User
4c71ca4ae7 update copyright notice / whitespace 2018-01-10 23:57:36 +00:00
Mark Andrews
efb95afc6f 4862. [bug] The rdata flags for RRSIG was not being properly set
when constructing a rdataslab. [RT #46978]

(cherry picked from commit 7befb67af4)
2018-01-11 09:55:07 +11:00
Tinderbox User
536fe358af update copyright notice / whitespace 2018-01-09 23:49:31 +00:00
Mark Andrews
55c81d796c 4860. [bug] isc_int8_t should be signed char. [RT #46973]
(cherry picked from commit 21f708c88c)
2018-01-10 08:42:38 +11:00
Mark Andrews
455296d36a Revert "unconditionally typedef summarystat_t for coverity"
This reverts commit 59c2cad2f3.
2018-01-05 11:10:28 +11:00
Tinderbox User
f3e5a44f00 update copyright notice / whitespace 2018-01-04 23:47:43 +00:00
Mark Andrews
59c2cad2f3 unconditionally typedef summarystat_t for coverity
(cherry picked from commit a0e66ef6dd)
2018-01-05 10:12:16 +11:00
Evan Hunt
f6ec7f6b99 [v9_9] block validator deadlock and prevent use-after-free
4859.	[bug]		A loop was possible when attempting to validate
			unsigned CNAME responses from secure zones;
			this caused a delay in returning SERVFAIL and
			also increased the chances of encountering
			CVE-2017-3145. [RT #46839]

4858.	[security]	Addresses could be referenced after being freed
			in resolver.c, causing an assertion failure.
			(CVE-2017-3145) [RT #46839]
2018-01-03 19:19:59 -08:00
Tinderbox User
01dd316a95 update copyright notice / whitespace 2018-01-03 23:47:32 +00:00
Mark Andrews
26be82ee90 missing newline in comment
(cherry picked from commit 7258b852cf)
2018-01-03 17:12:04 +11:00
Tinderbox User
3d87b339d1 update copyright notice / whitespace 2018-01-02 23:47:41 +00:00
Mark Andrews
4d16a4653d 4852. [bug] Add REQUIRE's and INSIST's to isc_time_formattimestamp,
isc_time_formathttptimestamp, isc_time_formatISO8601.
                        [RT #46892]
2018-01-02 10:49:43 +11:00
Tinderbox User
bb69fd0a5e regen v9_9 2017-12-29 07:38:35 +00:00
Tinderbox User
7aeee801e6 regen v9_9 2017-12-29 02:41:20 +00:00
Mark Andrews
9711fe2244 initalize sigsize to zero; ATF_CHECK_EQ(sigsize, tsig.siglen);
(cherry picked from commit 9f61f6b46b)
2017-12-22 08:59:15 +11:00
Mark Andrews
2884abf6a1 don't attempt to call isc_buffer_free(&buf) twice; don't attempt to call dns_message_destroy(&msg) twice; don't test for key != NULL
(cherry picked from commit cb8650d875)
2017-12-12 13:25:12 +11:00
Mark Andrews
4e7801ebfd 4842. [bug] Conditionally compile opensslecdsa_link.c to avoid
warnings about unused function. [RT #46790]

(cherry picked from commit 63459cdc05)
(cherry picked from commit 2d82ed9456)
2017-12-07 13:41:50 +11:00
Tinderbox User
92c1063230 update copyright notice / whitespace 2017-12-06 23:48:04 +00:00
Mark Andrews
7b34ba54c9 4841. [bug] Address -fsanitize=undefined warnings. [RT #46786]
(cherry picked from commit 9d5a0abe81)
(cherry picked from commit 58c86991ee)
2017-12-06 21:05:34 +11:00
Mark Andrews
3666b9bfb6 4839. [bug] zone.c:zone_sign was not properly determining
if there were active KSK and ZSK keys for
                        a algorithm when update-check-ksk is true
                        (default) leaving records unsigned with one or
                        more DNSKEY algorithms. [RT #46774]

(cherry picked from commit 00f5ea91cf)
2017-12-05 16:12:05 +11:00
Mark Andrews
2c0a365200 4838. [bug] zone.c:add_sigs was not properly determining
if there were active KSK and ZSK keys for
                        a algorithm when update-check-ksk is true
                        (default) leaving records unsigned with one or
                        more DNSKEY algorithms. [RT #46754]

(cherry picked from commit 6fa2a0691e)
(cherry picked from commit 677f507de7)
2017-12-05 09:44:49 +11:00
Mark Andrews
5ed673c0d2 4837. [bug] dns_update_signatures{inc} (add_sigs) was not
properly determining if there were active KSK and
                        ZSK keys for a algorithm when update-check-ksk is
                        true (default) leaving records unsigned. [RT #46743]

(cherry picked from commit 196e01da5f)
(cherry picked from commit bf459d24a1)
(cherry picked from commit 5623f65cc4)
2017-12-04 10:09:45 +11:00
Tinderbox User
03674299c7 update copyright notice / whitespace 2017-11-30 23:50:30 +00:00
Tinderbox User
a0c8227d06 update copyright notice / whitespace 2017-11-29 23:47:59 +00:00
Mark Andrews
5e94477563 4833. [bug] isc_event_free should check that the event is not
linked when called. [RT #46725]

4832.   [bug]           Events were not being removed from zone->rss_events.
                        [RT #46725]

(cherry picked from commit 9ddf7d6c4c)
2017-11-30 10:39:29 +11:00
Mark Andrews
a267c17a85 4831. [bug] Convert the RRSIG expirytime to 64 bits for
comparisions in diff.c:resign. [RT #46710]

(cherry picked from commit 0579a11658)
2017-11-29 15:31:53 +11:00
Tinderbox User
c49b27bc75 update copyright notice / whitespace 2017-11-28 23:48:09 +00:00
Mark Andrews
76cff0f786 4829. [bug] isc_heap_delete did not zero the index value when
the heap was created with a callback to do that.
                        [RT #46709]

(cherry picked from commit 65a483106e)
2017-11-28 19:04:56 +11:00
Mark Andrews
900560e800 map more entry points to <name>64 2017-11-28 14:16:57 +11:00
Mark Andrews
ade2ece256 #define update_recordsandbytes update_recordsandbytes64 2017-11-28 14:16:01 +11:00
Tinderbox User
230916c184 update copyright notice / whitespace 2017-11-27 23:50:30 +00:00
Mark Andrews
d5b0589e4c restore setting header->heap_index to zero in setsigningtime
(cherry picked from commit c22b540e4c)
2017-11-28 06:47:49 +11:00
Mark Andrews
d42c4a628d More:
4819.   [bug]           Fully backout the transaction when adding a RRset
                        to the resigning / removal heaps fails. [RT #46473]

(cherry picked from commit 19f6a63184)
2017-11-27 15:23:16 +11:00
Mark Andrews
d049bb62b8 add missing symbols 2017-11-27 15:04:33 +11:00
Mark Andrews
abbc4b2c4f 4817. [cleanup] Use DNS_NAME_INITABSOLUTE and DNS_NAME_INITNONABSOLUTE.
[RT #45433]
2017-11-27 13:30:58 +11:00
Mark Andrews
c4f2e47fea silence %lu vs size_t warning by casting to (unsigned long)
(cherry picked from commit 1dc8208a89)
2017-11-24 10:26:48 +11:00
Mark Andrews
889cc681eb in rdbdb.c:setsigningtime stop breaking heap invariant property unless we are going to restore the invariant property
(cherry picked from commit 6ead410268)
2017-11-24 08:51:14 +11:00
Mark Andrews
8572cac546 silence compiler warning [RT #46471] 2017-11-23 17:04:01 +11:00
Michał Kępień
bbfa83da40 [v9_9] Refactor reclimit system test
4823.	[test]		Refactor reclimit system test to improve its
			reliability and speed. [RT #46632]

(cherry picked from commit 1fd4803e84)
2017-11-21 10:34:03 +01:00
Tinderbox User
a42d1f9000 update copyright notice / whitespace 2017-11-17 23:47:28 +00:00
Mark Andrews
ae7cb54fe0 remove out of date comment
(cherry picked from commit a197094d76)
2017-11-18 08:52:10 +11:00
Mark Andrews
cae44b160b 4821. [bug] When resigning ensure that the SOA's expire time is
always later that the resigning time of other records.
                        [RT #46473]

4820.   [bug]           dns_db_subtractrdataset should transfer the resigning
                        information to the new header. [RT #46473]

4819.   [bug]           Fully backout the transaction when adding a RRset
                        to the resigning / removal heaps fail. [RT #46473]

(cherry picked from commit 656eed7c9b)
2017-11-18 07:32:10 +11:00
Michał Kępień
c799c10ffe [v9_9] Minor improvements to code handling managed keys
4812.	[bug]		Minor improvements to stability and consistency of code
			handling managed keys. [RT #46468]

(cherry picked from commit 54c1627c6f)
2017-11-09 15:21:04 +01:00
Michał Kępień
dbda79e4ec [v9_9] Prevent junk from being logged when using "also-notify { <ip> key <keyname>; };"
(cherry picked from commit 4034b098d8)
2017-11-08 09:22:34 +01:00
Mark Andrews
90f743306c don't use the ERR macro as GCC 7 only does a partial static analysis which generates false positives for fallthrough. [RT #46115]
(cherry picked from commit 0698ad8503)
2017-11-01 19:19:40 +11:00