Commit graph

181 commits

Author SHA1 Message Date
Brian Wellington
78838d3e0c 8 space -> tab conversion 2000-12-11 19:24:30 +00:00
Michael Sawyer
cc7732e129 RT#528 fixed 2000-12-08 17:06:52 +00:00
Michael Sawyer
789145979d Add bounds checking to various dig options 2000-11-21 20:55:00 +00:00
Mark Andrews
25a66b4e41 #include <isc/print.h> 2000-11-20 13:02:18 +00:00
Brian Wellington
78d78f05d9 556. [func] The DNSSEC OK bit in the EDNS extended flags
is now implemented.  Responses to queries without
                        this bit set will not contain any DNSSEC records.
2000-11-13 21:34:03 +00:00
Michael Sawyer
04ab4ecb27 Remove name limits and counter from dig; there's no obvious way to count
names out of message_parse when PRESERVE_ORDER is set.
2000-11-08 00:47:18 +00:00
Michael Sawyer
d1fb32ad95 Print the version number information with "dig" alone on the command line 2000-11-07 01:29:34 +00:00
Mark Andrews
368b37b616 dns_rdata_invalidate -> dns_rdata_reset 2000-10-31 03:22:05 +00:00
Mark Andrews
c03bb27f06 532. [func] Implement DNS UPDATE pseudo records using
DNS_RDATA_UPDATE flag.

 531.   [func]          Rdata really should be initalized before being
                        assigned to (dns_rdata_fromwire(), dns_rdata_fromtext(),
                        dns_rdata_clone(), dns_rdata_fromregion()),
                        check that it is.
2000-10-25 04:26:57 +00:00
Michael Sawyer
5d20773abc Move generation of reverse lookups (blah.in-addr.arpa, etc...) names to
a common place.
2000-10-23 23:13:21 +00:00
Andreas Gustafsson
8ab588369b use sizeof(), not hardcoded constant 2000-10-20 19:53:59 +00:00
Michael Sawyer
b3c93eb846 Evil bad buffer overflow bug. 2000-10-20 00:54:01 +00:00
Michael Sawyer
801d49df37 From Brian's review:
digrc filename print length shouldn't be 132
        bargc should be more than 14
        Opcode 100 spelled wrong in host.c
2000-10-19 23:31:56 +00:00
Michael Sawyer
d7a2e05112 Changes which were made on the release branch when Brian and I were reviewing
dig's code, but never made it down to the mainline.  These are fixes to some
potential bugs Brian noticed.
2000-10-19 22:49:34 +00:00
Michael Sawyer
7a87d1c63b Fix places where wrong tag was used in #ifdef's 2000-10-19 21:49:49 +00:00
Andreas Gustafsson
0067b1721e English style 2000-10-18 22:11:20 +00:00
Michael Sawyer
88aa63f566 Make option processing case sensitive.
Remove -w option; default xfr's to +nocomments, +noquestion.  Remove wiring
around repeated comment printing, so xfr's with +comments will cause
comment headers to be printed per packet, producing same result as -w
gave.
2000-10-17 00:35:18 +00:00
Michael Sawyer
d97ea44061 Cause -m (memory debugging) option in dig to actually function. 2000-10-16 19:00:01 +00:00
Brian Wellington
e2babfac17 dig now calls isc_mem_stats() only if -m was specified, not if
isc_mem_debugging was set elsewhere.
2000-10-13 22:55:50 +00:00
Michael Sawyer
233514c1da Add +besteffort option to dig (on by default) which will cause the
message parser to accept somewhat malformed packets.
2000-10-13 17:54:00 +00:00
Michael Sawyer
dc570b92f6 Add support for proposed ZONE and VIEW opt attributes. These are currently
hidden behind #ifdef's, since no OPT code number has yet to be assigned
by the IANA.  They are also not quite complete in all regards; VIEW
options are understood and ignored.  ZONE options are understood and
acted upon, though some of the error cases aren't quite right.

Remove doubled isc_mem_stats in dighost.c

Update todo list.

Change literal 255's to DNS_NAME_MAXWIRE in name.c
2000-10-11 17:44:18 +00:00
Mark Andrews
a6368669a6 '-p' is already taken, -p port. Use '-w' (wire) to print out the packet. 2000-10-03 04:29:08 +00:00
Michael Sawyer
d2792acfaf Add (presently undocumented) -p option to show the begin of each DNS packet,
useful for AXFR's and similar replies.  (requested by GDIB)
2000-10-02 16:43:25 +00:00
Michael Sawyer
a5e89a4493 Make -t and -c change command line parsing so that unprefixed class and types
are treated as hosts.
2000-10-02 16:16:50 +00:00
Michael Sawyer
aea4345be8 Remove unused variable 2000-09-30 00:09:57 +00:00
Michael Sawyer
10e1788f9f Dig changes in response to RT321 (output formatting) 2000-09-29 23:42:15 +00:00
Michael Sawyer
2f96e6b9bb Change sense of +fail option to something more reasonable 2000-09-28 23:02:28 +00:00
Michael Sawyer
056aaae3e2 Remove +details option 2000-09-27 00:02:02 +00:00
Andreas Gustafsson
07f1d27a64 spacing; removed redundant break statements that caused
compiler warnings
2000-09-26 17:17:39 +00:00
Michael Sawyer
0dabedcca5 Add +fail option to try next server after a SERVFAIL
Fix some minor problems in some of the new option processing code.
Slight change in mem debugging
TODO changes
2000-09-25 23:10:00 +00:00
Michael Sawyer
b02d8fe708 plus-options with values (+bufsize=8000) didn't print properly in the dig
comment lines since my change of option processing.  Fixed.
2000-09-25 16:14:20 +00:00
Michael Sawyer
31ce593907 Add back +norec
Properly test for missing argument in - options
Spacing
Remove unnecessary variable
2000-09-22 23:58:32 +00:00
Michael Sawyer
a985c480e1 Code cleanup, mainly in dig option processing. 2000-09-22 23:21:32 +00:00
Andreas Gustafsson
92aa706a21 the mnemonic for the chaos class is CH, not CHAOS 2000-09-22 17:36:02 +00:00
Mark Andrews
34fec86ca3 make next_token() shared. 2000-09-21 23:47:41 +00:00
Michael Sawyer
b8f9623df0 Remove isc_app_block() from dig's get_address(). 2000-09-21 23:02:34 +00:00
Michael Sawyer
f900be2190 Dig, et al:
When you have more than 1 nameserver to send queries to,
	send them one at a time with a 1 second wait between transmissions
	instead of just flooding them all out at once.

	Fix bug 348, nslookup crashing when server specified without server
2000-09-21 22:46:39 +00:00
Mark Andrews
e412ae947d 482. [bug] nslookup: a plain "server" or "lserver" should be
treated as a lookup.

 480
strsep() has slightly different semantics to strtok(), use static function
to skip empty tokens.
2000-09-21 12:25:43 +00:00
Mark Andrews
07a926724c 481. [bug] nslookup:get_next_command() stack size exceeds
per thread limit.

 480.   [bug]           strtok() is not thread safe. [RT #349]

	replaced strtok() w/ strsep().
2000-09-21 11:53:16 +00:00
Michael Sawyer
97beb7237b A couple of typos corrected
Improvement to host8 compatibility.
2000-09-13 00:27:27 +00:00
Michael Sawyer
f63a6079d3 Typo fixed
Add +ignore option
2000-09-13 00:03:28 +00:00
Andreas Gustafsson
736be84da0 previous change was correct for release branch, but incorrect
for the mainline
2000-09-12 23:23:49 +00:00
Andreas Gustafsson
1024973c81 ISC_TRUE, not 1 2000-09-12 22:18:42 +00:00
Brian Wellington
6f710fce2d #include <time.h> 2000-08-26 01:51:37 +00:00
Brian Wellington
668bd3acee dig now does reverse IPv6 address lookup. 2000-08-14 20:23:39 +00:00
Brian Wellington
a81dd161f7 The +cdflag and +adflag lines in the help text were duplicated. 2000-08-10 15:45:54 +00:00
Michael Sawyer
19c8df90f1 Support yet another strange set of nslookup options.
nslookup - nameserver         nslookup -nameserver
are both listed in the old man page.  Both now are supported.
2000-08-03 17:43:06 +00:00
David Lawrence
281b7ba834 Variable "have_host" was set but never used. -- removed variable 2000-08-02 19:47:17 +00:00
Michael Sawyer
48674819eb 367. [func] Allow proper selection of server on nslookup command
line.

 366.   [func]          Allow use of '-' batch file in dig for stdin.
2000-08-02 17:58:07 +00:00
David Lawrence
40f53fa8d9 Trailing whitespace trimmed. Perhaps running "perl util/spacewhack.pl in your
own CVS tree will help minimize CVS conflicts.  Maybe not.
Blame Graff for getting me to trim all trailing whitespace.
2000-08-01 01:33:37 +00:00
Michael Sawyer
082bc93d68 Various changes (mostly small) picked up in code review 2000-08-01 00:53:20 +00:00
Brian Wellington
eec79d5e4d more isc_memdebugging cleanup 2000-07-28 00:04:44 +00:00
David Lawrence
15a4474541 word wrap copyright notice at column 70 2000-07-27 09:55:03 +00:00
Michael Sawyer
fcc6d71462 Don't crash if someone specifies an option (like -f) to dig without its
argument.
2000-07-25 00:51:14 +00:00
Michael Sawyer
aa38fc9f67 Move .digrc to home dir, and hide behinf #ifndef NOPOSIX 2000-07-24 23:13:44 +00:00
Michael Sawyer
1933e4c41f Allow users to place a .digrc file in the current directory which will
specify defaults.
2000-07-24 20:46:55 +00:00
Michael Sawyer
a056a85de0 Improve searchlist code 2000-07-24 18:07:03 +00:00
Andreas Gustafsson
baf50a7210 removed unsightly spaces 2000-07-21 21:21:26 +00:00
Michael Sawyer
8bf0f722f8 Count and possibly limit how many names and rr's in a xfr.
(Needed by GDIB folks)
2000-07-20 19:41:44 +00:00
Michael Sawyer
26cebf3482 Slight bug in batch processing 2000-07-20 17:56:20 +00:00
Michael Sawyer
68f0d29d61 Fix a minor race condition in SIGINT handling
Allow dig to used name key files
Allow SIGINT in nslookup
2000-07-19 17:52:27 +00:00
Michael Sawyer
5e804988e9 Add comments to source code 2000-07-18 18:51:40 +00:00
Michael Sawyer
aa6054ec74 Clean up type and class code. (No more ugly istype() and isclass() functions)
Minor changes to timeout handling code.
Don't preload batch file.
2000-07-18 01:28:20 +00:00
Michael Sawyer
4b7d316065 A few bug fixes. 2000-07-14 21:33:03 +00:00
Michael Sawyer
8cd54a7461 Lots of changes to the shutdown code. Get rid of the annoying "just exit"
method of shutting down.
Known bug: SIGINT while doing batch mode causes assertion.
2000-07-14 17:57:27 +00:00
Michael Sawyer
e715e01178 More code duplication removal and general cleanup
Slight change in +nssearch output formatting
2000-07-14 16:35:30 +00:00
Michael Sawyer
a31dbaa03f Replace +aa option, per AG. 2000-07-13 21:12:21 +00:00
Michael Sawyer
8f56f93547 Clean up duplicate code in host.c
Fix a socket cleanup problem which, in some isolated cases, prevented
correct shutdown.
Remove +aa option completely.
2000-07-13 21:01:00 +00:00
Michael Sawyer
c5ec9b45bb Lots of duplicate code removed
+tcp mode bug fixed
2000-07-13 18:52:58 +00:00
Michael Sawyer
738310d8cf It's probably a bad idea to pre-allocate 64K buffers for each lookup as soon
as you read in the batch file.  Don't.
2000-07-13 01:22:38 +00:00
Michael Sawyer
76959783dd Documentation changes in usage message. 2000-07-12 17:44:03 +00:00
Michael Sawyer
473cb90680 Choose reasonable default values for +trace mode. 2000-07-12 01:41:35 +00:00
Andreas Gustafsson
969b3374ed no space between function name and arg list 2000-07-12 00:22:57 +00:00
Michael Sawyer
6331b9a45e Don't try and reset timers which aren't being used. 2000-07-11 17:35:49 +00:00
Brian Wellington
3ce3305278 Remove a race condition where the final event could be posted before
isc_app_run started.
2000-07-10 18:02:31 +00:00
Michael Sawyer
38cf6e52ce Lots of style changes.
Clean up what appears to be a varient of the race condition, this one set
off in nslookup.
2000-07-05 23:28:32 +00:00
Andreas Gustafsson
24139527f3 lots of style changes; no functional change 2000-07-05 19:31:26 +00:00
Michael Sawyer
1893b56ef9 Move taskmgr shutdown to the correct place. 2000-06-30 14:11:49 +00:00
Michael Sawyer
db8b100cae DO NOT PULL ME UP TO THE RELEASE BRANCH.
This is a fix for the race condition in dig.  It seems to work well, except
there's a memory leak I can't quite track down.  Michael and I will look at
it on the plane ride tommorow, and commit a change via modem once we arrive
in PA.  We'll also be doing general code cleanup.
2000-06-29 05:21:12 +00:00
Michael Sawyer
84c4c99c9e 290. [cleanup] +twiddle option to dig (for testing only) removed. 2000-06-28 18:20:44 +00:00
Mark Andrews
abeb505bb6 276. [bug] dig now supports maximum sized TCP messages. 2000-06-23 16:53:53 +00:00
Michael Sawyer
23e8d9349b Make host -C and dig +nss actually work. 2000-06-22 22:37:31 +00:00
David Lawrence
bb18b04113 "we much have recovered" -> "we must have recovered" 2000-06-22 17:23:48 +00:00
David Lawrence
9ef9f6b8ae #include style lint 2000-06-22 01:26:38 +00:00
Michael Sawyer
c9defbf4b9 Sort #includes 2000-06-21 17:48:32 +00:00
Michael Sawyer
d821f1cd7e Additional debugging options
% comment option in dig
2000-06-21 01:40:42 +00:00
Michael Sawyer
a414896ee9 +ad/+noad option conflicting with +additional/+noadditional option 2000-06-19 19:00:49 +00:00
Michael Sawyer
518c9fea58 Add ability to set AD and CD flags in outgoing query. 2000-06-16 18:00:05 +00:00
Michael Sawyer
960c8888f6 TSIG verification of xfr replies working now. 2000-06-07 00:13:57 +00:00
Michael Sawyer
d62f922122 Fix segfault due to uninitialized variable 2000-06-06 23:06:25 +00:00
Michael Sawyer
910df0c767 Further attempts to make XFR's verify with TSIG keys. Still not
functional, and disabled in this checkin.
Added -debug and -memdebug command line options, to avoid having
to recompile every time these options are needed.
2000-06-06 22:50:44 +00:00
Michael Sawyer
47058d1726 Validate TSIG signatures on replies, *except* for xfr's.
Add Id string.
2000-06-06 18:49:06 +00:00
Michael Sawyer
a5ed46c9fd Send TSIG signed queries with dig. This version requires all queries
from a single invocation of dig use the same key, and doesn't validate
replies yet.  Also, keys must be passed on the command line with the
-y option.  -k forthcoming.
2000-06-06 00:43:17 +00:00
Michael Sawyer
d12ed0876f Add ixfr support to dig, as:
dig domain.nil. ixfr=12345
where 12345 is version you are ixrf'ing against
(testing still in progress of this option)
2000-06-02 18:45:33 +00:00
David Lawrence
7efc8c3f69 Megacommit of many files.
Mostly, several functions that take pointers as arguments, almost
always char * pointers, had those pointers qualified with "const".
Those that returned pointers to previously const-qualified arguments
had their return values qualified as const.  Some structure members
were qualified as const to retain that attribute from the variables
from which they were assigned.

Minor other ISC style cleanups.
2000-06-01 18:49:22 +00:00
Brian Wellington
83a44df0a1 include dns/name.h 2000-05-30 22:27:27 +00:00
Michael Sawyer
cc88be4af1 Change global task variable to global_task
Remove unused globals
2000-05-26 22:03:00 +00:00
Michael Sawyer
36e4d8878c Clean up uninitialized variable bug 2000-05-25 17:24:57 +00:00
Michael Sawyer
6afdb1e5e4 Clean up some unused variables... 2000-05-25 00:01:30 +00:00
Michael Sawyer
0eb5cf7351 Fix lookup limit.
Fix non-closing of sockets when finished.
2000-05-24 23:39:30 +00:00