"./rdata/any_255/tsig_250.c", line 74: remark(1506): implicit conversion from
"unsigned long" to "int": rounding, sign extension, or loss of
accuracy may result
"./rdata/any_255/tsig_250.c", line 95: remark(1506): implicit conversion from
"unsigned long" to "int": rounding, sign extension, or loss of
accuracy may result
The values in question were already being checked to be within the range of
a short, so where the warnings were occuring they were just cast to int.
"./rdata/generic/tkey_249.c", line 89: remark(1506): implicit conversion from
"unsigned long" to "int": rounding, sign extension, or loss of
accuracy may result
"./rdata/generic/tkey_249.c", line 98: remark(1506): implicit conversion from
"unsigned long" to "int": rounding, sign extension, or loss of
accuracy may result
The values in question were already being checked to be within the range of
a short, so where the warnings were occuring they were just cast to int.
"./rdata/generic/unspec_103.c", line 138: warning(1184): possible use of "="
where "==" was intended
by changing to ==, which is clearly what was intended.
"./rdata/generic/opt_41.c", line 73: remark(1552): variable "option" was set
but never used
by removing option, because there was nothing to do with its value.
"./rdata/in_1/a6_38.c", line 259: remark(1552): variable "octets" was set but
never used
by using UNUSED() on this stack variable. I didn't take it out altogether
because this function is not yet finished, but someone was starting to
do some work on it and I didn't want to undo that.
"./rdata/generic/nxt_30.c", line 66: warning(1042): operand types are
incompatible ("char *" and "void *")
by casting to char *, as already being done with several other uses of
token.value.as_pointer.
"./rdata/generic/loc_29.c", line ??: remark(1506): implicit conversion from
"unsigned long" to "int": rounding, sign extension, or loss of
accuracy may result
by making sure that the range was suitable for an int and casting to
int in each case. (This appeared to be more desirable than changing
all of the variables in question to longs.)
"./rdata/generic/mx_15.c", line 202: warning(1184): possible use of "=" where
"==" was intended
by changing to == since it was clear that test was desired, not assignment.
"./rdata/in_1/a_1.c", line 178: warning(1184): possible use of "=" where "=="
was intended
"./rdata/in_1/a_1.c", line 179: warning(1184): possible use of "=" where "=="
was intended
By chaning them to ==, because (a) we don't allow side-effects in REQUIRE()
and (b) it is clear from the rest of the code that it really was a test that
was desired and not an assignment.
Cleanup of redundant/useless header file inclusion.
ISC style lint, primarily for function declarations and standalone
comments -- ie, those that appear on a line without any code, which
should be written as follows:
/*
* This is a comment.
*/
is NULL then you need to preserve the 'rdata' until
you have finished using the structure as there may be
references to the associated memory. If 'mctx' is non
NULL it is guarenteed that there are no references to
to memory addsociated with 'rdata'.
dns_rdata_freestruct() must be called if 'mctx' was
non NULL and may safely be called if 'mctx' was NULL.
Finish implementing 153 for IN specific types.
naptr_35.h some of the lengths should be 8 bits.
Added:
isc_buffer_base(b) (pointer)
isc_buffer_current(b) (pointer)
isc_buffer_active(b) (pointer)
isc_buffer_used(b) (pointer)
isc_buffer_length(b) (int)
isc_buffer_usedlength(b) (int)
isc_buffer_consumedlength(b) (int)
isc_buffer_remaininglength(b) (int)
isc_buffer_activelength(b) (int)
isc_buffer_availablelength(b) (int)
Removed:
ISC_BUFFER_USEDCOUNT(b)
ISC_BUFFER_AVAILABLECOUNT(b)
isc_buffer_type(b)
Changed names:
isc_buffer_used(b, r) ->
isc_buffer_usedregion(b, r)
isc_buffer_available(b, r) ->
isc_buffer_available_region(b, r)
isc_buffer_consumed(b, r) ->
isc_buffer_consumedregion(b, r)
isc_buffer_active(b, r) ->
isc_buffer_activeregion(b, r)
isc_buffer_remaining(b, r) ->
isc_buffer_remainingregion(b, r)
Buffer types were removed, so the ISC_BUFFERTYPE_*
macros are no more, and the type argument to
isc_buffer_init and isc_buffer_allocate were removed.
isc_buffer_putstr is now void (instead of isc_result_t)
and requires that the caller ensure that there
is enough available buffer space for the string.
build a table of them using gen.c. This means the names are stored twice,
but that will change in the near future. This will speed up number to text
conversions for rdatatypes, and I plan on speeding up text->number as
well, soon.
Style updates.
Correct some comments.
Printing "other" field now respects multiline mode.
from/to struct routines now allocate 0 byte memory instead of
leaving the pointer NULL if keylen or otherlen are 0.
. removed strtol which was irrelevant (its results were not checked,
and dns_cert_fromtext did the real parsing).
. removed redundant range checking (uint16_tobuffer did the same
checking.
Use UNUSED() macro.
draft-ietf-dnssec-certs-04.txt -> RFC 2538
Move bind_ttl to ttl.c and rename dns_ttl_fromtext and dns_counter_fromtext,
fix bug in handling of seconds (x 1 not x 60), can also handle raw number.
uint16_tobuffer is called the loss of data from strtol() already occurred
and uint16_tobuffer would not be able to detect a range error.
delint: integral size mismatch in call to dns_rcode_totext with a 32 bit
int passed where a 16 bit is expected. since the variable was retrieved
via uint16_fromregion immediately prior to dns_rcode_totext, casting
the 32 bit to 16 bit (to dns_rcode_t) is sufficient.
uint16_tobuffer is called the loss of data from strtol() already occurred
and uint16_tobuffer would not be able to detect a range error.
also, use token.value.as_char when assigning to char c, which is already
checked to be < 256.
that is read via strtol() rather than assigning covered directly from strtol(),
so that a value greater than the width of dns_rdatatype_t can be detected.
int passed where a 16 bit is expected. since the variable was retrieved
via uint16_fromregion immediately prior to dns_cert_totext, casting
the 32 bit to 16 bit (to dns_cert_t) is sufficient.
