Commit graph

41 commits

Author SHA1 Message Date
Ondřej Surý
288f5a4b52 Various little fixes found by coccinelle
The coccinellery repository provides many little semantic patches to fix common
problems in the code.  The number of semantic patches in the coccinellery
repository is high and most of the semantic patches apply only for Linux, so it
doesn't make sense to run them on regular basis as the processing takes a lot of
time.

The list of issue found in BIND 9, by no means complete, includes:

- double assignment to a variable
- `continue` at the end of the loop
- double checks for `NULL`
- useless checks for `NULL` (cannot be `NULL`, because of earlier return)
- using `0` instead of `NULL`
- useless extra condition (`if (foo) return; if (!foo) { ...; }`)
- removing & in front of static functions passed as arguments
2019-10-01 16:48:55 +02:00
Mark Andrews
2de94dd4c4 address NULL pointer dereferences 2019-09-04 11:27:16 +10:00
Michał Kępień
b5cd146033 Always include <errno.h> instead of <sys/errno.h>
Including <sys/errno.h> instead of <errno.h> raises a compiler warning
when building against musl libc.  Always include <errno.h> instead of
<sys/errno.h> to prevent that compilation warning from being triggered
and to achieve consistency in this regard across the entire source tree.
2019-07-30 21:25:18 +02:00
Ondřej Surý
04961a7e6b Revert "Downgrade the dns_clientinfomethod structure to the version in lib/dns/clientinfo.c"
This reverts commit a6f09b2255.
2019-06-20 12:46:21 +02:00
Ondřej Surý
a6f09b2255 Downgrade the dns_clientinfomethod structure to the version in lib/dns/clientinfo.c 2019-04-09 10:06:12 +01:00
Ondřej Surý
78d0cb0a7d Use coccinelle to remove explicit '#include <config.h>' from the source files 2019-03-08 15:15:05 +01:00
Mark Andrews
c9dc59eb90 properly detect period as last character in filename 2019-03-05 13:50:22 -08:00
Mark Andrews
218ce34e7d correct errno to result translation 2019-02-20 09:43:16 +11:00
Evan Hunt
2e3b5db195 added DNAME support to DLZ LDAP schema, and fixed a DLZ compile error
Thanks to Roland Gruber for the schema contribution.
2019-02-10 11:49:01 -08:00
Roland Gruber
83903f6f5e Add optional description field to LDAP schema 2018-12-20 09:47:07 +01:00
Witold Kręcicki
5cdb38c2c7 Remove unthreaded support 2018-08-16 17:18:52 +02:00
Ondřej Surý
994e656977 Replace custom isc_boolean_t with C standard bool type 2018-08-08 09:37:30 +02:00
Ondřej Surý
cb6a185c69 Replace custom isc_u?intNN_t types with C99 u?intNN_t types 2018-08-08 09:37:28 +02:00
Ondřej Surý
55a10b7acd Remove $Id markers, Principal Author and Reviewed tags from the full source tree 2018-05-11 13:17:46 +02:00
Ondřej Surý
11f26b42e3 Replace all usage of non-reentrant strtok() with strtok_r() 2018-04-12 10:37:33 +02:00
Ondřej Surý
921d05ddcf Replace usage of strsep with POSIX strtok_r() 2018-04-12 10:37:33 +02:00
Mark Andrews
9492533d46 ignore Makefile 2017-10-11 10:59:46 +11:00
Mark Andrews
fa512bc524 ignore Makefile
(cherry picked from commit 65d59e1418)
2017-10-08 06:53:12 +11:00
Evan Hunt
fd140b1261 [master] use mysql_config if available
4763.	[contrib]	Improve compatibility when building MySQL DLZ
			module by using mysql_config if available.
			[RT #45558]
2017-10-06 19:09:30 -07:00
Mark Andrews
e3d74bdd7f copyright 2016-07-21 19:38:52 +10:00
Witold Krecicki
047e477d27 4401. [bug] Fix leaks in contrib DLZ code. [RT #42707] 2016-06-22 14:55:22 +02:00
Mark Andrews
cd6eeeb827 4350. [contrib] Declare result in dlz_filesystem_dynamic.c. 2016-04-29 10:08:50 +10:00
Mark Andrews
913d976eca 4263. [contrib] Address compiler warnings in mysqldyn module.
[RT #41130]
2015-11-20 16:07:43 +11:00
Mark Andrews
09f4e41912 4231. [contrib] Address unchecked calloc call in dlz_mysqldyn_mod.c.
[RT #40840]
2015-09-30 15:38:32 +10:00
Mark Andrews
0dc485ffb6 4230. [contrib] dlz_wildcard_dynamic.c:dlz_create could return a
uninitalised result. [RT #40839]
2015-09-30 15:33:16 +10:00
Mark Andrews
7b1f63dcd1 4209. [bug] Address resource leaks in dlz modules. [RT #40654] 2015-09-17 13:19:35 +10:00
Evan Hunt
d261093639 [master] possible null deref in dlz_wildcard
4206.   [bug]           contrib: fixed a possible NULL dereference in
                        DLZ wildcard module. [RT #40745]
2015-09-14 10:40:07 -07:00
Evan Hunt
ff7cc592b7 [master] fixed testing problems with bdbhtp DLZ module 2015-02-12 10:20:36 -08:00
Mark Andrews
b16d99bac1 3872. [bug] Address issues found by static analysis. [RT #36209] 2014-06-10 09:17:15 +10:00
Evan Hunt
aefb3e308b [master] better DDNS in DLZ; mysqldyn
3821.	[contrib]	Added a new "mysqldyn" DLZ module with dynamic
			update and transaction support. Thanks to Marty
			Lee for the contribution. [RT #35656]

3820.	[func]		The DLZ API doesn't pass the database version to
			the lookup() function; this can cause DLZ modules
			that allow dynamic updates to mishandle prerequisite
			checks. This has been corrected by adding a
			'dbversion' field to the dns_clientinfo_t
			structure. [RT #35656]
2014-04-25 13:06:30 -07:00
Evan Hunt
a2fd1de97d [master] fix DLZ coredump
3777.	[bug]		EDNS EXPIRE code could dump core when processing
			DLZ queries. [RT #35493]
2014-03-06 11:06:30 -08:00
Evan Hunt
6be12fa63b [master] contrib: sqlite3 DLZ module
3772.	[contrib]	Added sqlite3 dynamically-loadable DLZ module.
			(Based in part on a contribution from Tim Tessier.)
			[RT #20822]
2014-03-02 22:16:29 -08:00
Evan Hunt
5f8d6cec48 [master] fix null deref in some DLZ modules
3691.	[contrib]	Address null pointer dereference in LDAP and
			MySQL DLZ modules.
2013-12-14 11:05:58 -08:00
Evan Hunt
8c910d0e38 [master] correct John Eaglesham's email in perl module README 2013-07-25 09:00:07 -07:00
Evan Hunt
f469d5d440 [master] make LDAP DLZ module work with older DLZ 2013-07-03 13:57:58 -07:00
Evan Hunt
43d8d314d5 [master] added missing Makefile to perl DLZ modules 2013-07-02 20:47:15 -07:00
Evan Hunt
3b9ba6bd74 [master] added DLZ Perl module
3602.	[contrib]	Added DLZ Perl module, allowing Perl scripts to
			integrate with named and serve DNS data.
			(Contributed by John Eaglesham of Yahoo.)
2013-06-24 23:08:26 -07:00
Evan Hunt
5ba1d3dcc5 [master] mysql DLZ module
3569.	[contrib]	Ported mysql DLZ driver to dynamically-loadable
			module, and added multithread support. [RT #33394]
2013-05-06 10:54:14 -07:00
Evan Hunt
ee2a7c7bf6 [master] remove spurious fprintf 2013-03-21 07:39:57 -07:00
Evan Hunt
72c86c105a [master] DLZ modules: filesystem, ldap, wildcard
3523.	[contrib]	Ported filesystem and ldap DLZ drivers to
			dynamically-loadable modules, and added the
			"wildcard" module based on a contribution from
			Vadim Goncharov <vgoncharov@nic.ru>. [RT #23569]
2013-03-11 17:03:46 -07:00
Evan Hunt
62d63e5f02 [master] contrib: add bdbhpt DLZ module
3493.	[contrib]	Added BDBHPT dynamically-lodable DLZ module,
			contributed by Mark Goldfinch. [RT #32549]
2013-02-21 18:06:50 -08:00