Commit graph

208 commits

Author SHA1 Message Date
Michał Kępień
dadca599da [v9_10] Remove REQUIRE preventing change 4592 from working
Change 4592 was supposed to replace a REQUIRE with a conditional return.
While the latter was added, the former was not removed.  Remove the
relevant REQUIRE to fix RT #43822 for good.

(cherry picked from commit a94d68ce43)
2017-10-24 21:11:52 +02:00
Evan Hunt
70590c691b [v9_10] fix dispatch.c shutdown race
4952.	[bug]		A race condition on shutdown could trigger an
			assertion failure in dispatch.c. [RT #43822]

(cherry picked from commit 019132b70c)
2017-04-20 17:42:03 -07:00
Mark Andrews
6d93a4e91a remove outdated cvs $Id strings 2017-02-03 18:41:40 +11:00
Tinderbox User
28f72096e7 update copyright notice / whitespace 2017-01-14 23:46:28 +00:00
Mark Andrews
80d5fed95a 4554. [bug] Remove double unlock in dns_dispatchmgr_setudp.
[RT #44336]

(cherry picked from commit 5dfa5221d5)
2017-01-14 13:14:35 +11:00
Tinderbox User
5591cf2635 update copyright notice / whitespace 2016-08-16 23:46:14 +00:00
Mukund Sivaraman
418b43028e Fix RPZ CIDR tree insertion bug (#43035)
(cherry picked from commit 131307a70e)
2016-08-15 17:07:06 +05:30
Mark Andrews
374fce8495 4074. [cleanup] Cleaned up more warnings from gcc -Wshadow. [RT #38708]
(cherry picked from commit af669cb4fd)

Conflicts:
	bin/named/client.c
	lib/dns/request.c
	lib/dns/view.c
2015-02-27 10:59:45 +11:00
Tinderbox User
d5bad8c9b9 update copyright notice / whitespace 2015-02-10 23:45:50 +00:00
Evan Hunt
a7db54206c [v9_10] fix PRNG selection in dispatch.c
4058.	[bug]		UDP dispatches could use the wrong psuedorandom
			number generator context. [RT #38578]
2015-02-10 13:55:14 -08:00
Tinderbox User
d5a5ca7225 update copyright notice 2014-09-30 23:46:53 +00:00
Mark Andrews
a6869655d6 3961. [bug] Forwarding of SIG(0) signed UPDATE messages failed with
BADSIG.  [RT #37216]
2014-10-01 07:37:27 +10:00
Mark Andrews
23cd746fc2 3913. [bug] Address race issue in dispatch. [RT #36731]
(cherry picked from commit 493f3eb297)
2014-08-06 18:50:45 +10:00
Evan Hunt
38c3ed154a [master] fix race
3804.   [bug]           Corrected a race condition in dispatch.c in which
                        portentry could be reset leading to an assertion
                        failure in socket_search(). (Change #3708
                        addressed the same issue but was incomplete.)
                        [RT #35128]
2014-04-07 13:54:08 -07:00
Mark Andrews
702958d202 3708. [bug] Address a portentry locking issue in dispatch.c.
[RT #35128]
2014-01-15 15:55:35 +11:00
Tinderbox User
431a83fb29 update copyright notice 2014-01-09 23:46:35 +00:00
Mark Andrews
109f477ed7 silence compiler warning 2014-01-09 15:57:59 +11:00
Evan Hunt
e851ea8260 [master] replace memcpy() with memmove().
3698.	[cleanup]	Replaced all uses of memcpy() with memmove().
			[RT #35120]
2014-01-08 16:39:05 -08:00
Evan Hunt
2b258a1f5b [master] dispatch.c race
3695.	[bug]		Address a possible race in dispatch.c. [RT #35107]
2013-12-23 09:50:18 -08:00
Evan Hunt
0606c47750 [master] correct dispatch address/port check
3690.	[bug]		Iterative responses could be missed when the source
			port for an upstream query was the same as the
			listener port (53). [RT #34925]
2013-12-12 22:39:12 -08:00
Evan Hunt
b99bfa184b [master] unify internal and export libraries
3550.	[func]		Unified the internal and export versions of the
			BIND libraries, allowing external clients to use
			the same libraries as BIND. [RT #33131]
2013-04-10 13:49:57 -07:00
Evan Hunt
67adc03ef8 [master] add DSCP support
3535.	[func]		Add support for setting Differentiated Services Code
			Point (DSCP) values in named.  Most configuration
			options which take a "port" option (e.g.,
			listen-on, forwarders, also-notify, masters,
			notify-source, etc) can now also take a "dscp"
			option specifying a code point for use with
			outgoing traffic, if supported by the underlying
			OS. [RT #27596]
2013-03-22 14:05:33 -07:00
Tinderbox User
dc3d68d6fe update copyright notice 2013-01-11 23:46:02 +00:00
Mark Andrews
99394e9807 3465. [bug] Handle isolated reserved ports. [RT #31778] 2013-01-11 14:10:07 +11:00
Mark Andrews
4151109b94 silence clang --analyze warnings 2012-11-30 18:50:38 +11:00
Evan Hunt
47c5b8af92 [master] silence coverity warnings
3401.	[bug]		Addressed Coverity warnings. [RT #31484]
2012-10-23 22:04:06 -07:00
Evan Hunt
41bbb34bc2 fix coverity issues
3388.	[bug]		Fixed several Coverity warnings. [RT #30996]
2012-10-02 23:44:03 -07:00
Evan Hunt
da35568c71 use correct port range
3382.	[bug]		SOA query from slave used use-v6-udp-ports range,
			if set, regardless of the address family in use.
			[RT #24173]
2012-09-26 13:55:18 -07:00
Evan Hunt
dd2a0a6d2d Merge statistics code (ATT SoW, rt24117)
This includes the following changes:

3326.	[func]		Added task list statistics: task model, worker
			threads, quantum, tasks running, tasks ready.
			[RT #27678]

3325.	[func]		Report cache statistics: memory use, number of
			nodes, number of hash buckets, hit and miss counts.
			[RT #27056]

3324.	[test]		Add better tests for ADB stats [RT #27057]

3323.	[func]		Report the number of buckets the resolver is using.
			[RT #27020]

3322.	[func]		Monitor the number of active TCP and UDP dispatches.
			[RT #27055]

3321.	[func]		Monitor the number of recursive fetches and the
			number of open sockets, and report these values in
			the statistics channel. [RT #27054]

3320.	[func]		Added support for monitoring of recursing client
			count. [RT #27009]

3319.	[func]		Added support for monitoring of ADB entry count and
			hash size. [RT #27057]
2012-05-14 10:06:05 -07:00
Evan Hunt
970aa7d783 missing braces; style glitch 2012-05-03 14:01:32 -07:00
Tinderbox User
ee980d3fc4 update copyright notice 2012-04-28 23:45:42 +00:00
Evan Hunt
54489ba167 Improve locking performance in dispatch.c
3316.	[tuning]	Improved locking performance when recursing.
			[RT #28836]

   - Use one lock per memory pool instead of associating
     them all with a single 'pool_lock' in the dispatch manager.
   - Reduce the critical sections for qid->lock in get_dispsocket(),
     deref_portentry() and dns_dispatch_addresponse2().
   - Added a memory pool for socket events in dns_dispatch_t.
   - Add an isc_socketevent_t member in the resquery_t object, and use
     it with isc_socket_sendto2() instead of using isc_socket_sendto()
   - Tuned the memory pools in dispatch.c for better performance
     under load
2012-04-28 14:52:28 -07:00
Evan Hunt
4e8fe357a6 create and use multiple fetch dispatches
Added API to create a set of UDP dispatches which can be shared
round-robin style when making upstream queries for authoritative
data; this should reduce lock contention in the query source
dispatch.
2012-04-27 16:11:30 -07:00
Mark Andrews
23daf8948b 3225. [bug] Silence spurious "setsockopt(517, IPV6_V6ONLY) failed"
messages. [RT #26507]
2011-11-29 01:03:47 +00:00
Automatic Updater
2f17ad4545 update copyright notice 2011-07-28 23:47:59 +00:00
Evan Hunt
f07b2fccaf 3137. [func] Improve hardware scalability by allowing multiple
worker threads to process incoming UDP packets.
			This can significantly increase query throughput
			on some systems.  [RT #22992]
2011-07-28 04:04:37 +00:00
Mark Andrews
9cf04a12ec 3095. [bug] Handle isolated reserved ports in the port range.
[RT #23957]
2011-04-06 10:27:16 +00:00
Mark Andrews
0874abad14 3069. [cleanup] Silence warnings messages from clang static analysis.
[RT #20256]
2011-03-11 06:11:27 +00:00
Automatic Updater
784a904bd0 update copyright notice 2011-02-03 12:18:12 +00:00
Mark Andrews
000a8970f8 3011. [func] Change the default query timeout from 30 seconds
to 10.  Allow setting this in named.conf using the new
                        'resolver-query-timeout' option, which specifies a max
                        time in seconds.  0 means 'default' and anything longer
                        than 30 will be silently set to 30. [RT #22852]
2011-02-03 05:41:55 +00:00
Mark Andrews
2a0d4c4d6b 2797. [bug] Don't decrement the dispatch manager's maxbuffers.
[RT #20613]
2009-12-02 23:15:14 +00:00
Automatic Updater
2b2fc9b4df update copyright notice 2009-11-25 23:49:22 +00:00
Mark Andrews
536e36ac8d declarations before statements 2009-11-25 13:17:59 +00:00
Evan Hunt
cfc22e53a8 2789. [bug] Fixed an INSIST in dispatch.c [RT #20576] 2009-11-25 05:55:32 +00:00
Tatuya JINMEI 神明達哉
307d208450 2660. [func] Add a new set of DNS libraries for non-BIND9
applications.  See README.libdns. [RT #19369]
2009-09-01 00:22:28 +00:00
Tatuya JINMEI 神明達哉
089f456eb3 2588. [bug] SO_REUSEADDR could be set unconditionally after failure
of bind(2) call.  This should be rare and mostly
			harmless, but may cause interference with other
			processes that happen to use the same port. [RT #19642]
2009-04-28 21:39:00 +00:00
Mark Andrews
870a748bae isc_statscounter_t 2009-01-31 00:37:04 +00:00
Mark Andrews
f19e6ef1eb 2541. [bug] Conditionally update dispatch manager statistics.
[RT #19247]
2009-01-31 00:10:24 +00:00
Tatuya JINMEI 神明達哉
d9059b0c38 2537. [func] Added more statistics counters including those on socket
I/O events and query RTT histograms.  [RT #18802]
2009-01-27 22:30:00 +00:00
Automatic Updater
d362465c77 update copyright notice 2009-01-17 23:47:43 +00:00