bind9/bin/tests
Michał Kępień 2ee7ff23ce Only use LC_ALL=C where intended
The LC_ALL=C assignments in the "idna" system test, which were only
meant to affect a certain subset of checks, in fact persist throughout
all the subsequent checks in that system test.  That affects the test's
behavior and is misleading.

When the "VARIABLE=value command ..." syntax is used in a shell script,
in order for the variable assignment to only apply to "command", the
latter must be an external binary; otherwise, the VARIABLE=value
assignment persists for all subsequent commands in a script:

    $ cat foo.sh
    #!/bin/sh

    foo() {
        /bin/sh bar.sh
    }

    BAR="baz0"
    BAR="baz1" /bin/sh bar.sh
    echo "foo: BAR=${BAR}"
    BAR="baz2" foo
    echo "foo: BAR=${BAR}"

    $ cat bar.sh
    #!/bin/sh

    echo "bar: BAR=${BAR}"

    $ /bin/sh foo.sh
    bar: BAR=baz1
    foo: BAR=baz0
    bar: BAR=baz2
    foo: BAR=baz2
    $

Fix by saving the value of LC_ALL before the relevant set of checks in
the "idna" system test, restoring it afterwards, and dropping the
"LC_ALL=C command ..." syntax.
2019-12-10 10:56:19 +01:00
..
bigtest update file headers 2018-03-15 18:33:13 -07:00
optional Refactor dns_name_dup() usage using the semantic patch 2019-11-29 14:00:37 +01:00
pkcs11 address or suppress cppcheck warnings 2019-09-12 17:59:28 +10:00
startperf Remove $Id markers, Principal Author and Reviewed tags from the full source tree 2018-05-11 13:17:46 +02:00
system Only use LC_ALL=C where intended 2019-12-10 10:56:19 +01:00
testdata/wire move all optional tests from bin/tests to bin/tests/optional 2018-03-09 14:12:47 -08:00
win32 Make VS solution upgrading unnecessary 2019-09-26 15:11:15 +02:00
.gitignore Remove genrandom command and all usage of specific random files throughout the system test suite 2018-05-16 09:54:35 +02:00
cfg_test.c Use the semantic patch to change the usage isc_mem_create() to new API 2019-09-12 09:26:09 +02:00
fromhex.pl Update license headers to not include years in copyright in all applicable files 2018-02-23 10:12:02 +01:00
headerdep_test.sh.in Remove $Id markers, Principal Author and Reviewed tags from the full source tree 2018-05-11 13:17:46 +02:00
Makefile.in add a search for GeoIP2 libraries in configure 2019-06-27 14:58:13 -07:00
makejournal.c Use the semantic patch to change the usage isc_mem_create() to new API 2019-09-12 09:26:09 +02:00
named.conf update documentation 2019-06-05 07:49:57 -07:00
wire_test.c Use the semantic patch to change the usage isc_mem_create() to new API 2019-09-12 09:26:09 +02:00