bind9/bin
Matthijs Mekking 2fc42b598b Fix a quirky mkeys test failure
The mkeys system test started to fail after introducing support for
zones transitioning to unsigned without going bogus. This is because
there was actually a bug in the code: if you reconfigure a zone and
remove the "auto-dnssec" option, the zone is actually still DNSSEC
maintained. This is because in zoneconf.c there is no call
to 'dns_zone_setkeyopt()' if the configuration option is not used
(cfg_map_get(zoptions, "auto-dnssec", &obj) will return an error).

The mkeys system test implicitly relied on this bug: initially the
root zone is being DNSSEC maintained, then at some point it needs to
reset the root zone in order to prepare for some tests with bad
signatures. Because it needs to inject a bad signature, 'auto-dnssec'
is removed from the configuration.

The test pass but for the wrong reasons:

I:mkeys:reset the root server
I:mkeys:reinitialize trust anchors
I:mkeys:check positive validation (18)

The 'check positive validation' test works because the zone is still
DNSSEC maintained: The DNSSEC records in the signed root zone file on
disk are being ignored.

After fixing the bug/introducing graceful transition to insecure,
the root zone is no longer DNSSEC maintained after the reconfig.

The zone now explicitly needs to be reloaded because otherwise the
'check positive validation' test works against an old version of the
zone (the one with all the revoked keys), and the test will obviously
fail.
2020-12-23 09:02:11 +01:00
..
check Add libssl libraries to Windows build 2020-11-09 16:00:28 +01:00
confgen Add libssl libraries to Windows build 2020-11-09 16:00:28 +01:00
delv Reformat sources using clang-format-11 2020-12-08 18:36:23 +01:00
dig Reformat sources using clang-format-11 2020-12-08 18:36:23 +01:00
dnssec Treat dnssec-policy "none" as a builtin zone 2020-12-23 09:02:11 +01:00
named Treat dnssec-policy "none" as a builtin zone 2020-12-23 09:02:11 +01:00
nsupdate Add libssl libraries to Windows build 2020-11-09 16:00:28 +01:00
pkcs11 Add libssl libraries to Windows build 2020-11-09 16:00:28 +01:00
plugins Use libuv's shared library handling capabilities 2020-10-28 15:48:58 +01:00
rndc Drop unused headers 2020-11-11 10:08:12 +01:00
tests Fix a quirky mkeys test failure 2020-12-23 09:02:11 +01:00
tools Handle shared library platforms that don't support inter library dependancies 2020-12-21 01:09:45 +00:00
win32/BINDInstall Revert "Drop bigkey" 2020-11-10 17:34:05 +01:00
Makefile.am Complete rewrite the BIND 9 build system 2020-04-21 14:19:48 +02:00