mirror of
https://github.com/isc-projects/bind9.git
synced 2026-02-26 19:41:04 -05:00
e395ff54e5
cppcheck is not aware that the bin/dnssec/dnssectool.c:fatal() function
does not return. This triggers certain cppcheck 2.2 false positives,
for example:
bin/dnssec/dnssec-signzone.c:3470:13: warning: Either the condition 'ndskeys==8' is redundant or the array 'dskeyfile[8]' is accessed at index 8, which is out of bounds. [arrayIndexOutOfBoundsCond]
dskeyfile[ndskeys++] = isc_commandline_argument;
^
bin/dnssec/dnssec-signzone.c:3467:16: note: Assuming that condition 'ndskeys==8' is not redundant
if (ndskeys == MAXDSKEYS) {
^
bin/dnssec/dnssec-signzone.c:3470:13: note: Array index out of bounds
dskeyfile[ndskeys++] = isc_commandline_argument;
^
bin/dnssec/dnssec-signzone.c:771:20: warning: Either the condition 'l->hashbuf==NULL' is redundant or there is pointer arithmetic with NULL pointer. [nullPointerArithmeticRedundantCheck]
memset(l->hashbuf + l->entries * l->length, 0, l->length);
^
bin/dnssec/dnssec-signzone.c:767:18: note: Assuming that condition 'l->hashbuf==NULL' is not redundant
if (l->hashbuf == NULL) {
^
bin/dnssec/dnssec-signzone.c:771:20: note: Null pointer addition
memset(l->hashbuf + l->entries * l->length, 0, l->length);
^
Instead of suppressing all such warnings individually, conditionally
define a preprocessor macro which prevents them from being triggered.
(cherry picked from commit d9701e22b5)
117 lines
2.6 KiB
C++
117 lines
2.6 KiB
C++
/*
|
|
* Copyright (C) Internet Systems Consortium, Inc. ("ISC")
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, you can obtain one at https://mozilla.org/MPL/2.0/.
|
|
*
|
|
* See the COPYRIGHT file distributed with this work for additional
|
|
* information regarding copyright ownership.
|
|
*/
|
|
|
|
#ifndef DNSSECTOOL_H
|
|
#define DNSSECTOOL_H 1
|
|
|
|
#include <inttypes.h>
|
|
#include <stdbool.h>
|
|
|
|
#include <isc/log.h>
|
|
#include <isc/platform.h>
|
|
#include <isc/stdtime.h>
|
|
|
|
#include <dns/rdatastruct.h>
|
|
|
|
#include <dst/dst.h>
|
|
|
|
/*! verbosity: set by -v and -q option in each program, defined in dnssectool.c
|
|
*/
|
|
extern int verbose;
|
|
extern bool quiet;
|
|
|
|
/*! program name, statically initialized in each program */
|
|
extern const char *program;
|
|
|
|
/*!
|
|
* List of DS digest types used by dnssec-cds and dnssec-dsfromkey,
|
|
* defined in dnssectool.c. Filled in by add_dtype() from -a
|
|
* arguments, sorted (so that DS records are in a canonical order) and
|
|
* terminated by a zero. The size of the array is an arbitrary limit
|
|
* which should be greater than the number of known digest types.
|
|
*/
|
|
extern uint8_t dtype[8];
|
|
|
|
typedef void(fatalcallback_t)(void);
|
|
|
|
#ifndef CPPCHECK
|
|
ISC_PLATFORM_NORETURN_PRE void
|
|
fatal(const char *format, ...)
|
|
ISC_FORMAT_PRINTF(1, 2) ISC_PLATFORM_NORETURN_POST;
|
|
#else /* CPPCHECK */
|
|
#define fatal(...) exit(1)
|
|
#endif
|
|
|
|
void
|
|
setfatalcallback(fatalcallback_t *callback);
|
|
|
|
void
|
|
check_result(isc_result_t result, const char *message);
|
|
|
|
void
|
|
vbprintf(int level, const char *fmt, ...) ISC_FORMAT_PRINTF(2, 3);
|
|
|
|
ISC_PLATFORM_NORETURN_PRE void
|
|
version(const char *program) ISC_PLATFORM_NORETURN_POST;
|
|
|
|
void
|
|
sig_format(dns_rdata_rrsig_t *sig, char *cp, unsigned int size);
|
|
#define SIG_FORMATSIZE \
|
|
(DNS_NAME_FORMATSIZE + DNS_SECALG_FORMATSIZE + sizeof("65535"))
|
|
|
|
void
|
|
setup_logging(isc_mem_t *mctx, isc_log_t **logp);
|
|
|
|
void
|
|
cleanup_logging(isc_log_t **logp);
|
|
|
|
dns_ttl_t
|
|
strtottl(const char *str);
|
|
|
|
dst_key_state_t
|
|
strtokeystate(const char *str);
|
|
|
|
isc_stdtime_t
|
|
strtotime(const char *str, int64_t now, int64_t base, bool *setp);
|
|
|
|
dns_rdataclass_t
|
|
strtoclass(const char *str);
|
|
|
|
unsigned int
|
|
strtodsdigest(const char *str);
|
|
|
|
void
|
|
add_dtype(unsigned int dt);
|
|
|
|
isc_result_t
|
|
try_dir(const char *dirname);
|
|
|
|
void
|
|
check_keyversion(dst_key_t *key, char *keystr);
|
|
|
|
void
|
|
set_keyversion(dst_key_t *key);
|
|
|
|
bool
|
|
key_collision(dst_key_t *key, dns_name_t *name, const char *dir,
|
|
isc_mem_t *mctx, bool *exact);
|
|
|
|
bool
|
|
isoptarg(const char *arg, char **argv, void (*usage)(void));
|
|
|
|
#ifdef _WIN32
|
|
void
|
|
InitSockets(void);
|
|
void
|
|
DestroySockets(void);
|
|
#endif /* ifdef _WIN32 */
|
|
|
|
#endif /* DNSSEC_DNSSECTOOL_H */
|