Ondřej Surý 46f6bb6364 Size HMAC key generation buffers to the maximum block size ... hmac_generate() declared its on-stack nonce buffer as unsigned char data[ISC_MAX_MD_SIZE], i.e. 64 bytes. That is the maximum digest size, but the buffer is filled up to the algorithm's HMAC block size, which is 128 bytes for SHA-384 and SHA-512. Asking rndc-confgen for an HMAC-SHA-384 or HMAC-SHA-512 key with -b > 512 (the documented range allows up to 1024) wrote past the end of the stack buffer; on hardened builds this aborted with a stack-smash detector firing instead of producing a key. Use the existing ISC_MAX_BLOCK_SIZE (128) for the buffer so the full 1..1024 range advertised by -A hmac-sha{384,512} works as documented. The matching key_rawsecret[64] in confgen's generate_key() is enlarged the same way so the generated key fits when dumped to the buffer. Add a system test that exercises rndc-confgen across the previously overflowing keysizes; with -Db_sanitize=address it caught the abort before the fix. Assisted-by: Claude:claude-opus-4-7		2026-04-29 19:21:20 +02:00
..
startperf	Reformat shell scripts with shfmt	2023-10-26 10:23:50 +02:00
system	Size HMAC key generation buffers to the maximum block size	2026-04-29 19:21:20 +02:00
testdata/wire
.gitignore	Move environment variables from conf.sh to pytest	2024-05-09 17:08:08 +02:00
meson.build	replace the build system with meson	2025-06-11 10:30:12 +03:00
test_client.c	Add and use global memory context called isc_g_mctx	2025-08-04 11:29:26 +02:00
test_server.c	Add and use global memory context called isc_g_mctx	2025-08-04 11:29:26 +02:00