bind9/lib
Tony Finch ac5d61541d Remove a redundant variable-length array
In the GSS-TSIG verification code there was an alarming
variable-length array whose size came off the network, from the
signature in the request. It turned out to be safe, because the caller
had previously checked that the signature had a reasonable size.
However, the safety checks are in the generic TSIG implementation, and
the risky VLA usage was in the GSS-specific code, and they are
separated by the DST indirection layer, so it wasn't immediately
obvious that the risky VLA was in fact safe.

In fact this risky VLA was completely unnecessary, because the GSS
signature can be verified in place without being copied to the stack,
like the message covered by the signature. The `REGION_TO_GBUFFER()`
macro backwardly assigns the region in its left argument to the GSS
buffer in its right argument; this is just a pointer and length
conversion, without copying any data. The `gss_verify_mic()` call uses
both message and signature GSS buffers in a read-only manner.

(cherry picked from commit eeead1cfe7)
2022-03-18 16:05:56 +00:00
..
bind9 Update the copyright information in all files in the repository 2022-01-11 09:05:02 +01:00
dns Remove a redundant variable-length array 2022-03-18 16:05:56 +00:00
irs Update the copyright information in all files in the repository 2022-01-11 09:05:02 +01:00
isc Add couple missing braces around single-line statements 2022-03-17 18:29:57 +01:00
isccc Use ISC_R_SHUTTINGDOWN to detect netmgr shutting down 2022-01-13 09:14:12 +01:00
isccfg Check dnssec-policy key roles for validity 2022-03-08 14:28:53 +11:00
ns Change xfer-out timer message log level to DEBUG(1) 2022-03-17 21:38:24 +01:00
.gitignore The isc/platform.h header has been completely removed 2021-07-06 05:33:48 +00:00
Makefile.am move samples/resolve.c to bin/tests/system 2021-04-16 14:29:43 +02:00
unit-test-driver.sh.in Update the copyright information in all files in the repository 2022-01-11 09:05:02 +01:00