mirror of
https://github.com/isc-projects/bind9.git
synced 2026-05-28 04:34:54 -04:00
871bce312b
When the arc4random_uniform() is called on NetBSD with upper_bound that makes no sense statistically (0 or 1), the call crashes the calling program. Fix this by returning 0 when upper bound is < 2 as does Linux, FreeBSD and NetBSD. (Hint: System CSPRNG should never crash.)
78 lines
2.1 KiB
C
78 lines
2.1 KiB
C
/*
|
|
* Copyright (C) Internet Systems Consortium, Inc. ("ISC")
|
|
*
|
|
* SPDX-License-Identifier: MPL-2.0
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, you can obtain one at https://mozilla.org/MPL/2.0/.
|
|
*
|
|
* See the COPYRIGHT file distributed with this work for additional
|
|
* information regarding copyright ownership.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <inttypes.h>
|
|
#include <stdlib.h>
|
|
|
|
#include <isc/types.h>
|
|
|
|
/*! \file isc/random.h
|
|
* \brief Implements wrapper around a cryptographically secure
|
|
* pseudo-random number generator.
|
|
*
|
|
*/
|
|
|
|
#if HAVE_ARC4RANDOM && !defined(__linux__)
|
|
#define isc_random32() arc4random()
|
|
#define isc_random_buf(buf, buflen) arc4random_buf(buf, buflen)
|
|
#define isc_random_uniform(upper_bound) \
|
|
((upper_bound) < 2 ? 0 : arc4random_uniform(upper_bound))
|
|
#else /* HAVE_ARC4RANDOM && !defined(__linux__) */
|
|
uint32_t
|
|
isc_random32(void);
|
|
/*!<
|
|
* \brief Returns a single 32-bit random value.
|
|
*/
|
|
|
|
void
|
|
isc_random_buf(void *buf, size_t buflen);
|
|
/*!<
|
|
* \brief Fills the region buf of length buflen with random data.
|
|
*/
|
|
|
|
uint32_t
|
|
isc_random_uniform(uint32_t upper_bound);
|
|
/*!<
|
|
* \brief Returns a single 32-bit uniformly distributed random value
|
|
* less than upper_bound.
|
|
*
|
|
* This is better than ``isc_random() % upper_bound'' as it avoids
|
|
* "modulo bias" when the upper bound is not a power of two. This
|
|
* function is also faster, because it usually avoids doing any
|
|
* divisions (which are typically very slow).
|
|
*
|
|
* It uses rejection sampling to ensure uniformity, so it may require
|
|
* multiple iterations to get a result; the probability of needing to
|
|
* resample is very small when the upper_bound is small, rising to 0.5
|
|
* when upper_bound is UINT32_MAX/2.
|
|
*/
|
|
|
|
#endif /* HAVE_ARC4RANDOM && !defined(__linux__) */
|
|
|
|
static inline uint8_t
|
|
isc_random8(void) {
|
|
return (uint8_t)isc_random32();
|
|
}
|
|
/*!<
|
|
* \brief Returns a single 8-bit random value.
|
|
*/
|
|
|
|
static inline uint16_t
|
|
isc_random16(void) {
|
|
return (uint16_t)isc_random32();
|
|
}
|
|
/*!<
|
|
* \brief Returns a single 16-bit random value.
|
|
*/
|