mirror of
https://github.com/isc-projects/bind9.git
synced 2026-05-28 04:34:54 -04:00
2e1dd56d0b
The following TSAN report about accessing the mgr timers (mgr->init,
mgr->idle, mgr->keepalive and mgr->advertised) has been fixed in this
commit:
==================
WARNING: ThreadSanitizer: data race (pid=2746)
Read of size 4 at 0x7b440008a948 by thread T18:
#0 isc__nm_tcpdns_read /home/ondrej/Projects/bind9/lib/isc/netmgr/tcpdns.c:849:25 (libisc.so.1706+0x2ba0f)
#1 isc_nm_read /home/ondrej/Projects/bind9/lib/isc/netmgr/netmgr.c:1679:3 (libisc.so.1706+0x22258)
#2 tcpdns_connect_connect_cb /home/ondrej/Projects/bind9/lib/isc/tests/tcpdns_test.c:363:2 (tcpdns_test+0x4bc5fb)
#3 isc__nm_async_connectcb /home/ondrej/Projects/bind9/lib/isc/netmgr/netmgr.c:1816:2 (libisc.so.1706+0x228c9)
#4 isc__nm_connectcb /home/ondrej/Projects/bind9/lib/isc/netmgr/netmgr.c:1791:3 (libisc.so.1706+0x22713)
#5 tcpdns_connect_cb /home/ondrej/Projects/bind9/lib/isc/netmgr/tcpdns.c:343:2 (libisc.so.1706+0x2d89d)
#6 uv__stream_connect /home/ondrej/Projects/tsan/libuv/src/unix/stream.c:1381:5 (libuv.so.1+0x27c18)
#7 uv__stream_io /home/ondrej/Projects/tsan/libuv/src/unix/stream.c:1298:5 (libuv.so.1+0x25977)
#8 uv__io_poll /home/ondrej/Projects/tsan/libuv/src/unix/linux-core.c:462:11 (libuv.so.1+0x2e795)
#9 uv_run /home/ondrej/Projects/tsan/libuv/src/unix/core.c:385:5 (libuv.so.1+0x158ec)
#10 nm_thread /home/ondrej/Projects/bind9/lib/isc/netmgr/netmgr.c:530:11 (libisc.so.1706+0x1c94a)
Previous write of size 4 at 0x7b440008a948 by main thread:
#0 isc_nm_settimeouts /home/ondrej/Projects/bind9/lib/isc/netmgr/netmgr.c:490:12 (libisc.so.1706+0x1dda5)
#1 tcpdns_recv_two /home/ondrej/Projects/bind9/lib/isc/tests/tcpdns_test.c:601:2 (tcpdns_test+0x4bad0e)
#2 cmocka_run_one_test_or_fixture <null> (libcmocka.so.0+0x70be)
#3 __libc_start_main /build/glibc-vjB4T1/glibc-2.28/csu/../csu/libc-start.c:308:16 (libc.so.6+0x2409a)
Location is heap block of size 281 at 0x7b440008a840 allocated by main thread:
#0 malloc <null> (tcpdns_test+0x42864b)
#1 default_memalloc /home/ondrej/Projects/bind9/lib/isc/mem.c:713:8 (libisc.so.1706+0x6d261)
#2 mem_get /home/ondrej/Projects/bind9/lib/isc/mem.c:622:8 (libisc.so.1706+0x69b9c)
#3 isc___mem_get /home/ondrej/Projects/bind9/lib/isc/mem.c:1044:9 (libisc.so.1706+0x6d379)
#4 isc__mem_get /home/ondrej/Projects/bind9/lib/isc/mem.c:2432:10 (libisc.so.1706+0x6889e)
#5 isc_nm_start /home/ondrej/Projects/bind9/lib/isc/netmgr/netmgr.c:203:8 (libisc.so.1706+0x1c219)
#6 nm_setup /home/ondrej/Projects/bind9/lib/isc/tests/tcpdns_test.c:244:11 (tcpdns_test+0x4baaa4)
#7 cmocka_run_one_test_or_fixture <null> (libcmocka.so.0+0x70fd)
#8 __libc_start_main /build/glibc-vjB4T1/glibc-2.28/csu/../csu/libc-start.c:308:16 (libc.so.6+0x2409a)
Thread T18 'isc-net-0000' (tid=3513, running) created by main thread at:
#0 pthread_create <null> (tcpdns_test+0x429e7b)
#1 isc_thread_create /home/ondrej/Projects/bind9/lib/isc/pthreads/thread.c:73:8 (libisc.so.1706+0x8476a)
#2 isc_nm_start /home/ondrej/Projects/bind9/lib/isc/netmgr/netmgr.c:271:3 (libisc.so.1706+0x1c66a)
#3 nm_setup /home/ondrej/Projects/bind9/lib/isc/tests/tcpdns_test.c:244:11 (tcpdns_test+0x4baaa4)
#4 cmocka_run_one_test_or_fixture <null> (libcmocka.so.0+0x70fd)
#5 __libc_start_main /build/glibc-vjB4T1/glibc-2.28/csu/../csu/libc-start.c:308:16 (libc.so.6+0x2409a)
SUMMARY: ThreadSanitizer: data race /home/ondrej/Projects/bind9/lib/isc/netmgr/tcpdns.c:849:25 in isc__nm_tcpdns_read
==================
ThreadSanitizer: reported 1 warnings
|
||
|---|---|---|
| .. | ||
| include | ||
| netmgr | ||
| pthreads | ||
| tests | ||
| unix | ||
| win32 | ||
| .gitignore | ||
| aes.c | ||
| api | ||
| app.c | ||
| assertions.c | ||
| astack.c | ||
| backtrace.c | ||
| base32.c | ||
| base64.c | ||
| bind9.c | ||
| buffer.c | ||
| commandline.c | ||
| counter.c | ||
| crc64.c | ||
| entropy.c | ||
| entropy_private.h | ||
| error.c | ||
| event.c | ||
| fsaccess_common.c | ||
| fsaccess_common_p.h | ||
| glob.c | ||
| hash.c | ||
| heap.c | ||
| hex.c | ||
| hmac.c | ||
| hp.c | ||
| ht.c | ||
| httpd.c | ||
| iterated_hash.c | ||
| lex.c | ||
| lib.c | ||
| log.c | ||
| Makefile.am | ||
| md.c | ||
| mem.c | ||
| mem_p.h | ||
| mutexblock.c | ||
| netaddr.c | ||
| netscope.c | ||
| nonce.c | ||
| openssl_shim.c | ||
| openssl_shim.h | ||
| parseint.c | ||
| pk11.c | ||
| pk11_result.c | ||
| pool.c | ||
| portset.c | ||
| queue.c | ||
| quota.c | ||
| radix.c | ||
| random.c | ||
| ratelimiter.c | ||
| regex.c | ||
| region.c | ||
| result.c | ||
| rwlock.c | ||
| safe.c | ||
| serial.c | ||
| siphash.c | ||
| sockaddr.c | ||
| stats.c | ||
| string.c | ||
| symtab.c | ||
| task.c | ||
| task_p.h | ||
| taskpool.c | ||
| timer.c | ||
| tm.c | ||
| utf8.c | ||