mirror of
https://github.com/isc-projects/bind9.git
synced 2026-02-22 09:20:51 -05:00
This commit reverts the previous change to use system provided entropy, as (SYS_)getrandom is very slow on Linux because it is a syscall. The change introduced in this commit adds a new call isc_nonce_buf that uses CSPRNG from cryptographic library provider to generate secure data that can be and must be used for generating nonces. Example usage would be DNS cookies. The isc_random() API has been changed to use fast PRNG that is not cryptographically secure, but runs entirely in user space. Two contestants have been considered xoroshiro family of the functions by Villa&Blackman and PCG by O'Neill. After a consideration the xoshiro128starstar function has been used as uint32_t random number provider because it is very fast and has good enough properties for our usage pattern. The other change introduced in the commit is the more extensive usage of isc_random_uniform in places where the usage pattern was isc_random() % n to prevent modulo bias. For usage patterns where only 16 or 8 bits are needed (DNS Message ID), the isc_random() functions has been renamed to isc_random32(), and isc_random16() and isc_random8() functions have been introduced by &-ing the isc_random32() output with 0xffff and 0xff. Please note that the functions that uses stripped down bit count doesn't pass our NIST SP 800-22 based random test.
154 lines
4.3 KiB
C
154 lines
4.3 KiB
C
/*
|
|
* Copyright (C) Internet Systems Consortium, Inc. ("ISC")
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*
|
|
* See the COPYRIGHT file distributed with this work for additional
|
|
* information regarding copyright ownership.
|
|
*/
|
|
|
|
/*
|
|
* Portions of isc_random_uniform():
|
|
*
|
|
* Copyright (c) 1996, David Mazieres <dm@uun.org>
|
|
* Copyright (c) 2008, Damien Miller <djm@openbsd.org>
|
|
*
|
|
* Permission to use, copy, modify, and distribute this software for any
|
|
* purpose with or without fee is hereby granted, provided that the above
|
|
* copyright notice and this permission notice appear in all copies.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
|
|
* WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
|
|
* MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
|
|
* ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
|
|
* WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
|
|
* ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
|
|
* OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
|
|
*/
|
|
|
|
#include <config.h>
|
|
|
|
#include <stdint.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <unistd.h>
|
|
|
|
#include <isc/random.h>
|
|
#include <isc/result.h>
|
|
#include <isc/types.h>
|
|
#include <isc/util.h>
|
|
|
|
#include <isc/once.h>
|
|
|
|
#include "entropy_private.h"
|
|
|
|
/*
|
|
* The specific implementation for PRNG is included as a C file
|
|
* that has to provide a static variable named seed, and a function
|
|
* uint32_t next(void) that provides next random number.
|
|
*
|
|
* The implementation must be thread-safe.
|
|
*/
|
|
|
|
/*
|
|
* Two contestants have been considered: the xoroshiro family of the
|
|
* functions by Villa&Blackman, and PCG by O'Neill. After
|
|
* consideration, the xoshiro128starstar function has been chosen as
|
|
* the uint32_t random number provider because it is very fast and has
|
|
* good enough properties for our usage pattern.
|
|
*/
|
|
#include "xoshiro128starstar.c"
|
|
|
|
static isc_once_t isc_random_once = ISC_ONCE_INIT;
|
|
|
|
static void
|
|
isc_random_initialize(void) {
|
|
isc_entropy_get(seed, sizeof(seed));
|
|
}
|
|
|
|
uint8_t
|
|
isc_random8(void) {
|
|
RUNTIME_CHECK(isc_once_do(&isc_random_once,
|
|
isc_random_initialize) == ISC_R_SUCCESS);
|
|
return (next() & 0xff);
|
|
}
|
|
|
|
uint16_t
|
|
isc_random16(void) {
|
|
RUNTIME_CHECK(isc_once_do(&isc_random_once,
|
|
isc_random_initialize) == ISC_R_SUCCESS);
|
|
return (next() & 0xffff);
|
|
}
|
|
|
|
uint32_t
|
|
isc_random32(void) {
|
|
RUNTIME_CHECK(isc_once_do(&isc_random_once,
|
|
isc_random_initialize) == ISC_R_SUCCESS);
|
|
return (next());
|
|
}
|
|
|
|
void
|
|
isc_random_buf(void *buf, size_t buflen) {
|
|
REQUIRE(buf);
|
|
REQUIRE(buflen > 0);
|
|
|
|
RUNTIME_CHECK(isc_once_do(&isc_random_once,
|
|
isc_random_initialize) == ISC_R_SUCCESS);
|
|
|
|
int i;
|
|
uint32_t r;
|
|
|
|
for (i = 0; i + sizeof(r) <= buflen; i += sizeof(r)) {
|
|
r = next();
|
|
memmove((uint8_t *)buf + i, &r, sizeof(r)); /* Buffers cannot
|
|
* really overlap
|
|
* here */
|
|
}
|
|
r = next();
|
|
memmove((uint8_t *)buf + i, &r, buflen % sizeof(r)); /* Buffer cannot
|
|
* really overlap
|
|
* here */
|
|
return;
|
|
}
|
|
|
|
uint32_t
|
|
isc_random_uniform(uint32_t upper_bound) {
|
|
/* Copy of arc4random_uniform from OpenBSD */
|
|
uint32_t r, min;
|
|
|
|
RUNTIME_CHECK(isc_once_do(&isc_random_once,
|
|
isc_random_initialize) == ISC_R_SUCCESS);
|
|
|
|
if (upper_bound < 2) {
|
|
return (0);
|
|
}
|
|
|
|
#if (ULONG_MAX > 0xffffffffUL)
|
|
min = 0x100000000UL % upper_bound;
|
|
#else /* if (ULONG_MAX > 0xffffffffUL) */
|
|
/* Calculate (2**32 % upper_bound) avoiding 64-bit math */
|
|
if (upper_bound > 0x80000000) {
|
|
min = 1 + ~upper_bound; /* 2**32 - upper_bound */
|
|
} else {
|
|
/* (2**32 - (x * 2)) % x == 2**32 % x when x <= 2**31 */
|
|
min = ((0xffffffff - (upper_bound * 2)) + 1) % upper_bound;
|
|
}
|
|
#endif /* if (ULONG_MAX > 0xffffffffUL) */
|
|
|
|
/*
|
|
* This could theoretically loop forever but each retry has
|
|
* p > 0.5 (worst case, usually far better) of selecting a
|
|
* number inside the range we need, so it should rarely need
|
|
* to re-roll.
|
|
*/
|
|
for (;;) {
|
|
r = next();
|
|
if (r >= min) {
|
|
break;
|
|
}
|
|
}
|
|
|
|
return (r % upper_bound);
|
|
}
|