Aram Sargsyan 2a57c12922 Remove an unnecessary NULL-check ... In the ns__client_put_cb() callback function the 'client->manager' pointer is guaranteed to be non-NULL, because in ns__client_request(), before setting up the callback, the ns__client_setup() function is called for the 'client', which makes sure that 'client->manager' is set. Removing the NULL-check resolves the following static analyzer warning: /lib/ns/client.c: 1675 in ns__client_put_cb() 1669 dns_message_puttemprdataset(client->message, &client->opt); 1670 } 1671 client_extendederror_reset(client); 1672 1673 dns_message_detach(&client->message); 1674 >>> CID 465168: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "client->manager" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 1675 if (client->manager != NULL) { 1676 ns_clientmgr_detach(&client->manager); 1677 } 1678 1679 /* 1680 * Detaching the task must be done after unlinking from		2023-09-14 10:39:24 +00:00
..
include	Allocate DNS send buffers using dedicated per-worker memory arenas	2023-09-05 15:02:30 +02:00
client.c	Remove an unnecessary NULL-check	2023-09-14 10:39:24 +00:00
hooks.c	Update sources to Clang 15 formatting	2022-11-29 09:14:07 +01:00
interfacemgr.c	remove nonfunctional DSCP implementation	2023-01-09 14:23:26 -08:00
listenlist.c	remove nonfunctional DSCP implementation	2023-01-09 14:23:26 -08:00
log.c	Update the copyright information in all files in the repository	2022-01-11 09:05:02 +01:00
Makefile.am	Move all the unit tests to /tests/<libname>/	2022-05-31 12:06:00 +02:00
notify.c	Update the copyright information in all files in the repository	2022-01-11 09:05:02 +01:00
query.c	prevent query_coveringnsec() from running twice	2023-08-21 14:31:10 -07:00
server.c	Allocate DNS send buffers using dedicated per-worker memory arenas	2023-09-05 15:02:30 +02:00
sortlist.c	De-duplicate __FILE__, __LINE__	2022-10-17 16:00:26 +01:00
stats.c	Update the copyright information in all files in the repository	2022-01-11 09:05:02 +01:00
tests	Move all the unit tests to /tests/<libname>/	2022-05-31 12:06:00 +02:00
update.c	rr_exists should not error if the name does not exist	2023-08-30 10:05:09 +10:00
xfrout.c	Implement new -T options for xfer system tests	2023-04-21 17:21:32 +02:00