mirror of
https://github.com/isc-projects/bind9.git
synced 2026-02-26 03:11:56 -05:00
42e4e3b843
The netmgr unit tests were designed to push the system limits to maximum
by sending as many queries as possible in the busy loop from multiple
threads. This mostly works with UDP, but in the stateful protocol where
establishing the connection takes more time, it failed quite often in
the CI. On FreeBSD, this happened more often, because the socket() call
would fail spuriosly making the problem even worse.
This commit does several things to improve reliability:
* return value of isc_nm_<proto>connect() is always checked and retried
when scheduling the connection fails
* The busy while loop has been slowed down with usleep(1000); so the
netmgr threads could schedule the work and get executed.
* The isc_thread_yield() was replaced with usleep(1000); also to allow
the other threads to do any work.
* Instead of waiting on just one variable, we wait for multiple
variables to reach the final value
* We are wrapping the netmgr operations (connects, reads, writes,
accepts) with reference counting and waiting for all the callbacks to
be accounted for.
This has two effects:
a) the isc_nm_t is always clean of active sockets and handles when
destroyed, so it will prevent the spurious INSIST(references == 1)
from isc_nm_destroy()
b) the unit test now ensures that all the callbacks are always called
when they should be called, so any stuck test means that there was
a missing callback call and it is always a real bug
These changes allows us to remove the workaround that would not run
certain tests on systems without port load-balancing.
|
||
|---|---|---|
| .. | ||
| bindkeys.pl | ||
| branchsync.sh | ||
| check-categories.sh | ||
| check-changes | ||
| check-cocci | ||
| check-includes.pl | ||
| check-instincludes.sh | ||
| check-line-length.sh | ||
| check-make-install.in | ||
| check-pullups.pl | ||
| check-sources.pl | ||
| check-win32util-configure | ||
| checklibs.sh | ||
| commit-arm.sh | ||
| COPYRIGHT | ||
| COPYRIGHT.BRIEF | ||
| COPYRIGHT.BSDI | ||
| COPYRIGHT.NAI | ||
| COPYRIGHT.NOM | ||
| COPYRIGHT.PORTION | ||
| COPYRIGHT.TOP | ||
| copyrights | ||
| git-replay-merge.sh | ||
| kit.sh | ||
| mandoc2docbook.pl | ||
| mdnbuildtest.sh | ||
| memleak.pl | ||
| merge_copyrights | ||
| models.c | ||
| nanny.pl | ||
| new-func | ||
| nt-kit | ||
| pairwise-testing.sh | ||
| parse_tsan.py | ||
| run-clang-tidy | ||
| spacewhack.pl | ||
| suppressions.txt | ||
| tabify-changes | ||
| unused-headers.sh | ||
| update-drafts.pl | ||
| update_branches | ||
| update_copyrights | ||