From d8735450c5812d91e48d0ea32ec6c79753362d35 Mon Sep 17 00:00:00 2001 From: Thomas Waldmann Date: Sat, 2 Jul 2022 21:55:45 +0200 Subject: [PATCH 1/5] remove deprecated --noatime not storing atime is the default since 1.2. --noatime is deprecated since 1.2. there is --atime if you want to store the atime. --- src/borg/archiver.py | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/borg/archiver.py b/src/borg/archiver.py index 3d2885d3f..59ca92803 100644 --- a/src/borg/archiver.py +++ b/src/borg/archiver.py @@ -2833,7 +2833,6 @@ class Archiver: def preprocess_args(self, args): deprecations = [ # ('--old', '--new' or None, 'Warning: "--old" has been deprecated. Use "--new" instead.'), - ('--noatime', None, 'Warning: "--noatime" has been deprecated because it is the default now.'), ('--nobsdflags', None, 'Warning: "--nobsdflags" has been deprecated. Use --noflags instead.'), ('--numeric-owner', None, 'Warning: "--numeric-owner" has been deprecated. Use --numeric-ids instead.'), ('--remote-ratelimit', None, 'Warning: "--remote-ratelimit" has been deprecated. Use --upload-ratelimit instead.'), @@ -3707,10 +3706,6 @@ class Archiver: help='deprecated, use ``--numeric-ids`` instead') fs_group.add_argument('--numeric-ids', dest='numeric_ids', action='store_true', help='only store numeric user and group identifiers') - # --noatime is the default now and the flag is deprecated. args.noatime is not used any more. - # use --atime if you want to store the atime (default behaviour before borg 1.2.0a7).. - fs_group.add_argument('--noatime', dest='noatime', action='store_true', - help='do not store atime into archive') fs_group.add_argument('--atime', dest='atime', action='store_true', help='do store atime into archive') fs_group.add_argument('--noctime', dest='noctime', action='store_true', From 1196d14f454c4e9d773a3573c1adb374f6131197 Mon Sep 17 00:00:00 2001 From: Thomas Waldmann Date: Sat, 2 Jul 2022 22:00:13 +0200 Subject: [PATCH 2/5] remove deprecated --nobsdflags --nobsdflags is deprecated since 1.2. there is --flags for the same purpose. --- src/borg/archiver.py | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/borg/archiver.py b/src/borg/archiver.py index 59ca92803..1df96489f 100644 --- a/src/borg/archiver.py +++ b/src/borg/archiver.py @@ -941,7 +941,7 @@ class Archiver: self.output_filter = args.output_filter self.output_list = args.output_list - self.noflags = args.nobsdflags or args.noflags + self.noflags = args.noflags self.noacls = args.noacls self.noxattrs = args.noxattrs self.exclude_nodump = args.exclude_nodump @@ -960,7 +960,7 @@ class Archiver: chunker_params=args.chunker_params, start=t0, start_monotonic=t0_monotonic, log_json=args.log_json, iec=args.iec) metadata_collector = MetadataCollector(noatime=not args.atime, noctime=args.noctime, - noflags=args.nobsdflags or args.noflags, noacls=args.noacls, noxattrs=args.noxattrs, + noflags=args.noflags, noacls=args.noacls, noxattrs=args.noxattrs, numeric_ids=args.numeric_ids, nobirthtime=args.nobirthtime) cp = ChunksProcessor(cache=cache, key=key, add_item=archive.add_item, write_checkpoint=archive.write_checkpoint, @@ -2833,7 +2833,6 @@ class Archiver: def preprocess_args(self, args): deprecations = [ # ('--old', '--new' or None, 'Warning: "--old" has been deprecated. Use "--new" instead.'), - ('--nobsdflags', None, 'Warning: "--nobsdflags" has been deprecated. Use --noflags instead.'), ('--numeric-owner', None, 'Warning: "--numeric-owner" has been deprecated. Use --numeric-ids instead.'), ('--remote-ratelimit', None, 'Warning: "--remote-ratelimit" has been deprecated. Use --upload-ratelimit instead.'), ('--remote-buffer', None, 'Warning: "--remote-buffer" has been deprecated. Use --upload-buffer instead.'), @@ -3712,8 +3711,6 @@ class Archiver: help='do not store ctime into archive') fs_group.add_argument('--nobirthtime', dest='nobirthtime', action='store_true', help='do not store birthtime (creation date) into archive') - fs_group.add_argument('--nobsdflags', dest='nobsdflags', action='store_true', - help='deprecated, use ``--noflags`` instead') fs_group.add_argument('--noflags', dest='noflags', action='store_true', help='do not read and store flags (e.g. NODUMP, IMMUTABLE) into archive') fs_group.add_argument('--noacls', dest='noacls', action='store_true', @@ -4193,8 +4190,6 @@ class Archiver: help='deprecated, use ``--numeric-ids`` instead') subparser.add_argument('--numeric-ids', dest='numeric_ids', action='store_true', help='only obey numeric user and group identifiers') - subparser.add_argument('--nobsdflags', dest='nobsdflags', action='store_true', - help='deprecated, use ``--noflags`` instead') subparser.add_argument('--noflags', dest='noflags', action='store_true', help='do not extract/set flags (e.g. NODUMP, IMMUTABLE)') subparser.add_argument('--noacls', dest='noacls', action='store_true', From 79696429b4861cfa08ad2c300209ba43196914a7 Mon Sep 17 00:00:00 2001 From: Thomas Waldmann Date: Sat, 2 Jul 2022 22:05:47 +0200 Subject: [PATCH 3/5] remove deprecated --numeric-owner --numeric-owner is deprecated since 1.2. there is --numeric-ids for the same purpose. --- src/borg/archiver.py | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/borg/archiver.py b/src/borg/archiver.py index 1df96489f..2b4801b3c 100644 --- a/src/borg/archiver.py +++ b/src/borg/archiver.py @@ -2833,7 +2833,6 @@ class Archiver: def preprocess_args(self, args): deprecations = [ # ('--old', '--new' or None, 'Warning: "--old" has been deprecated. Use "--new" instead.'), - ('--numeric-owner', None, 'Warning: "--numeric-owner" has been deprecated. Use --numeric-ids instead.'), ('--remote-ratelimit', None, 'Warning: "--remote-ratelimit" has been deprecated. Use --upload-ratelimit instead.'), ('--remote-buffer', None, 'Warning: "--remote-buffer" has been deprecated. Use --upload-buffer instead.'), ] @@ -3126,8 +3125,6 @@ class Archiver: help='stay in foreground, do not daemonize') parser.add_argument('-o', dest='options', type=str, action=Highlander, help='Extra mount options') - parser.add_argument('--numeric-owner', dest='numeric_ids', action='store_true', - help='deprecated, use ``--numeric-ids`` instead') parser.add_argument('--numeric-ids', dest='numeric_ids', action='store_true', help='use numeric user and group identifiers from archive(s)') define_archive_filters_group(parser) @@ -3701,8 +3698,6 @@ class Archiver: fs_group = subparser.add_argument_group('Filesystem options') fs_group.add_argument('-x', '--one-file-system', dest='one_file_system', action='store_true', help='stay in the same file system and do not store mount points of other file systems. This might behave different from your expectations, see the docs.') - fs_group.add_argument('--numeric-owner', dest='numeric_ids', action='store_true', - help='deprecated, use ``--numeric-ids`` instead') fs_group.add_argument('--numeric-ids', dest='numeric_ids', action='store_true', help='only store numeric user and group identifiers') fs_group.add_argument('--atime', dest='atime', action='store_true', @@ -4066,8 +4061,6 @@ class Archiver: formatter_class=argparse.RawDescriptionHelpFormatter, help='find differences in archive contents') subparser.set_defaults(func=self.do_diff) - subparser.add_argument('--numeric-owner', dest='numeric_ids', action='store_true', - help='deprecated, use ``--numeric-ids`` instead') subparser.add_argument('--numeric-ids', dest='numeric_ids', action='store_true', help='only consider numeric user and group identifiers') subparser.add_argument('--same-chunker-params', dest='same_chunker_params', action='store_true', @@ -4186,8 +4179,6 @@ class Archiver: help='output verbose list of items (files, dirs, ...)') subparser.add_argument('-n', '--dry-run', dest='dry_run', action='store_true', help='do not actually change any files') - subparser.add_argument('--numeric-owner', dest='numeric_ids', action='store_true', - help='deprecated, use ``--numeric-ids`` instead') subparser.add_argument('--numeric-ids', dest='numeric_ids', action='store_true', help='only obey numeric user and group identifiers') subparser.add_argument('--noflags', dest='noflags', action='store_true', From 1b88eb67e09870ae8043b42a9e6c5c0a62352fc2 Mon Sep 17 00:00:00 2001 From: Thomas Waldmann Date: Sat, 2 Jul 2022 22:08:19 +0200 Subject: [PATCH 4/5] remove deprecated --remote-ratelimit --remote-ratelimit is deprecated since 1.2. there is --upload-ratelimit for the same purpose. --- src/borg/archiver.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/borg/archiver.py b/src/borg/archiver.py index 2b4801b3c..13801300f 100644 --- a/src/borg/archiver.py +++ b/src/borg/archiver.py @@ -2833,7 +2833,6 @@ class Archiver: def preprocess_args(self, args): deprecations = [ # ('--old', '--new' or None, 'Warning: "--old" has been deprecated. Use "--new" instead.'), - ('--remote-ratelimit', None, 'Warning: "--remote-ratelimit" has been deprecated. Use --upload-ratelimit instead.'), ('--remote-buffer', None, 'Warning: "--remote-buffer" has been deprecated. Use --upload-buffer instead.'), ] for i, arg in enumerate(args[:]): @@ -3036,8 +3035,6 @@ class Archiver: help='set umask to M (local only, default: %(default)04o)') add_common_option('--remote-path', metavar='PATH', dest='remote_path', help='use PATH as borg executable on the remote (default: "borg")') - add_common_option('--remote-ratelimit', metavar='RATE', dest='upload_ratelimit', type=int, - help='deprecated, use ``--upload-ratelimit`` instead') add_common_option('--upload-ratelimit', metavar='RATE', dest='upload_ratelimit', type=int, help='set network upload rate limit in kiByte/s (default: 0=unlimited)') add_common_option('--remote-buffer', metavar='UPLOAD_BUFFER', dest='upload_buffer', type=int, From 0dac106812785abcb6688cbda6e48a915c8adeb1 Mon Sep 17 00:00:00 2001 From: Thomas Waldmann Date: Sat, 2 Jul 2022 22:09:55 +0200 Subject: [PATCH 5/5] remove deprecated --remote-buffer --remote-buffer is deprecated since 1.2. there is --upload-buffer for the same purpose. --- src/borg/archiver.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/borg/archiver.py b/src/borg/archiver.py index 13801300f..17cf970ca 100644 --- a/src/borg/archiver.py +++ b/src/borg/archiver.py @@ -2833,7 +2833,6 @@ class Archiver: def preprocess_args(self, args): deprecations = [ # ('--old', '--new' or None, 'Warning: "--old" has been deprecated. Use "--new" instead.'), - ('--remote-buffer', None, 'Warning: "--remote-buffer" has been deprecated. Use --upload-buffer instead.'), ] for i, arg in enumerate(args[:]): for old_name, new_name, warning in deprecations: @@ -3037,8 +3036,6 @@ class Archiver: help='use PATH as borg executable on the remote (default: "borg")') add_common_option('--upload-ratelimit', metavar='RATE', dest='upload_ratelimit', type=int, help='set network upload rate limit in kiByte/s (default: 0=unlimited)') - add_common_option('--remote-buffer', metavar='UPLOAD_BUFFER', dest='upload_buffer', type=int, - help='deprecated, use ``--upload-buffer`` instead') add_common_option('--upload-buffer', metavar='UPLOAD_BUFFER', dest='upload_buffer', type=int, help='set network upload buffer size in MiB. (default: 0=no buffer)') add_common_option('--consider-part-files', dest='consider_part_files', action='store_true',