2019-12-09 15:50:20 -05:00
|
|
|
from setuptools import find_packages
|
|
|
|
|
from setuptools import setup
|
2015-07-10 12:34:08 -04:00
|
|
|
|
2021-12-07 17:03:51 -05:00
|
|
|
version = '1.23.0.dev0'
|
2015-09-26 18:27:04 -04:00
|
|
|
|
2015-07-10 12:34:08 -04:00
|
|
|
install_requires = [
|
2021-06-01 17:46:06 -04:00
|
|
|
# We specify the minimum acme and certbot version as the current plugin
|
|
|
|
|
# version for simplicity. See
|
|
|
|
|
# https://github.com/certbot/certbot/issues/8761 for more info.
|
|
|
|
|
f'acme>={version}',
|
|
|
|
|
f'certbot>={version}',
|
2017-05-11 13:06:05 -04:00
|
|
|
'python-augeas',
|
Switch oldest tests to Python 3 (#8590)
Fixes https://github.com/certbot/certbot/issues/8580.
With this PR, it should now be possible to run the oldest tests natively on Linux, at least when using an older version of Python 3, which hasn't been possible in a long time. Unfortunately, this isn't possible on macOS which I opened https://github.com/certbot/certbot/issues/8589 to track.
You can see the full test suite running with these changes at https://dev.azure.com/certbot/certbot/_build/results?buildId=3283&view=results.
I took the version numbers for the packages I updated by searching for the oldest version of the dependency I think we should try and support based on the updated comments at the top of `oldest_constraints.txt`. While kind of annoying, I think it'd be a good idea for the reviewer to double check that I didn't make a mistake with the versions I used here.
To find these versions, I used https://packages.ubuntu.com, https://packages.debian.org, and a CentOS 7 Docker image with EPEL 7 installed. For the latter, not all packages are available in Python 3 yet (which is something Certbot's EPEL package maintainers are working on) and in that case I didn't worry about the system because I think they can/will package the newest version available. If they end up hitting any issues here when trying to package Certbot on Python 3, we can always work with them to fix it.
* remove py27 from oldest name
* update min cryptography version
* remove run_oldest_tests.sh
* upgrade setuptools and pyopenssl
* update cffi, pyparsing, and idna
* expand oldest_constraints comments
* clarify oldest comment
* update min configobj version
* update min parsedatetime version
* quote tox env name
* use Python 3.6 in the oldest tests
* use Python 3.6 for oldest integration tests
* properly pin asn1crypto
* update min six version
* set basepython for a nicer error message
* remove outdated python 2 oldest constraints
2021-01-25 15:59:14 -05:00
|
|
|
'setuptools>=39.0.1',
|
2015-07-10 12:34:08 -04:00
|
|
|
]
|
2020-04-15 14:30:08 -04:00
|
|
|
|
2020-01-07 12:57:43 -05:00
|
|
|
dev_extras = [
|
2020-03-23 20:05:22 -04:00
|
|
|
'apacheconfig>=0.3.2',
|
2020-01-07 12:57:43 -05:00
|
|
|
]
|
Fix test sdists with atexit handlers (#6769)
So merging the study from @bmw and me, here is what happened.
Each invocation of `certbot.logger.post_arg_parse_setup` create a file handler on `letsencrypt.log`. This function also set an atexit handler invoking `logger.shutdown()`, that have the effect to close all logger file handler not already closed at this point. This method is supposed to be called when a python process is close to exit, because it makes all logger unable to write new logs on any handler.
Before #6667 and this PR, for tests, the atexit handle would be triggered only at the end of the pytest process. It means that each test that launches `certbot.logger.post_arg_parse_setup` add a new file handler. These tests were typically connecting the file handler on a `letsencrypt.log` located in a temporary directory, and this directory and content was wipped out at each test tearDown. As a consequence, the file handles, not cleared from the logger, were accumulating in the logger, with all of them connected to a deleted file log, except the last one that was just created by the current test. Considering the number of tests concerned, there were ~300 file handler at the end of pytest execution.
One can see that, on prior #6667, by calling `print(logger.getLogger().handlers` on the `tearDown` of these tests, and see the array growing at each test execution.
Even if this represent a memory leak, this situation was not really a problem on Linux: because a file can be deleted before it is closed, it was only meaning that a given invocation of `logger.debug` for instance, during the tests, was written in 300 log files. The overhead is negligeable. On Windows however, the file handlers were failing because you cannot delete a file before it is closed.
It was one of the reason for #6667, that added a call to `logging.shutdown()` at each test tearDown, with the consequence to close all file handlers. At this point, Linux is not happy anymore. Any call to `logger.warn` will generate an error for each closed file handler. As a file handler is added for each test, the number of errors grows on each test, following an arithmetical suite divergence.
On `test_sdists.py`, that is using the bare setuptools test suite without output capturing, we can see the damages. The total output takes 216000 lines, and 23000 errors are generated. A decent machine can support this load, but a not a small AWS instance, that is crashing during the execution. Even with pytest, the captured output and the memory leak become so large that segfaults are generated.
On the current PR, the problem is solved, by resetting the file handlers array on the logging system on each test tearDown. So each fileHandler is properly closed, and removed from the stack. They do not participate anymore in the logging system, and can be garbage collected. Then we stay on always one file handler opened at any time, and tests can succeed on AWS instances.
For the record, here is all the places where the logging system is called and fail if there is still file handlers closed but not cleaned (extracted from the original huge output before correction):
```
Logged from file account.py, line 116
Logged from file account.py, line 178
Logged from file client.py, line 166
Logged from file client.py, line 295
Logged from file client.py, line 415
Logged from file client.py, line 422
Logged from file client.py, line 480
Logged from file client.py, line 503
Logged from file client.py, line 540
Logged from file client.py, line 601
Logged from file client.py, line 622
Logged from file client.py, line 750
Logged from file cli.py, line 220
Logged from file cli.py, line 226
Logged from file crypto_util.py, line 101
Logged from file crypto_util.py, line 127
Logged from file crypto_util.py, line 147
Logged from file crypto_util.py, line 261
Logged from file crypto_util.py, line 283
Logged from file crypto_util.py, line 307
Logged from file crypto_util.py, line 336
Logged from file disco.py, line 116
Logged from file disco.py, line 124
Logged from file disco.py, line 134
Logged from file disco.py, line 138
Logged from file disco.py, line 141
Logged from file dns_common_lexicon.py, line 45
Logged from file dns_common_lexicon.py, line 61
Logged from file dns_common_lexicon.py, line 67
Logged from file dns_common.py, line 316
Logged from file dns_common.py, line 64
Logged from file eff.py, line 60
Logged from file eff.py, line 73
Logged from file error_handler.py, line 105
Logged from file error_handler.py, line 110
Logged from file error_handler.py, line 87
Logged from file hooks.py, line 248
Logged from file main.py, line 1071
Logged from file main.py, line 1075
Logged from file main.py, line 1189
Logged from file ops.py, line 122
Logged from file ops.py, line 325
Logged from file ops.py, line 338
Logged from file reporter.py, line 55
Logged from file selection.py, line 110
Logged from file selection.py, line 118
Logged from file selection.py, line 123
Logged from file selection.py, line 176
Logged from file selection.py, line 231
Logged from file selection.py, line 310
Logged from file selection.py, line 66
Logged from file standalone.py, line 101
Logged from file standalone.py, line 88
Logged from file standalone.py, line 97
Logged from file standalone.py, line 98
Logged from file storage.py, line 52
Logged from file storage.py, line 59
Logged from file storage.py, line 75
Logged from file util.py, line 56
Logged from file webroot.py, line 165
Logged from file webroot.py, line 186
Logged from file webroot.py, line 187
Logged from file webroot.py, line 204
Logged from file webroot.py, line 223
Logged from file webroot.py, line 234
Logged from file webroot.py, line 235
Logged from file webroot.py, line 237
Logged from file webroot.py, line 91
```
* Reapply #6667
* Make setuptools delegates tests execution to pytest, like in acme module.
* Clean handlers at each tearDown to avoid memory leaks.
* Update changelog
2019-02-21 19:55:08 -05:00
|
|
|
|
2015-07-10 12:34:08 -04:00
|
|
|
setup(
|
2016-04-13 19:30:57 -04:00
|
|
|
name='certbot-apache',
|
2015-09-26 18:27:04 -04:00
|
|
|
version=version,
|
2016-04-13 19:36:53 -04:00
|
|
|
description="Apache plugin for Certbot",
|
2015-09-26 18:49:46 -04:00
|
|
|
url='https://github.com/letsencrypt/letsencrypt',
|
2016-04-14 19:56:02 -04:00
|
|
|
author="Certbot Project",
|
2021-05-03 15:38:54 -04:00
|
|
|
author_email='certbot-dev@eff.org',
|
2015-09-26 18:37:50 -04:00
|
|
|
license='Apache License 2.0',
|
2021-01-25 18:07:43 -05:00
|
|
|
python_requires='>=3.6',
|
2015-09-26 19:00:25 -04:00
|
|
|
classifiers=[
|
2018-07-10 16:52:58 -04:00
|
|
|
'Development Status :: 5 - Production/Stable',
|
2015-09-26 19:00:25 -04:00
|
|
|
'Environment :: Plugins',
|
|
|
|
|
'Intended Audience :: System Administrators',
|
|
|
|
|
'License :: OSI Approved :: Apache Software License',
|
|
|
|
|
'Operating System :: POSIX :: Linux',
|
|
|
|
|
'Programming Language :: Python',
|
2017-04-28 19:06:45 -04:00
|
|
|
'Programming Language :: Python :: 3',
|
|
|
|
|
'Programming Language :: Python :: 3.6',
|
2018-07-09 12:17:03 -04:00
|
|
|
'Programming Language :: Python :: 3.7',
|
2019-09-24 14:38:38 -04:00
|
|
|
'Programming Language :: Python :: 3.8',
|
2020-11-19 15:48:36 -05:00
|
|
|
'Programming Language :: Python :: 3.9',
|
2021-11-08 18:55:32 -05:00
|
|
|
'Programming Language :: Python :: 3.10',
|
2015-09-26 19:00:25 -04:00
|
|
|
'Topic :: Internet :: WWW/HTTP',
|
|
|
|
|
'Topic :: Security',
|
|
|
|
|
'Topic :: System :: Installation/Setup',
|
|
|
|
|
'Topic :: System :: Networking',
|
|
|
|
|
'Topic :: System :: Systems Administration',
|
|
|
|
|
'Topic :: Utilities',
|
|
|
|
|
],
|
2015-09-26 18:49:46 -04:00
|
|
|
|
2015-07-10 12:34:08 -04:00
|
|
|
packages=find_packages(),
|
2015-09-27 04:10:39 -04:00
|
|
|
include_package_data=True,
|
2015-07-10 12:34:08 -04:00
|
|
|
install_requires=install_requires,
|
2020-01-07 12:57:43 -05:00
|
|
|
extras_require={
|
|
|
|
|
'dev': dev_extras,
|
|
|
|
|
},
|
2015-07-10 12:34:08 -04:00
|
|
|
entry_points={
|
2016-04-13 19:30:57 -04:00
|
|
|
'certbot.plugins': [
|
2019-11-25 12:44:40 -05:00
|
|
|
'apache = certbot_apache._internal.entrypoint:ENTRYPOINT',
|
2015-09-06 05:20:41 -04:00
|
|
|
],
|
2015-07-10 12:34:08 -04:00
|
|
|
},
|
|
|
|
|
)
|
