Adrien Ferrand
fc7e5e8e60
Remove useless pylint error suppression directives ( #7657 )
...
As pylint is evolving, it improves its accuracy, and several pylint error suppression (`# pylint: disable=ERROR) added in certbot codebase months or years ago are not needed anymore to make it happy.
There is a (disabled by default) pylint error to detect the useless suppressions (pylint-ception: `useless-suppression`). It is not working perfectly (it has also false-positives ...) but it is a good start to clean the codebase.
This PR removes several of these useless suppressions as detected by the current pylint version we use.
* Remove useless suppress
* Remove useless lines
2020-02-13 13:56:16 -08:00
Joona Hoikkala
0f5bda4ff9
Merge remote-tracking branch 'origin/master' into ap2_merge_master
2020-01-06 17:17:31 +02:00
Adrien Ferrand
e048da1e38
Reorganize imports ( #7616 )
...
* Isort execution
* Fix pylint, adapt coverage
* New isort
* Fix magic_typing lint
* Second round
* Fix pylint
* Third round. Store isort configuration
* Fix latest mistakes
* Other fixes
* Add newline
* Fix lint errors
2019-12-09 15:50:20 -05:00
ohemorange
8139689d4c
Make the contents of the apache plugin private ( #7579 )
...
Part of #5775 .
Tree:
```
certbot-apache/certbot_apache
├── __init__.py
├── _internal
│ ├── apache_util.py
│ ├── augeas_lens
│ │ ├── httpd.aug
│ │ └── README
│ ├── centos-options-ssl-apache.conf
│ ├── configurator.py
│ ├── constants.py
│ ├── display_ops.py
│ ├── entrypoint.py
│ ├── http_01.py
│ ├── __init__.py
│ ├── obj.py
│ ├── options-ssl-apache.conf
│ ├── override_arch.py
│ ├── override_centos.py
│ ├── override_darwin.py
│ ├── override_debian.py
│ ├── override_fedora.py
│ ├── override_gentoo.py
│ ├── override_suse.py
│ └── parser.py
└── tests
├── ...
```
* Create _internal folder for certbot_apache
* Move apache_util.py to _internal
* Move display_ops.py to _internal
* Move override_centos.py to _internal
* Move override_gentoo.py to _internal
* Move override_darwin.py to _internal
* Move override_suse.py to _internal
* Move override_debian.py to _internal
* Move override_fedora.py to _internal
* Move override_arch.py to _internal
* Move parser.py to _internal
* Move obj.py to _internal
* Move http_01.py to _internal
* Move entrypoint.py to _internal
* Move constants.py to _internal
* Move configurator.py to _internal
* Move augeas_lens to _internal
* Move options-ssl-apache.conf files to _internal
* move augeas_lens in MANIFEST
* Clean up some stray references to certbot_apache that could use _internal
* Correct imports and lint
2019-11-25 09:44:40 -08:00
