Commit graph

10392 commits

Author SHA1 Message Date
Noah Swartz
28495b1336 fixed up the changelog 2017-04-11 16:57:42 -07:00
Noah Swartz
07273e5d7e Merge pull request #4432 from certbot/contributing-common
Document tests/integration/_common.sh.
2017-04-10 19:15:18 -07:00
Alex Jordan
dfd4d0c10e Document hook error handling (#4418)
* Document hook error handling

* Clarify wording around hook failure exit codes
2017-04-07 10:16:59 -07:00
Jacob Hoffman-Andrews
a08e9599f5 Review feedback. 2017-04-07 10:15:52 -07:00
Yen Chi Hsuan
4b91f7fbbc Replace e.message with str(e) for Python 3 compatibility (#4416) 2017-04-07 09:58:19 -07:00
Jacob Hoffman-Andrews
d557c39c99 Remove obsolete fields from Registration. (#4339)
Authorizations and certificates were in the original spec but have since been
deleted.
2017-04-07 09:52:12 -07:00
Ngo The Trung
315b6d0cf1 Fix unorderable types error (#4409)
If the updated datetime collides, the comparator of heapq will move
onto the AuthorizationResource value and throws an "unorderable type"
error.

This adds an index value to the element tuple to ensure that they are
always strictly ordered.
2017-04-07 09:46:27 -07:00
Jacob Hoffman-Andrews
cacee80c51 Move make_csr into acme.crypto_util (#4165)
It's relatively finicky to make a CSR appropriate to pass to poll_and_request_issuance. I think most users want to be able to give a list of domains and a private key, and get back a CSR. This branch adds that functionality to crypto_util.

Note that the two new functions take arguments, and return values, as PEM-encoded buffers. This is a departure from some existing ACME interfaces that take PyOpenSSL types. I've discussed with the Certbot team, and we agree that this is broadly the direction the ACME API should take, so that users of the module don't need to import PyOpenSSL themselves, or use its primitives.

* Add make_csr.

* accept privkey

* Tweak API.

* Remove make_csr from certbot package.

* Skip test in older Pythons.

* Move get_Extensions call under protection.

* Remove assertIn because not backwards-compatible.

* Fix encoding, and use PEM.

* Fix test

* Fix tests on py35.

* Fix error in test.

* Make import_csr_file always return PEM.

Also delete get_sans_from_csr (unused) and get_names_from_csr (newly unused).

* Fix function doc.

* Fix indent

* Fix call of obtain_certificate_from_Csr

* lint

* Handle review feedback.

* Fix test.
2017-04-07 09:43:33 -07:00
Brad Warren
2e8a5ef477 Call certbot client cb_client rather than acme_client (#4357)
In some sense, certbot.client.Client is an ACME client, but it's the not the client in the ACME library and this leads to confusion. Let's make what this is clear.

* call certbot client cb_client rather than acme_client

* update tests
2017-04-06 16:05:54 -07:00
Peter Eckersley
c35ca9775b tweak comment 2017-04-06 14:41:40 -07:00
Erica Portnoy
da1cfa85fc Update changelog for 0.13.0 release (#4476) 2017-04-06 12:07:17 -07:00
Erica Portnoy
82f3f7523e Candidate 0.13.0 (#4475)
* Release 0.13.0

* Bump version to 0.14.0
2017-04-06 11:33:32 -07:00
Zero King
5259901d04 Fix link in README.rst 2017-04-06 11:02:00 +00:00
Peter Eckersley
23a2ecb36e Fixup 2017-04-05 15:28:14 -07:00
Erica Portnoy
18486d6ea0 Revert "More thoroughly rename during certbot rename. (#4320)" (#4467)
This reverts commit 43dccfc671.
2017-04-05 12:45:03 -07:00
Peter Eckersley
2f0ec5c388 Set renewing: correctly for the "renew" case. 2017-04-05 12:40:26 -07:00
Noah Swartz
664c9aaae5 Merge pull request #4419 from strugee/improve-changelog
Start organizing the change log
2017-04-05 12:31:46 -07:00
Peter Eckersley
b614fe8491 Merge remote-tracking branch 'origin/master' into more-ua 2017-04-05 11:58:03 -07:00
Peter Eckersley
572b9fe5be Merge remote-tracking branch 'origin/master' into more-ua 2017-04-05 11:57:51 -07:00
Peter Eckersley
a313eebc7f Conform to RFC 1945 2017-04-05 11:54:23 -07:00
Paulo Köch
ab0d5f830d Update README.md 2017-04-05 11:05:01 +01:00
Paulo Köch
d2a81b1f16 Merge pull request #4 from lifeonmarspt/pkoch_cleanup
Cleanup installation
2017-04-05 11:02:37 +01:00
Paulo Koch
08932836f3 Add my janky tester 2017-04-05 11:02:01 +01:00
Paulo Koch
1b65e17999 Tidy up installation 2017-04-05 11:02:01 +01:00
Peter Eckersley
2bdfffb23a Support "certbot-auto --no-bootstrap" (#3955)
* Support "certbot-auto --no-bootstrap"

* Tell people about --no-bootstrap?

* Document new certbot-auto flag in its cli help

* Rebuild

* Less variables is less variability

* Alphabetize help

* Make it extra clear we only take one branch

* Add --no-bootstrap message to experimentalbootstrap exit
2017-04-04 16:12:31 -07:00
Alex Jordan
2887b888f7
Start organizing the change log
This style is based on http://keepachangelog.com/en/0.3.0/.
2017-04-04 15:54:39 -04:00
Erica Portnoy
43dccfc671 More thoroughly rename during certbot rename. (#4320)
* rename more files in rename command

* Revert "Hide rename command (#4007)"

This reverts commit 8c14de13a5.

* Rename files in configuration files

* Delete new files if we fail during the renaming process

* update tests and error catching

* More expressive error message
2017-04-04 11:20:58 -07:00
St-Ranger
035e5b93ea Futher improvement re: FreeBSD packages
Further improved the previous change to make it more clear.
2017-04-04 00:41:55 -05:00
Nathan Arthur
2b03833752 Add NetBSD to list of OSes with packages 2017-04-04 00:55:25 -04:00
Nathan Arthur
971439a518 Sort list of OSes with packages 2017-04-04 00:48:33 -04:00
St-Ranger
4c36d8081e Correct info fro FreeBSD
1. Replace the outdated reference to "vritualenv", "see below" -> "see above".
2. Replace the awkward sentence (partially incorrect) about installing on FreeBSD. 
It can be installed via different ways: "pkg" is not exclusive. I am not aware of any reason why it canNOT be installed from ports. Some people prefer build and install everything from ports. (The previous version of the description implies that ports cannot be used.)
2017-04-03 23:45:48 -05:00
Robotic-Brain
345e77efcf Fixing Typo in README.rst (issues -> issued) 2017-04-04 00:42:33 +02:00
Robotic-Brain
b92b37d9fe Fixing Typo in Readme.rst 2017-04-04 00:35:11 +02:00
Zach Shepherd
22248c1393 docs: fix syntax error in plugin installation example
Partially addresses issue #4368.
2017-04-03 14:58:25 -07:00
Zach Shepherd
af5fd4f6bd docs: use monospace syntax for method name 2017-04-03 14:55:27 -07:00
Zach Shepherd
3f625d3a0d docs: clarify the use of entry points for plugins
The documentation did not list the entry point group, certbot.plugins.

Partially addresses issue #4368.
2017-04-03 14:51:48 -07:00
Zach Shepherd
c1cb762b32 docs: clarify when venv needs to be re-setup
When dependencies change or a new plugin is introduced, the venv needs
to be re-created.

Partially addresses issue #4368.
2017-04-03 14:33:41 -07:00
Brad Warren
e194e0dd5f Refactoring for better logging (#4444)
* Move colored_logging.py to log.py

* Add atexit.register code to util

* Add tests for atexit_register

* Copy except_hook to log

* Add pre_arg_setup

* move setup_log_file_handler to log.py

* Add post_arg_setup

* move changes to main

* Undo changes to MainTest

* s/pre_arg_setup/pre_arg_parse_setup

* s/post_arg_setup/post_arg_parse_setup
2017-03-30 16:17:57 -07:00
Brad Warren
a542fcd019 Revert "Add a global lock file to Certbot (#4369)" (#4445)
This reverts commit 32122cfa21.
2017-03-30 15:47:31 -07:00
Erica Portnoy
d09bde972a Remove unused default parameter (#4447)
* Remove unnecessary, nonexistent default
2017-03-30 15:28:24 -07:00
Erica Portnoy
52e22b22e5 Add additional Nginx parsing test case (#4440) 2017-03-30 07:47:36 -07:00
Noah Swartz
81fb598235 Merge pull request #4373 from osirisinferi/docs-add-gentoo-packages
Add Gentoo to list of official packages
2017-03-29 18:00:51 -07:00
Noah Swartz
64f2d0d911 Merge pull request #4427 from certbot/no-domains-in-cli-ini
No domains in cli.ini
2017-03-29 17:58:20 -07:00
Noah Swartz
ca16dfb593 Merge branch 'master' into docs-add-gentoo-packages 2017-03-29 17:42:23 -07:00
Jacob Hoffman-Andrews
d5f1edf2bb Dump Boulder logs on integration test failures. (#4442)
Might help debug #4363.

Also:

make "bash" vs "sh" explicit
move the paranoia flags (-ex) from the shebang into the body
add -u (fail on unset variables)
change _common to work with -u
remove some env vars that were no longer used
remove shebang from _common.sh because it's meant to be sourced, not run
2017-03-29 16:48:08 -07:00
Jacob Hoffman-Andrews
e73c29374a Change to source. 2017-03-29 14:32:02 -07:00
Yen Chi Hsuan
6fb78dab67 Fix Docker IP detection with different ifconfig output formats (#4376) 2017-03-29 13:34:09 -07:00
Zach Shepherd
67e11ae1d8 tests: deduplicate temporary directory code (#4078) (#4297)
Introduce a test class to deduplicate temporary directory setup and teardown in
testing code and update existing test code to use this new class.
2017-03-29 10:01:16 -07:00
Jacob Hoffman-Andrews
db0a4f9039 Document tests/integration/_common.sh.
This makes it much easier to run certbot during development.
2017-03-28 16:15:09 -07:00
Noah Swartz
446509620f Merge pull request #4420 from certbot/issue4331
Ensure --fullchain-path gets put under paths in --help all
2017-03-28 14:08:56 -07:00