mirror of
https://github.com/certbot/certbot.git
synced 2026-03-29 22:04:43 -04:00
2ddaf3db04
In response to #6594. [Fixes #6594.] To execute OCSP requests, certbot relies currently on a openssl binary execution. If openssl is not present in the PATH, the OCSP check will be silently ignored. Since version 2.4, cryptography has support for OCSP requests, without the need to have openssl binary available locally. This PR takes advantage of it, and will use the built-in support of OCSP in cryptography for versions >= 2.4. Otherwise, fallback is done do a direct call to openssl binary, allowing oldest requirements to still work with legacy cryptography versions. Update: requirement is now cryptography >= 2.5, to avoid to rely on a private method from cryptography. * Implement logic using cryptography * Working OSCP using pure cryptography * Fix openssl usage in unit tests * Reduce verbosity * Add tests * Improve naive skipIf * Test resiliency * Update ocsp.py * Validate OCSP response. Unify OCSP URL get * Improve resiliency checks, correct lint/mypy * Improve hash selection * Fix warnings when calling openssl bin * Load OCSP tests assets as vectors. * Update ocsp.py * Protect against invalid ocsp response. * Add checks to OCSP response * Add more control on ocsp response * Be lenient about assertion that next_update must be in the future, similarly to openssl. * Construct a more advanced OCSP response mock to trigger more logic in ocsp module. * Add test * Refactor signature process to use crypto_util * Fallback for cryptography 2.4 * Avoid a collision with a meteor. * Correct method signature documentation * Relax OCSP update interval * Trigger built-in ocsp logic from cryptography with 2.5+ * Update pinned version of cryptography * Update certbot/ocsp.py Co-Authored-By: adferrand <adferrand@users.noreply.github.com> * Update ocsp.py * Update ocsp_test.py * Update CHANGELOG.md * Update CHANGELOG.md |
||
|---|---|---|
| .. | ||
| pieces | ||
| tests | ||
| build.py | ||
| certbot-auto.asc | ||
| Dockerfile.centos6 | ||
| Dockerfile.jessie | ||
| Dockerfile.trusty | ||
| Dockerfile.xenial | ||
| letsencrypt-auto | ||
| letsencrypt-auto.sig | ||
| letsencrypt-auto.template | ||
| version.py | ||