mirror of
https://github.com/certbot/certbot.git
synced 2026-03-29 22:04:43 -04:00
84178e2773
We observed recently several unexpected behavior during the execution of snap jobs in Azure. In particular it seems that `snapcraft remote-build` is tending to reattach to the latest builds on Launchpad triggered by the nightly builds on master, independently from the actual branch, status of the code, or targeted architectures. Primarily if the builds on Launchpad are stalled for some reason, it blocks effectively any other Azure snap jobs until someone manually cancel the builds on Launchpad. Secondarily it means that the outcome of the builds may be inconsistent, because they can be the result of a build for the master source even if you are on a PR that modifieds these sources (including `snapcraft.yaml`). After digging in `snapcraft` source code, I realized that the signature computed to understand if a build should be resumed, is not based one some hashes against the snapcraft working directory content, but is simply a hash of the working directory absolute path *itself*. It means that every builds triggered from the working directory `/my/path/certbot` for instance, are recognized as the same unique build on Launchpad side, and may be resumed if they already exist, and so independently from the source code, `snapcraft.yaml` or targeted archs. For the record, relevant parts in `snapcraft` source code: |
||
|---|---|---|
| .. | ||
| docker | ||
| snap | ||
| _changelog_top.txt | ||
| _release.sh | ||
| certbot_constraints.txt | ||
| deactivate.py | ||
| dev_constraints.txt | ||
| eff-pubkey.pem | ||
| extract_changelog.py | ||
| finish_release.py | ||
| half-sign.c | ||
| install_and_test.py | ||
| merge_requirements.py | ||
| oldest_constraints.txt | ||
| pip_install.py | ||
| pip_install_editable.py | ||
| pipstrap.py | ||
| pipstrap_constraints.txt | ||
| readlink.py | ||
| rebuild_certbot_constraints.py | ||
| release.sh | ||
| retry.sh | ||
| simple_http_server.py | ||
| sphinx-quickstart.sh | ||
| strip_hashes.py | ||
| venv.py | ||