mirror of
https://github.com/certbot/certbot.git
synced 2026-02-25 10:50:38 -05:00
33090ab77a
#6636 broke [test-everything tests](https://travis-ci.org/certbot/certbot/builds/475173804) because `_common.sh` is a common file shared between Certbot and Nginx integration tests and `--no-random-sleep-on-renew` isn't defined for the version of Certbot used in the "oldest" integration tests. This PR adds code to `_common.sh` to check the Certbot version and if it's new enough, add `--no-random-sleep-on-renew` to the command line. I repurposed `$store_flags` and stopped exporting it because it's not used anywhere outside of this file. Other approaches I considered and decided against were: 1. Adding this flag in `certbot-boulder-integration.sh`. I decided against it because it's setting us up for the same problem in the future if the oldest version of Certbot is upgraded in the Nginx tests and we call `certbot renew`. 2. Just upgrading the oldest version of Certbot required by Nginx to avoid these issues. While this would work (with perhaps some unnecessary burden for our packagers), I think it's avoiding the real problem here which should now be able to addressed easily with the addition of `$other_flags` and `version_at_least`. * Add version_at_least(). * Conditionally disable sleep. * Consolidate store_flags and other_flags. * update comments |
||
|---|---|---|
| .. | ||
| integration | ||
| letstest | ||
| boulder-fetch.sh | ||
| boulder-integration.sh | ||
| certbot-boulder-integration.sh | ||
| certbot-pebble-integration.sh | ||
| display.py | ||
| lock_test.py | ||
| manual-dns-auth.sh | ||
| manual-dns-cleanup.sh | ||
| manual-http-auth.sh | ||
| manual-http-cleanup.sh | ||
| modification-check.py | ||
| pebble-fetch.sh | ||
| run_http_server.py | ||
| tox-boulder-integration.sh | ||