mirror of
https://github.com/certbot/certbot.git
synced 2026-03-01 12:50:24 -05:00
95557fa9b4
Fixes #6585. I wrote up three suggestions for fixing this at https://github.com/certbot/certbot/issues/6585#issuecomment-448054502. I took the middle approach of requiring the user to provide an ACME server to use. I like this better than the other approaches which were: > Resolve #5938 instead of this issue. There is value in these tests as is over the compatibility tests in that they don't use Docker and run on different OSes. > Spin up a local Python server to return the directory object. Trying to set up a dummy ACME server seemed hacky and error prone. Other notes about this PR are: * I put the Pebble setup in `tox.ini` rather than `.travis.yml` as this seems much cleaner and more natural. * I created a new `tox` environment called `apacheconftest-with-pebble` that reuses the code from `testenv:apacheconftest` so `apacheconftest` can continue to be used with servers other than Pebble like is done in our test farm tests. * I chose the environment variable `SERVER` for consistency with our integration tests. I chose to not give this environment variable a default but to fail fast when it is not set. * I ran test farm tests on this PR and they passed.
88 lines
2.4 KiB
Bash
Executable file
88 lines
2.4 KiB
Bash
Executable file
#!/bin/bash
|
|
|
|
# A hackish script to see if the client is behaving as expected
|
|
# with each of the "passing" conf files.
|
|
|
|
if [ -z "$SERVER" ]; then
|
|
echo "Please set SERVER to the ACME server's directory URL."
|
|
exit 1
|
|
fi
|
|
|
|
export EA=/etc/apache2/
|
|
TESTDIR="`dirname $0`"
|
|
cd $TESTDIR/passing
|
|
|
|
function CleanupExit() {
|
|
echo control c, exiting tests...
|
|
if [ "$f" != "" ] ; then
|
|
Cleanup
|
|
fi
|
|
exit 1
|
|
}
|
|
|
|
function Setup() {
|
|
if [ "$APPEND_APACHECONF" = "" ] ; then
|
|
sudo cp "$f" "$EA"/sites-available/
|
|
sudo ln -sf "$EA/sites-available/$f" "$EA/sites-enabled/$f"
|
|
echo "
|
|
<VirtualHost *:80>
|
|
ServerName example.com
|
|
DocumentRoot /tmp/
|
|
ErrorLog /tmp/error.log
|
|
CustomLog /tmp/requests.log combined
|
|
</VirtualHost>" | sudo tee $EA/sites-available/throwaway-example.conf >/dev/null
|
|
sudo ln -sf $EA/sites-available/throwaway-example.conf $EA/sites-enabled/throwaway-example.conf
|
|
else
|
|
TMP="/tmp/`basename \"$APPEND_APACHECONF\"`.$$"
|
|
sudo cp -a "$APPEND_APACHECONF" "$TMP"
|
|
sudo bash -c "cat \"$f\" >> \"$APPEND_APACHECONF\""
|
|
fi
|
|
}
|
|
|
|
function Cleanup() {
|
|
if [ "$APPEND_APACHECONF" = "" ] ; then
|
|
sudo rm /etc/apache2/sites-{enabled,available}/"$f"
|
|
sudo rm $EA/sites-available/throwaway-example.conf
|
|
sudo rm $EA/sites-enabled/throwaway-example.conf
|
|
else
|
|
sudo mv "$TMP" "$APPEND_APACHECONF"
|
|
fi
|
|
}
|
|
|
|
# if our environment asks us to enable modules, do our best!
|
|
if [ "$1" = --debian-modules ] ; then
|
|
sudo apt-get install -y apache2
|
|
sudo apt-get install -y libapache2-mod-wsgi
|
|
sudo apt-get install -y libapache2-mod-macro
|
|
|
|
for mod in ssl rewrite macro wsgi deflate userdir version mime setenvif ; do
|
|
echo -n enabling $mod
|
|
sudo a2enmod $mod
|
|
done
|
|
fi
|
|
|
|
CERTBOT_CMD="sudo $(command -v certbot) --server $SERVER -vvvv"
|
|
CERTBOT_CMD="$CERTBOT_CMD --debug --apache --register-unsafely-without-email"
|
|
CERTBOT_CMD="$CERTBOT_CMD --agree-tos certonly -t --no-verify-ssl"
|
|
|
|
FAILS=0
|
|
trap CleanupExit INT
|
|
for f in *.conf ; do
|
|
echo -n testing "$f"...
|
|
Setup
|
|
RESULT=`echo c | $CERTBOT_CMD 2>&1`
|
|
if echo $RESULT | grep -Eq \("Which names would you like"\|"mod_macro is not yet"\) ; then
|
|
echo passed
|
|
else
|
|
echo failed
|
|
echo $RESULT
|
|
echo
|
|
echo
|
|
FAILS=`expr $FAILS + 1`
|
|
fi
|
|
Cleanup
|
|
done
|
|
if [ "$FAILS" -ne 0 ] ; then
|
|
exit 1
|
|
fi
|
|
exit 0
|