limiting-factor 851356577c chore: do not leak global repository unit defaults (#11470) ... The [test disabling the issue unit][0] took care of [reseting the disabled units][1]. However, it overlooked that calling [`LoadUnitConfig`][2] also has a [side effect on `DefaultRepoUnits`][3]. It happens when [`validateDefaultRepoUnits` has a side effect][4] on the array backing the slice, when it is [not recreated][5]. As a result the issue unit is disabled for all tests that run after this one. The subtle side effect is harmless because it only happens in tests, the `LoadUnitConfig` is otherwise only called once. For clarity `LoadUnitConfig` is modified to clone the unit array being validated so that the returned slice is never backed by the same array as the argument. As the global variables used for repository units should be saved and restored as a whole, a dedicated test function (`SaveUnits`) is provided to be used by both integration tests and unit tests. The test of the unit model is refactored to be a blackbox test in order to avoid an import cycle. [0]: cce5f868ce/tests/integration/repo_settings_test.go (L258) [1]: cce5f868ce/tests/integration/repo_settings_test.go (L253) [2]: cce5f868ce/models/unit/unit.go (L171) [3]: cce5f868ce/models/unit/unit.go (L182) [4]: cce5f868ce/models/unit/unit.go (L162) [5]: cce5f868ce/models/unit/unit.go (L148) Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/11470 Reviewed-by: Ellen Εμιλία Άννα Zscheile <fogti@noreply.codeberg.org> Reviewed-by: Gusted <gusted@noreply.codeberg.org> Co-authored-by: limiting-factor <limiting-factor@posteo.com> Co-committed-by: limiting-factor <limiting-factor@posteo.com>		2026-03-07 02:03:22 +01:00
..
units.go	chore: do not leak global repository unit defaults (#11470)	2026-03-07 02:03:22 +01:00
units_test.go	chore: do not leak global repository unit defaults (#11470)	2026-03-07 02:03:22 +01:00