mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-03-25 09:03:04 -04:00
f7873ba393
Forgejo's UI claims that whitespace is removed from the beginning and the end of the values of Forgejo Actions variables and secrets. However, that is not correct. The entered values are stored as-is. Only CRLF is replaced with LF, which is also the desired behaviour. This PR changes the incorrect text which is also no longer displayed as placeholder but as a proper help text below the input fields. Furthermore, tests were added to verify the behaviour. While adding tests, I discovered and fixed another inconsistency. Depending on whether secrets were managed using the UI or the HTTP API, they were treated differently. CRLF in secrets entered in the UI was correctly replaced with LF while secrets created using the HTTP API kept CRLF. Fixes #11003. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/11052 Reviewed-by: Gusted <gusted@noreply.codeberg.org> Co-authored-by: Andreas Ahlenstorf <andreas@ahlenstorf.ch> Co-committed-by: Andreas Ahlenstorf <andreas@ahlenstorf.ch>
25 lines
731 B
Go
25 lines
731 B
Go
// Copyright 2023 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package structs
|
|
|
|
import "time"
|
|
|
|
// Secret represents a secret
|
|
// swagger:model
|
|
type Secret struct {
|
|
// the secret's name
|
|
Name string `json:"name"`
|
|
// swagger:strfmt date-time
|
|
Created time.Time `json:"created_at"`
|
|
}
|
|
|
|
// CreateOrUpdateSecretOption defines the properties of the secret to create or update.
|
|
// swagger:model
|
|
type CreateOrUpdateSecretOption struct {
|
|
// Data of the secret. Special characters will be retained. Line endings will be normalized to LF to match the
|
|
// behaviour of browsers. Encode the data with Base64 if line endings should be retained.
|
|
//
|
|
// required: true
|
|
Data string `json:"data" binding:"Required"`
|
|
}
|