mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-03-25 16:23:04 -04:00
Some checks are pending
/ release (push) Waiting to run
testing-integration / test-unit (push) Waiting to run
testing-integration / test-sqlite (push) Waiting to run
testing-integration / test-mariadb (v10.6) (push) Waiting to run
testing-integration / test-mariadb (v11.8) (push) Waiting to run
testing / backend-checks (push) Waiting to run
testing / frontend-checks (push) Waiting to run
testing / test-unit (push) Blocked by required conditions
testing / test-e2e (push) Blocked by required conditions
testing / test-remote-cacher (redis) (push) Blocked by required conditions
testing / test-remote-cacher (valkey) (push) Blocked by required conditions
testing / test-remote-cacher (garnet) (push) Blocked by required conditions
testing / test-remote-cacher (redict) (push) Blocked by required conditions
testing / test-mysql (push) Blocked by required conditions
testing / test-pgsql (push) Blocked by required conditions
testing / test-sqlite (push) Blocked by required conditions
testing / security-check (push) Blocked by required conditions
If, for any reason (e.g. server crash), a task is recorded as done in the database but the logs are still in the database instead of being in storage, they need to be collected. The log_in_storage field is only set to true after the logs have been transfered to storage and can be relied upon to reflect which tasks have lingering logs. A cron job collects lingering logs every day, 3000 at a time, sleeping one second between them. In normal circumstances there will be only a few of them, even on a large instance, and there is no need to collect them as quickly as possible. When there are a lot of them for some reason, garbage collection must happen at a rate that is not too hard on storage I/O. Refs https://codeberg.org/forgejo/forgejo/issues/9999 --- Note on backports: the v11 backport is done manually because of minor conflicts. https://codeberg.org/forgejo/forgejo/pulls/10024 ## Checklist The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org). ### Tests - I added test coverage for Go changes... - [x] in their respective `*_test.go` for unit tests. - [x] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I added test coverage for JavaScript changes... - [ ] in `web_src/js/*.test.js` if it can be unit tested. - [ ] in `tests/e2e/*.test.e2e.js` if it requires interactions with a live Forgejo server (see also the [developer guide for JavaScript testing](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/e2e/README.md#end-to-end-tests)). ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [ ] I do not want this change to show in the release notes. - [x] I want the title to show in the release notes with a link to this pull request. - [ ] I want the content of the `release-notes/<pull request number>.md` to be be used for the release notes instead of the title. <!--start release-notes-assistant--> ## Release notes <!--URL:https://codeberg.org/forgejo/forgejo--> - Bug fixes - [PR](https://codeberg.org/forgejo/forgejo/pulls/10009): <!--number 10009 --><!--line 0 --><!--description Z2FyYmFnZSBjb2xsZWN0IGxpbmdlcmluZyBhY3Rpb25zIGxvZ3M=-->garbage collect lingering actions logs<!--description--> <!--end release-notes-assistant--> Co-authored-by: Mathieu Fenniak <mathieu@fenniak.net> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/10009 Reviewed-by: Mathieu Fenniak <mfenniak@noreply.codeberg.org> Reviewed-by: Gusted <gusted@noreply.codeberg.org> Co-authored-by: Earl Warren <contact@earl-warren.org> Co-committed-by: Earl Warren <contact@earl-warren.org>
96 lines
2.7 KiB
Go
96 lines
2.7 KiB
Go
// Copyright 2025 The Forgejo Authors. All rights reserved.
|
|
// SPDX-License-Identifier: GPL-3.0-or-later
|
|
|
|
package actions
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"time"
|
|
|
|
actions_model "forgejo.org/models/actions"
|
|
"forgejo.org/models/db"
|
|
"forgejo.org/modules/actions"
|
|
"forgejo.org/modules/log"
|
|
"forgejo.org/modules/optional"
|
|
"forgejo.org/modules/timeutil"
|
|
)
|
|
|
|
var (
|
|
transferLingeringLogsMax = 3000
|
|
transferLingeringLogsSleep = 1 * time.Second
|
|
transferLingeringLogsOld = 24 * time.Hour
|
|
)
|
|
|
|
func TransferLingeringLogs(ctx context.Context) error {
|
|
return transferLingeringLogs(ctx, transferLingeringLogsOpts(time.Now()))
|
|
}
|
|
|
|
func transferLingeringLogsOpts(now time.Time) actions_model.FindTaskOptions {
|
|
// performance considerations: the search is linear because
|
|
// LogInStorage has no index. But it is bounded by
|
|
// LogExpired which is always true for older records and has an index.
|
|
return actions_model.FindTaskOptions{
|
|
Status: actions_model.DoneStatuses(),
|
|
LogInStorage: optional.Some(false),
|
|
LogExpired: optional.Some(false),
|
|
// do it after a long delay to avoid any possibility of race with an ongoing operation
|
|
// as it is not protected by a transaction
|
|
UpdatedBefore: timeutil.TimeStamp(now.Add(-transferLingeringLogsOld).Unix()),
|
|
}
|
|
}
|
|
|
|
func transferLingeringLogs(ctx context.Context, opts actions_model.FindTaskOptions) error {
|
|
count := 0
|
|
err := db.Iterate(ctx, opts.ToConds(), func(ctx context.Context, task *actions_model.ActionTask) error {
|
|
if err := TransferLogsAndUpdateLogInStorage(ctx, task); err != nil {
|
|
return err
|
|
}
|
|
log.Debug("processed task %d", task.ID)
|
|
count++
|
|
if count < transferLingeringLogsMax {
|
|
log.Debug("sleeping %v to not stress the storage", transferLingeringLogsSleep)
|
|
time.Sleep(transferLingeringLogsSleep)
|
|
}
|
|
if count >= transferLingeringLogsMax {
|
|
return fmt.Errorf("stopped after processing %v tasks and will resume later", transferLingeringLogsMax)
|
|
}
|
|
return nil
|
|
})
|
|
if count >= transferLingeringLogsMax {
|
|
log.Info("%v", err)
|
|
return nil
|
|
}
|
|
if count > 0 {
|
|
log.Info("processed %d tasks", count)
|
|
}
|
|
return err
|
|
}
|
|
|
|
func TransferLogsAndUpdateLogInStorage(ctx context.Context, task *actions_model.ActionTask) error {
|
|
if task.LogInStorage {
|
|
return nil
|
|
}
|
|
remove, err := TransferLogs(ctx, task.LogFilename)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
task.LogInStorage = true
|
|
if err := actions_model.UpdateTask(ctx, task, "log_in_storage"); err != nil {
|
|
return err
|
|
}
|
|
remove()
|
|
|
|
return nil
|
|
}
|
|
|
|
func TransferLogs(ctx context.Context, logFilename string) (func(), error) {
|
|
exists, err := actions.ExistsLogs(ctx, logFilename)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if !exists {
|
|
return func() {}, nil
|
|
}
|
|
return actions.TransferLogs(ctx, logFilename)
|
|
}
|