mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-04-22 17:16:58 -04:00
Some checks are pending
/ release (push) Waiting to run
testing-integration / test-unit (push) Waiting to run
testing-integration / test-sqlite (push) Waiting to run
testing-integration / test-mariadb (v10.6) (push) Waiting to run
testing-integration / test-mariadb (v11.8) (push) Waiting to run
testing / backend-checks (push) Waiting to run
testing / frontend-checks (push) Waiting to run
testing / test-unit (push) Blocked by required conditions
testing / test-e2e (push) Blocked by required conditions
testing / test-remote-cacher (redis) (push) Blocked by required conditions
testing / test-remote-cacher (valkey) (push) Blocked by required conditions
testing / test-remote-cacher (garnet) (push) Blocked by required conditions
testing / test-remote-cacher (redict) (push) Blocked by required conditions
testing / test-mysql (push) Blocked by required conditions
testing / test-pgsql (push) Blocked by required conditions
testing / test-sqlite (push) Blocked by required conditions
testing / security-check (push) Blocked by required conditions
If, for any reason (e.g. server crash), a task is recorded as done in the database but the logs are still in the database instead of being in storage, they need to be collected. The log_in_storage field is only set to true after the logs have been transfered to storage and can be relied upon to reflect which tasks have lingering logs. A cron job collects lingering logs every day, 3000 at a time, sleeping one second between them. In normal circumstances there will be only a few of them, even on a large instance, and there is no need to collect them as quickly as possible. When there are a lot of them for some reason, garbage collection must happen at a rate that is not too hard on storage I/O. Refs https://codeberg.org/forgejo/forgejo/issues/9999 --- Note on backports: the v11 backport is done manually because of minor conflicts. https://codeberg.org/forgejo/forgejo/pulls/10024 ## Checklist The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org). ### Tests - I added test coverage for Go changes... - [x] in their respective `*_test.go` for unit tests. - [x] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I added test coverage for JavaScript changes... - [ ] in `web_src/js/*.test.js` if it can be unit tested. - [ ] in `tests/e2e/*.test.e2e.js` if it requires interactions with a live Forgejo server (see also the [developer guide for JavaScript testing](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/e2e/README.md#end-to-end-tests)). ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [ ] I do not want this change to show in the release notes. - [x] I want the title to show in the release notes with a link to this pull request. - [ ] I want the content of the `release-notes/<pull request number>.md` to be be used for the release notes instead of the title. <!--start release-notes-assistant--> ## Release notes <!--URL:https://codeberg.org/forgejo/forgejo--> - Bug fixes - [PR](https://codeberg.org/forgejo/forgejo/pulls/10009): <!--number 10009 --><!--line 0 --><!--description Z2FyYmFnZSBjb2xsZWN0IGxpbmdlcmluZyBhY3Rpb25zIGxvZ3M=-->garbage collect lingering actions logs<!--description--> <!--end release-notes-assistant--> Co-authored-by: Mathieu Fenniak <mathieu@fenniak.net> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/10009 Reviewed-by: Mathieu Fenniak <mfenniak@noreply.codeberg.org> Reviewed-by: Gusted <gusted@noreply.codeberg.org> Co-authored-by: Earl Warren <contact@earl-warren.org> Co-committed-by: Earl Warren <contact@earl-warren.org>
96 lines
2.3 KiB
Go
96 lines
2.3 KiB
Go
// Copyright 2022 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package actions
|
|
|
|
import (
|
|
"context"
|
|
|
|
"forgejo.org/models/db"
|
|
"forgejo.org/modules/container"
|
|
"forgejo.org/modules/optional"
|
|
"forgejo.org/modules/timeutil"
|
|
|
|
"xorm.io/builder"
|
|
)
|
|
|
|
type TaskList []*ActionTask
|
|
|
|
func (tasks TaskList) GetJobIDs() []int64 {
|
|
return container.FilterSlice(tasks, func(t *ActionTask) (int64, bool) {
|
|
return t.JobID, t.JobID != 0
|
|
})
|
|
}
|
|
|
|
func (tasks TaskList) LoadJobs(ctx context.Context) error {
|
|
jobIDs := tasks.GetJobIDs()
|
|
jobs := make(map[int64]*ActionRunJob, len(jobIDs))
|
|
if err := db.GetEngine(ctx).In("id", jobIDs).Find(&jobs); err != nil {
|
|
return err
|
|
}
|
|
for _, t := range tasks {
|
|
if t.JobID > 0 && t.Job == nil {
|
|
t.Job = jobs[t.JobID]
|
|
}
|
|
}
|
|
|
|
// TODO: Replace with "ActionJobList(maps.Values(jobs))" once available
|
|
var jobsList ActionJobList = make([]*ActionRunJob, 0, len(jobs))
|
|
for _, j := range jobs {
|
|
jobsList = append(jobsList, j)
|
|
}
|
|
return jobsList.LoadAttributes(ctx, true)
|
|
}
|
|
|
|
func (tasks TaskList) LoadAttributes(ctx context.Context) error {
|
|
return tasks.LoadJobs(ctx)
|
|
}
|
|
|
|
type FindTaskOptions struct {
|
|
db.ListOptions
|
|
RepoID int64
|
|
OwnerID int64
|
|
CommitSHA string
|
|
Status []Status
|
|
UpdatedBefore timeutil.TimeStamp
|
|
StartedBefore timeutil.TimeStamp
|
|
RunnerID int64
|
|
LogExpired optional.Option[bool]
|
|
LogInStorage optional.Option[bool]
|
|
}
|
|
|
|
func (opts FindTaskOptions) ToConds() builder.Cond {
|
|
cond := builder.NewCond()
|
|
if opts.RepoID > 0 {
|
|
cond = cond.And(builder.Eq{"repo_id": opts.RepoID})
|
|
}
|
|
if opts.OwnerID > 0 {
|
|
cond = cond.And(builder.Eq{"owner_id": opts.OwnerID})
|
|
}
|
|
if opts.CommitSHA != "" {
|
|
cond = cond.And(builder.Eq{"commit_sha": opts.CommitSHA})
|
|
}
|
|
if opts.Status != nil {
|
|
cond = cond.And(builder.In("status", opts.Status))
|
|
}
|
|
if opts.UpdatedBefore > 0 {
|
|
cond = cond.And(builder.Lt{"updated": opts.UpdatedBefore})
|
|
}
|
|
if opts.StartedBefore > 0 {
|
|
cond = cond.And(builder.Lt{"started": opts.StartedBefore})
|
|
}
|
|
if opts.RunnerID > 0 {
|
|
cond = cond.And(builder.Eq{"runner_id": opts.RunnerID})
|
|
}
|
|
if opts.LogExpired.Has() {
|
|
cond = cond.And(builder.Eq{"log_expired": opts.LogExpired.Value()})
|
|
}
|
|
if opts.LogInStorage.Has() {
|
|
cond = cond.And(builder.Eq{"log_in_storage": opts.LogInStorage.Value()})
|
|
}
|
|
return cond
|
|
}
|
|
|
|
func (opts FindTaskOptions) ToOrders() string {
|
|
return "`id` DESC"
|
|
}
|