mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-03-25 23:33:03 -04:00
28e0af25b4
Improves the performance of the `/repo/search?uid=N` API call, which is used on the user's dashboard to load a repo list. More detailed notes are in https://codeberg.org/forgejo/forgejo/issues/11702. Removes a redundant query condition (that a user was part of a team in an organization which could see a repo), and a condition that seems incorrect (that a repo could be seen just by being public within a private org, which is incorrect because that doesn't mean the user is a collaborator on the repo). Covered by over 30 test cases in `repo_list_test.go` which did not fail from these changes. Mutation testing (removing the remaining "2." condition) verified that the codepath is covered as tests did fail. ## Checklist The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org). ### Tests for Go changes - I added test coverage for Go changes... - [ ] in their respective `*_test.go` for unit tests. - [ ] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I ran... - [x] `make pr-go` before pushing ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [ ] This change will be noticed by a Forgejo user or admin (feature, bug fix, performance, etc.). I suggest to include a release note for this change. - [x] This change is not visible to a Forgejo user or admin (refactor, dependency upgrade, etc.). I think there is no need to add a release note for this change. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/11729 Reviewed-by: Gusted <gusted@noreply.codeberg.org> Co-authored-by: Mathieu Fenniak <mathieu@fenniak.net> Co-committed-by: Mathieu Fenniak <mathieu@fenniak.net> |
||
|---|---|---|
| .. | ||
| fixtures/TestFindRepoAttachmentsByUUID | ||
| TestGetUserForkLax | ||
| TestGetUserForkLaxWithTwoChoices | ||
| TestSearchRepositoryIDsByCondition | ||
| archive_download_count.go | ||
| archive_download_count_test.go | ||
| archiver.go | ||
| attachment.go | ||
| attachment_test.go | ||
| authz.go | ||
| avatar.go | ||
| collaboration.go | ||
| collaboration_test.go | ||
| following_repo.go | ||
| following_repo_test.go | ||
| fork.go | ||
| fork_test.go | ||
| git.go | ||
| issue.go | ||
| language_stats.go | ||
| language_stats_test.go | ||
| main_test.go | ||
| mirror.go | ||
| moderation.go | ||
| moderation_test.go | ||
| pushmirror.go | ||
| pushmirror_test.go | ||
| redirect.go | ||
| redirect_test.go | ||
| release.go | ||
| release_list.go | ||
| release_list_test.go | ||
| release_test.go | ||
| repo.go | ||
| repo_flags.go | ||
| repo_flags_test.go | ||
| repo_indexer.go | ||
| repo_list.go | ||
| repo_list_test.go | ||
| repo_repository.go | ||
| repo_test.go | ||
| repo_unit.go | ||
| repo_unit_test.go | ||
| search.go | ||
| star.go | ||
| star_test.go | ||
| topic.go | ||
| topic_test.go | ||
| update.go | ||
| update_test.go | ||
| upload.go | ||
| user_repo.go | ||
| user_repo_test.go | ||
| watch.go | ||
| watch_test.go | ||
| wiki.go | ||
| wiki_test.go | ||