mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-03-27 00:03:05 -04:00
c198082975
Fixes #11030. When a `strategy.matrix` needs to be evaluated on the output of another job, it can become evaluated into an empty set of jobs. In this case, and assuming no other jobs in the run are active, the run should reach a settled state. The logic to check the other jobs in the run and determine if this state has been hit needs to be explicitly added to the job emitter. To accomplish this change, this action run state logic was extracted out of `UpdateRunJobWithoutNotification` where it could be reused. ## Checklist The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org). ### Tests - I added test coverage for Go changes... - [x] in their respective `*_test.go` for unit tests. - [ ] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I added test coverage for JavaScript changes... - [ ] in `web_src/js/*.test.js` if it can be unit tested. - [ ] in `tests/e2e/*.test.e2e.js` if it requires interactions with a live Forgejo server (see also the [developer guide for JavaScript testing](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/e2e/README.md#end-to-end-tests)). ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [x] This change will be noticed by a Forgejo user or admin (feature, bug fix, performance, etc.). I suggest to include a release note for this change. - [ ] This change is not visible to a Forgejo user or admin (refactor, dependency upgrade, etc.). I think there is no need to add a release note for this change. *The decision if the pull request will be shown in the release notes is up to the mergers / release team.* The content of the `release-notes/<pull request number>.md` file will serve as the basis for the release notes. If the file does not exist, the title of the pull request will be used instead. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/11063 Reviewed-by: Gusted <gusted@noreply.codeberg.org> Co-authored-by: Mathieu Fenniak <mathieu@fenniak.net> Co-committed-by: Mathieu Fenniak <mathieu@fenniak.net>
65 lines
1.2 KiB
YAML
65 lines
1.2 KiB
YAML
-
|
|
id: 100
|
|
task_id: 100
|
|
output_key: colors
|
|
output_value: '["red", "blue", "green"]'
|
|
-
|
|
id: 101
|
|
task_id: 101
|
|
output_key: colors
|
|
output_value: '[]'
|
|
-
|
|
id: 102
|
|
task_id: 102
|
|
output_key: datacenters
|
|
output_value: '["site-a", "site-b"]'
|
|
-
|
|
id: 103
|
|
task_id: 102
|
|
output_key: node-versions
|
|
output_value: '["12.x", "14.x"]'
|
|
-
|
|
id: 104
|
|
task_id: 102
|
|
output_key: pg_version
|
|
output_value: '[17, 18]'
|
|
-
|
|
id: 105
|
|
task_id: 103
|
|
output_key: entire-matrix
|
|
output_value: '{"datacenter": ["site-a", "site-b"], "node": ["12.x", "14.x"], "pg": [17, 18]}'
|
|
-
|
|
id: 106
|
|
task_id: 104
|
|
output_key: scalar-value
|
|
output_value: just some value
|
|
-
|
|
id: 107
|
|
task_id: 105
|
|
output_key: run-on-this
|
|
output_value: nixos-25.11
|
|
-
|
|
id: 108
|
|
task_id: 106
|
|
output_key: entire-matrix
|
|
output_value: '{"datacenter": ["site-a", "site-b"], "node": ["12.x", "14.x"], "pg": [17, 18]}'
|
|
-
|
|
id: 109
|
|
task_id: 107
|
|
output_key: run-on-this
|
|
output_value: nixos-25.11
|
|
-
|
|
id: 110
|
|
task_id: 108
|
|
output_key: workflow_input
|
|
output_value: my-workflow-input
|
|
-
|
|
id: 111
|
|
task_id: 109
|
|
output_key: workflow_input
|
|
output_value: my-workflow-input
|
|
-
|
|
id: 112
|
|
task_id: 110
|
|
output_key: empty-list
|
|
output_value: "[]"
|