mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-03-26 16:43:03 -04:00
1c64bad453
- fix: show oauth2 retrieve error - `true` indicates it only should be shown when the page is rendered directly via `ctx.HTML` and not propagated if it redirects. As you can see this always redirects and means the error is not shown. - Has the funny behavior that you get redirected to `/user/login` without any indication what went wrong, no errors in the logs either. - fix: pre-process OAuth2 client ID and secret - Spaces should are not appropriate for these input, remove them. - Manually copying and pasting client ID and secret from Github OAuth2 applications seems prone to introduce whitespaces. - The error of having a incorrect client ID is more noticeable (404 page for the user). - The error of having a incorrect client secret is not noticeable (404 page for the goth library but no mention it's the wrong secret). Reported-by: marijnh Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/11715 Reviewed-by: Mathieu Fenniak <mfenniak@noreply.codeberg.org> Reviewed-by: Andreas Ahlenstorf <aahlenst@noreply.codeberg.org> Co-authored-by: Gusted <postmaster@gusted.xyz> Co-committed-by: Gusted <postmaster@gusted.xyz> |
||
|---|---|---|
| .. | ||
| admin.go | ||
| auth_form.go | ||
| avatar.go | ||
| org.go | ||
| package_form.go | ||
| repo_branch_form.go | ||
| repo_form.go | ||
| repo_form_test.go | ||
| repo_tag_form.go | ||
| report_abuse.go | ||
| runner.go | ||
| user_form.go | ||
| user_form_auth_openid.go | ||
| user_form_hidden_comments.go | ||
| user_form_test.go | ||