mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-03-25 13:53:03 -04:00
2bde157a0d
Followup to https://codeberg.org/forgejo/forgejo/pulls/2528 Instead of storing translated strings in memory, store raw numbers and translate at template rendering time. Our implementation of `TrSize` is not very efficient and is more expensive than just the underlying `humanize.IBytes`, but for me on localhost both ways render response to HTMLX's request to `/admin/system_status` in 0-1 ms. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/10358 Reviewed-by: Gusted <gusted@noreply.codeberg.org> Co-authored-by: 0ko <0ko@noreply.codeberg.org> Co-committed-by: 0ko <0ko@noreply.codeberg.org>
100 lines
3.3 KiB
Go
100 lines
3.3 KiB
Go
// Copyright 2025 The Forgejo Authors. All rights reserved.
|
|
// SPDX-License-Identifier: GPL-3.0-or-later
|
|
|
|
package integration
|
|
|
|
import (
|
|
"fmt"
|
|
"net/http"
|
|
"testing"
|
|
|
|
"forgejo.org/modules/setting"
|
|
"forgejo.org/modules/test"
|
|
"forgejo.org/modules/translation"
|
|
"forgejo.org/tests"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
var commonEntries = []string{
|
|
"delete_inactive_accounts",
|
|
"delete_repo_archives",
|
|
"delete_missing_repos",
|
|
"git_gc_repos",
|
|
"resync_all_hooks",
|
|
"reinit_missing_repos",
|
|
"sync_external_users",
|
|
"repo_health_check",
|
|
"delete_generated_repository_avatars",
|
|
"sync_repo_branches",
|
|
"sync_repo_tags",
|
|
}
|
|
|
|
var sshEntries = []string{
|
|
"resync_all_sshkeys",
|
|
"resync_all_sshprincipals",
|
|
}
|
|
|
|
// Check cron options on /admin, including those that are available conditionally
|
|
func testAssertAdminDashboardOptions(t *testing.T, page *HTMLDoc, locale translation.Locale, expectSSH bool) {
|
|
for _, entry := range commonEntries {
|
|
page.AssertSelection(t, page.FindByText("table tr td", locale.TrString(fmt.Sprintf("admin.dashboard.%s", entry))), true)
|
|
page.AssertSelection(t, page.Find(fmt.Sprintf("table tr td button[value='%s']", entry)), true)
|
|
}
|
|
for _, entry := range sshEntries {
|
|
page.AssertSelection(t, page.FindByText("table tr td", locale.TrString(fmt.Sprintf("admin.dashboard.%s", entry))), expectSSH)
|
|
page.AssertSelection(t, page.Find(fmt.Sprintf("table tr td button[value='%s']", entry)), expectSSH)
|
|
}
|
|
}
|
|
|
|
func TestAdminDashboard(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
|
|
session := loginUser(t, "user1")
|
|
locale := translation.NewLocale("en-US")
|
|
url := "/admin"
|
|
|
|
t.Run("SSH disabled", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
defer test.MockVariableValue(&setting.SSH.Disabled, true)()
|
|
|
|
page := NewHTMLParser(t, session.MakeRequest(t, NewRequest(t, "GET", url), http.StatusOK).Body)
|
|
testAssertAdminDashboardOptions(t, page, locale, false)
|
|
})
|
|
|
|
t.Run("SSH enabled, but built-in", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
defer test.MockVariableValue(&setting.SSH.Disabled, false)()
|
|
defer test.MockVariableValue(&setting.SSH.StartBuiltinServer, true)()
|
|
|
|
page := NewHTMLParser(t, session.MakeRequest(t, NewRequest(t, "GET", url), http.StatusOK).Body)
|
|
testAssertAdminDashboardOptions(t, page, locale, false)
|
|
})
|
|
|
|
t.Run("SSH enabled and external", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
defer test.MockVariableValue(&setting.SSH.Disabled, false)()
|
|
defer test.MockVariableValue(&setting.SSH.StartBuiltinServer, false)()
|
|
|
|
page := NewHTMLParser(t, session.MakeRequest(t, NewRequest(t, "GET", url), http.StatusOK).Body)
|
|
testAssertAdminDashboardOptions(t, page, locale, true)
|
|
})
|
|
|
|
t.Run("System status", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
|
|
// Check data units translations in the System status table
|
|
selector := ".table[hx-get='/admin/system_status'] > dl > dd"
|
|
// ...in English
|
|
page := NewHTMLParser(t, session.MakeRequest(t, NewRequest(t, "GET", url), http.StatusOK).Body)
|
|
assert.Contains(t, page.Find(selector).Text(), "MiB")
|
|
|
|
// ...in another language
|
|
lang := session.GetCookie("lang")
|
|
lang.Value = "ru-RU"
|
|
session.SetCookie(lang)
|
|
|
|
page = NewHTMLParser(t, session.MakeRequest(t, NewRequest(t, "GET", url), http.StatusOK).Body)
|
|
assert.Contains(t, page.Find(selector).Text(), "МиБ")
|
|
})
|
|
}
|