mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-04-27 22:56:39 -04:00
`Option[T]` currently exposes a method `Value()` which is permitted to be called on an option that has a value, and an option that doesn't have a value. This API is awkward because the behaviour if the option doesn't have a value isn't clear to the caller, and, because almost all accesses end up being `.Has()?` then `OK, use .Value()`. `Get() (bool, T)` is added as a better replacement, which both returns whether the option has a value, and the value if present. Most call-sites are rewritten to this form. `ValueOrZeroValue()` is a direct replacement that has the same behaviour that `Value()` had, but describes the behaviour if the value is missing. In addition to the current API being awkward, the core reason for this change is that `Value()` conflicts with the `Value()` function from the `driver.Valuer` interface. If this interface was implemented, it would allow `Option[T]` to be used to represent a nullable field in an xorm bean struct (requires: https://code.forgejo.org/xorm/xorm/pulls/66). _Note:_ changes are extensive in this PR, but are almost all changes are easy, mechanical transitions from `.Has()` to `.Get()`. All of this work was performed by hand. ## Checklist The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org). ### Tests - I added test coverage for Go changes... - [ ] in their respective `*_test.go` for unit tests. - [ ] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I added test coverage for JavaScript changes... - [ ] in `web_src/js/*.test.js` if it can be unit tested. - [ ] in `tests/e2e/*.test.e2e.js` if it requires interactions with a live Forgejo server (see also the [developer guide for JavaScript testing](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/e2e/README.md#end-to-end-tests)). ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [ ] This change will be noticed by a Forgejo user or admin (feature, bug fix, performance, etc.). I suggest to include a release note for this change. - [x] This change is not visible to a Forgejo user or admin (refactor, dependency upgrade, etc.). I think there is no need to add a release note for this change. *The decision if the pull request will be shown in the release notes is up to the mergers / release team.* The content of the `release-notes/<pull request number>.md` file will serve as the basis for the release notes. If the file does not exist, the title of the pull request will be used instead. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/11218 Reviewed-by: Otto <otto@codeberg.org> Reviewed-by: Gusted <gusted@noreply.codeberg.org> Co-authored-by: Mathieu Fenniak <mathieu@fenniak.net> Co-committed-by: Mathieu Fenniak <mathieu@fenniak.net>
450 lines
12 KiB
Go
450 lines
12 KiB
Go
// Copyright 2020 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package project
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"html/template"
|
|
|
|
"forgejo.org/models/db"
|
|
repo_model "forgejo.org/models/repo"
|
|
user_model "forgejo.org/models/user"
|
|
"forgejo.org/modules/log"
|
|
"forgejo.org/modules/optional"
|
|
"forgejo.org/modules/setting"
|
|
"forgejo.org/modules/timeutil"
|
|
"forgejo.org/modules/util"
|
|
|
|
"xorm.io/builder"
|
|
)
|
|
|
|
type (
|
|
// CardConfig is used to identify the type of column card that is being used
|
|
CardConfig struct {
|
|
CardType CardType
|
|
Translation string
|
|
}
|
|
|
|
// Type is used to identify the type of project in question and ownership
|
|
Type uint8
|
|
)
|
|
|
|
const (
|
|
// TypeIndividual is a type of project column that is owned by an individual
|
|
TypeIndividual Type = iota + 1
|
|
|
|
// TypeRepository is a project that is tied to a repository
|
|
TypeRepository
|
|
|
|
// TypeOrganization is a project that is tied to an organisation
|
|
TypeOrganization
|
|
)
|
|
|
|
// ErrProjectNotExist represents a "ProjectNotExist" kind of error.
|
|
type ErrProjectNotExist struct {
|
|
ID int64
|
|
RepoID int64
|
|
}
|
|
|
|
// IsErrProjectNotExist checks if an error is a ErrProjectNotExist
|
|
func IsErrProjectNotExist(err error) bool {
|
|
_, ok := err.(ErrProjectNotExist)
|
|
return ok
|
|
}
|
|
|
|
func (err ErrProjectNotExist) Error() string {
|
|
return fmt.Sprintf("projects does not exist [id: %d]", err.ID)
|
|
}
|
|
|
|
func (err ErrProjectNotExist) Unwrap() error {
|
|
return util.ErrNotExist
|
|
}
|
|
|
|
// ErrProjectColumnNotExist represents a "ErrProjectColumnNotExist" kind of error.
|
|
type ErrProjectColumnNotExist struct {
|
|
ColumnID int64
|
|
}
|
|
|
|
// IsErrProjectColumnNotExist checks if an error is a ErrProjectColumnNotExist
|
|
func IsErrProjectColumnNotExist(err error) bool {
|
|
_, ok := err.(ErrProjectColumnNotExist)
|
|
return ok
|
|
}
|
|
|
|
func (err ErrProjectColumnNotExist) Error() string {
|
|
return fmt.Sprintf("project column does not exist [id: %d]", err.ColumnID)
|
|
}
|
|
|
|
func (err ErrProjectColumnNotExist) Unwrap() error {
|
|
return util.ErrNotExist
|
|
}
|
|
|
|
// Project represents a project
|
|
type Project struct {
|
|
ID int64 `xorm:"pk autoincr"`
|
|
Title string `xorm:"INDEX NOT NULL"`
|
|
Description string `xorm:"TEXT"`
|
|
OwnerID int64 `xorm:"INDEX"`
|
|
Owner *user_model.User `xorm:"-"`
|
|
RepoID int64 `xorm:"INDEX"`
|
|
Repo *repo_model.Repository `xorm:"-"`
|
|
CreatorID int64 `xorm:"NOT NULL"`
|
|
IsClosed bool `xorm:"INDEX"`
|
|
TemplateType TemplateType `xorm:"'board_type'"` // TODO: rename the column to template_type
|
|
CardType CardType
|
|
Type Type
|
|
|
|
RenderedContent template.HTML `xorm:"-"`
|
|
|
|
CreatedUnix timeutil.TimeStamp `xorm:"INDEX created"`
|
|
UpdatedUnix timeutil.TimeStamp `xorm:"INDEX updated"`
|
|
ClosedDateUnix timeutil.TimeStamp
|
|
}
|
|
|
|
// Ghost Project is a project which has been deleted
|
|
const GhostProjectID = -1
|
|
|
|
func (p *Project) IsGhost() bool {
|
|
return p.ID == GhostProjectID
|
|
}
|
|
|
|
func (p *Project) LoadOwner(ctx context.Context) (err error) {
|
|
if p.Owner != nil {
|
|
return nil
|
|
}
|
|
p.Owner, err = user_model.GetUserByID(ctx, p.OwnerID)
|
|
return err
|
|
}
|
|
|
|
func (p *Project) LoadRepo(ctx context.Context) (err error) {
|
|
if p.RepoID == 0 || p.Repo != nil {
|
|
return nil
|
|
}
|
|
p.Repo, err = repo_model.GetRepositoryByID(ctx, p.RepoID)
|
|
return err
|
|
}
|
|
|
|
func ProjectLinkForOrg(org *user_model.User, projectID int64) string { //nolint
|
|
return fmt.Sprintf("%s/-/projects/%d", org.HomeLink(), projectID)
|
|
}
|
|
|
|
func ProjectLinkForRepo(repo *repo_model.Repository, projectID int64) string { //nolint
|
|
return fmt.Sprintf("%s/projects/%d", repo.Link(), projectID)
|
|
}
|
|
|
|
// Link returns the project's relative URL.
|
|
func (p *Project) Link(ctx context.Context) string {
|
|
if p.OwnerID > 0 {
|
|
err := p.LoadOwner(ctx)
|
|
if err != nil {
|
|
log.Error("LoadOwner: %v", err)
|
|
return ""
|
|
}
|
|
return ProjectLinkForOrg(p.Owner, p.ID)
|
|
}
|
|
if p.RepoID > 0 {
|
|
err := p.LoadRepo(ctx)
|
|
if err != nil {
|
|
log.Error("LoadRepo: %v", err)
|
|
return ""
|
|
}
|
|
return ProjectLinkForRepo(p.Repo, p.ID)
|
|
}
|
|
return ""
|
|
}
|
|
|
|
func (p *Project) IconName() string {
|
|
if p.IsRepositoryProject() {
|
|
return "octicon-project"
|
|
}
|
|
return "octicon-project-symlink"
|
|
}
|
|
|
|
func (p *Project) IsOrganizationProject() bool {
|
|
return p.Type == TypeOrganization
|
|
}
|
|
|
|
func (p *Project) IsRepositoryProject() bool {
|
|
return p.Type == TypeRepository
|
|
}
|
|
|
|
func (p *Project) CanBeAccessedByOwnerRepo(ownerID int64, repo *repo_model.Repository) bool {
|
|
if p.Type == TypeRepository {
|
|
return repo != nil && p.RepoID == repo.ID // if a project belongs to a repository, then its OwnerID is 0 and can be ignored
|
|
}
|
|
return p.OwnerID == ownerID && p.RepoID == 0
|
|
}
|
|
|
|
func init() {
|
|
db.RegisterModel(new(Project))
|
|
}
|
|
|
|
// GetCardConfig retrieves the types of configurations project column cards could have
|
|
//
|
|
//llu:returnsTrKey
|
|
func GetCardConfig() []CardConfig {
|
|
return []CardConfig{
|
|
{CardTypeTextOnly, "repo.projects.card_type.text_only"},
|
|
{CardTypeImagesAndText, "repo.projects.card_type.images_and_text"},
|
|
}
|
|
}
|
|
|
|
// IsTypeValid checks if a project type is valid
|
|
func IsTypeValid(p Type) bool {
|
|
switch p {
|
|
case TypeIndividual, TypeRepository, TypeOrganization:
|
|
return true
|
|
default:
|
|
return false
|
|
}
|
|
}
|
|
|
|
// SearchOptions are options for GetProjects
|
|
type SearchOptions struct {
|
|
db.ListOptions
|
|
OwnerID int64
|
|
RepoID int64
|
|
IsClosed optional.Option[bool]
|
|
OrderBy db.SearchOrderBy
|
|
Type Type
|
|
Title string
|
|
}
|
|
|
|
func (opts SearchOptions) ToConds() builder.Cond {
|
|
cond := builder.NewCond()
|
|
if opts.RepoID > 0 {
|
|
cond = cond.And(builder.Eq{"repo_id": opts.RepoID})
|
|
}
|
|
if has, value := opts.IsClosed.Get(); has {
|
|
cond = cond.And(builder.Eq{"is_closed": value})
|
|
}
|
|
|
|
if opts.Type > 0 {
|
|
cond = cond.And(builder.Eq{"type": opts.Type})
|
|
}
|
|
if opts.OwnerID > 0 {
|
|
cond = cond.And(builder.Eq{"owner_id": opts.OwnerID})
|
|
}
|
|
|
|
if len(opts.Title) != 0 {
|
|
cond = cond.And(db.BuildCaseInsensitiveLike("title", opts.Title))
|
|
}
|
|
return cond
|
|
}
|
|
|
|
func (opts SearchOptions) ToOrders() string {
|
|
return opts.OrderBy.String()
|
|
}
|
|
|
|
func GetSearchOrderByBySortType(sortType string) db.SearchOrderBy {
|
|
switch sortType {
|
|
case "oldest":
|
|
return db.SearchOrderByOldest
|
|
case "recentupdate":
|
|
return db.SearchOrderByRecentUpdated
|
|
case "leastupdate":
|
|
return db.SearchOrderByLeastUpdated
|
|
default:
|
|
return db.SearchOrderByNewest
|
|
}
|
|
}
|
|
|
|
// NewProject creates a new Project
|
|
// The title will be cut off at 255 characters if it's longer than 255 characters.
|
|
func NewProject(ctx context.Context, p *Project) error {
|
|
if !IsTemplateTypeValid(p.TemplateType) {
|
|
p.TemplateType = TemplateTypeNone
|
|
}
|
|
|
|
if !IsCardTypeValid(p.CardType) {
|
|
p.CardType = CardTypeTextOnly
|
|
}
|
|
|
|
if !IsTypeValid(p.Type) {
|
|
return util.NewInvalidArgumentErrorf("project type is not valid")
|
|
}
|
|
|
|
p.Title, _ = util.SplitStringAtByteN(p.Title, 255)
|
|
|
|
return db.WithTx(ctx, func(ctx context.Context) error {
|
|
if err := db.Insert(ctx, p); err != nil {
|
|
return err
|
|
}
|
|
|
|
if p.RepoID > 0 {
|
|
if _, err := db.Exec(ctx, "UPDATE `repository` SET num_projects = num_projects + 1 WHERE id = ?", p.RepoID); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
return createDefaultColumnsForProject(ctx, p)
|
|
})
|
|
}
|
|
|
|
// GetProjectByID returns the projects in a repository
|
|
func GetProjectByID(ctx context.Context, id int64) (*Project, error) {
|
|
p := new(Project)
|
|
|
|
has, err := db.GetEngine(ctx).ID(id).Get(p)
|
|
if err != nil {
|
|
return nil, err
|
|
} else if !has {
|
|
return nil, ErrProjectNotExist{ID: id}
|
|
}
|
|
|
|
return p, nil
|
|
}
|
|
|
|
// GetProjectForRepoByID returns the projects in a repository
|
|
func GetProjectForRepoByID(ctx context.Context, repoID, id int64) (*Project, error) {
|
|
p := new(Project)
|
|
has, err := db.GetEngine(ctx).Where("id=? AND repo_id=?", id, repoID).Get(p)
|
|
if err != nil {
|
|
return nil, err
|
|
} else if !has {
|
|
return nil, ErrProjectNotExist{ID: id}
|
|
}
|
|
return p, nil
|
|
}
|
|
|
|
// UpdateProject updates project properties
|
|
func UpdateProject(ctx context.Context, p *Project) error {
|
|
if !IsCardTypeValid(p.CardType) {
|
|
p.CardType = CardTypeTextOnly
|
|
}
|
|
|
|
p.Title, _ = util.SplitStringAtByteN(p.Title, 255)
|
|
_, err := db.GetEngine(ctx).ID(p.ID).Cols(
|
|
"title",
|
|
"description",
|
|
"card_type",
|
|
).Update(p)
|
|
return err
|
|
}
|
|
|
|
func updateRepositoryProjectCount(ctx context.Context, repoID int64) error {
|
|
if _, err := db.GetEngine(ctx).Exec(builder.Update(
|
|
builder.Eq{
|
|
"`num_projects`": builder.Select("count(*)").From("`project`").
|
|
Where(builder.Eq{"`project`.`repo_id`": repoID}.
|
|
And(builder.Eq{"`project`.`type`": TypeRepository})),
|
|
}).From("`repository`").Where(builder.Eq{"id": repoID})); err != nil {
|
|
return err
|
|
}
|
|
|
|
if _, err := db.GetEngine(ctx).Exec(builder.Update(
|
|
builder.Eq{
|
|
"`num_closed_projects`": builder.Select("count(*)").From("`project`").
|
|
Where(builder.Eq{"`project`.`repo_id`": repoID}.
|
|
And(builder.Eq{"`project`.`type`": TypeRepository}).
|
|
And(builder.Eq{"`project`.`is_closed`": true})),
|
|
}).From("`repository`").Where(builder.Eq{"id": repoID})); err != nil {
|
|
return err
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// ChangeProjectStatusByRepoIDAndID toggles a project between opened and closed
|
|
func ChangeProjectStatusByRepoIDAndID(ctx context.Context, repoID, projectID int64, isClosed bool) error {
|
|
ctx, committer, err := db.TxContext(ctx)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer committer.Close()
|
|
|
|
p := new(Project)
|
|
|
|
has, err := db.GetEngine(ctx).ID(projectID).Where("repo_id = ?", repoID).Get(p)
|
|
if err != nil {
|
|
return err
|
|
} else if !has {
|
|
return ErrProjectNotExist{ID: projectID, RepoID: repoID}
|
|
}
|
|
|
|
if err := changeProjectStatus(ctx, p, isClosed); err != nil {
|
|
return err
|
|
}
|
|
|
|
return committer.Commit()
|
|
}
|
|
|
|
func changeProjectStatus(ctx context.Context, p *Project, isClosed bool) error {
|
|
p.IsClosed = isClosed
|
|
p.ClosedDateUnix = timeutil.TimeStampNow()
|
|
count, err := db.GetEngine(ctx).ID(p.ID).Where("repo_id = ? AND is_closed = ?", p.RepoID, !isClosed).Cols("is_closed", "closed_date_unix").Update(p)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if count < 1 {
|
|
return nil
|
|
}
|
|
|
|
return updateRepositoryProjectCount(ctx, p.RepoID)
|
|
}
|
|
|
|
// DeleteProjectByID deletes a project from a repository. if it's not in a database
|
|
// transaction, it will start a new database transaction
|
|
func DeleteProjectByID(ctx context.Context, id int64) error {
|
|
return db.WithTx(ctx, func(ctx context.Context) error {
|
|
p, err := GetProjectByID(ctx, id)
|
|
if err != nil {
|
|
if IsErrProjectNotExist(err) {
|
|
return nil
|
|
}
|
|
return err
|
|
}
|
|
|
|
if err := deleteProjectIssuesByProjectID(ctx, id); err != nil {
|
|
return err
|
|
}
|
|
|
|
if err := deleteColumnByProjectID(ctx, id); err != nil {
|
|
return err
|
|
}
|
|
|
|
if _, err = db.GetEngine(ctx).ID(p.ID).Delete(new(Project)); err != nil {
|
|
return err
|
|
}
|
|
|
|
return updateRepositoryProjectCount(ctx, p.RepoID)
|
|
})
|
|
}
|
|
|
|
func DeleteProjectByRepoID(ctx context.Context, repoID int64) error {
|
|
switch {
|
|
case setting.Database.Type.IsSQLite3():
|
|
if _, err := db.GetEngine(ctx).Exec("DELETE FROM project_issue WHERE project_issue.id IN (SELECT project_issue.id FROM project_issue INNER JOIN project WHERE project.id = project_issue.project_id AND project.repo_id = ?)", repoID); err != nil {
|
|
return err
|
|
}
|
|
if _, err := db.GetEngine(ctx).Exec("DELETE FROM project_board WHERE project_board.id IN (SELECT project_board.id FROM project_board INNER JOIN project WHERE project.id = project_board.project_id AND project.repo_id = ?)", repoID); err != nil {
|
|
return err
|
|
}
|
|
if _, err := db.GetEngine(ctx).Table("project").Where("repo_id = ? ", repoID).Delete(&Project{}); err != nil {
|
|
return err
|
|
}
|
|
case setting.Database.Type.IsPostgreSQL():
|
|
if _, err := db.GetEngine(ctx).Exec("DELETE FROM project_issue USING project WHERE project.id = project_issue.project_id AND project.repo_id = ? ", repoID); err != nil {
|
|
return err
|
|
}
|
|
if _, err := db.GetEngine(ctx).Exec("DELETE FROM project_board USING project WHERE project.id = project_board.project_id AND project.repo_id = ? ", repoID); err != nil {
|
|
return err
|
|
}
|
|
if _, err := db.GetEngine(ctx).Table("project").Where("repo_id = ? ", repoID).Delete(&Project{}); err != nil {
|
|
return err
|
|
}
|
|
default:
|
|
if _, err := db.GetEngine(ctx).Exec("DELETE project_issue FROM project_issue INNER JOIN project ON project.id = project_issue.project_id WHERE project.repo_id = ? ", repoID); err != nil {
|
|
return err
|
|
}
|
|
if _, err := db.GetEngine(ctx).Exec("DELETE project_board FROM project_board INNER JOIN project ON project.id = project_board.project_id WHERE project.repo_id = ? ", repoID); err != nil {
|
|
return err
|
|
}
|
|
if _, err := db.GetEngine(ctx).Table("project").Where("repo_id = ? ", repoID).Delete(&Project{}); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
return updateRepositoryProjectCount(ctx, repoID)
|
|
}
|