mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-02-03 20:51:07 -05:00
d8501b42fc
Some checks are pending
/ release (push) Waiting to run
testing-integration / test-unit (push) Waiting to run
testing-integration / test-sqlite (push) Waiting to run
testing-integration / test-mariadb (v10.6) (push) Waiting to run
testing-integration / test-mariadb (v11.8) (push) Waiting to run
testing / backend-checks (push) Waiting to run
testing / frontend-checks (push) Waiting to run
testing / test-unit (push) Blocked by required conditions
testing / test-e2e (push) Blocked by required conditions
testing / test-remote-cacher (redis) (push) Blocked by required conditions
testing / test-remote-cacher (valkey) (push) Blocked by required conditions
testing / test-remote-cacher (garnet) (push) Blocked by required conditions
testing / test-remote-cacher (redict) (push) Blocked by required conditions
testing / test-mysql (push) Blocked by required conditions
testing / test-pgsql (push) Blocked by required conditions
testing / test-sqlite (push) Blocked by required conditions
testing / security-check (push) Blocked by required conditions
Fixes #10155 When participants are displayed, don't include those that only have made a pending review. Those should not yet be revealed as participants. Apart from adding automated tests, this is the manual verification process I've followed: 1. Set up three users 2. User 1 creates a repository, then creates a pull request adding a new file 3. User 2 creates a new code comment but doesn't not publish the review, shows as pending. 4. User 3 creates a new code comment and publishes the review. 5. From everyone's perspective the number of participants is: 2. And, the participants displayed in the list are 1 and 3. User 2, which hasn't yet published the review is not displayed. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/10528 Reviewed-by: Gusted <gusted@noreply.codeberg.org> Co-authored-by: luisadame <luisadame@noreply.codeberg.org> Co-committed-by: luisadame <luisadame@noreply.codeberg.org> |
||
|---|---|---|
| .. | ||
| TestGetParticipantIDsByIssue | ||
| TestGetUIDsAndStopwatch | ||
| action_aggregator.go | ||
| action_aggregator_test.go | ||
| assignees.go | ||
| assignees_test.go | ||
| comment.go | ||
| comment_code.go | ||
| comment_list.go | ||
| comment_list_test.go | ||
| comment_test.go | ||
| content_history.go | ||
| content_history_test.go | ||
| dependency.go | ||
| dependency_test.go | ||
| issue.go | ||
| issue_index.go | ||
| issue_index_test.go | ||
| issue_label.go | ||
| issue_label_test.go | ||
| issue_list.go | ||
| issue_list_test.go | ||
| issue_lock.go | ||
| issue_project.go | ||
| issue_project_test.go | ||
| issue_search.go | ||
| issue_stats.go | ||
| issue_stats_test.go | ||
| issue_test.go | ||
| issue_update.go | ||
| issue_user.go | ||
| issue_user_test.go | ||
| issue_watch.go | ||
| issue_watch_test.go | ||
| issue_xref.go | ||
| issue_xref_test.go | ||
| label.go | ||
| label_internal_test.go | ||
| label_test.go | ||
| main_test.go | ||
| milestone.go | ||
| milestone_internal_test.go | ||
| milestone_list.go | ||
| milestone_test.go | ||
| moderation.go | ||
| moderation_test.go | ||
| pull.go | ||
| pull_list.go | ||
| pull_test.go | ||
| reaction.go | ||
| reaction_test.go | ||
| review.go | ||
| review_list.go | ||
| review_test.go | ||
| stopwatch.go | ||
| stopwatch_test.go | ||
| tracked_time.go | ||
| tracked_time_test.go | ||