mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-03-25 15:13:04 -04:00
73b96a41bc
Remove the field `ephemeral` from the response to runner registration requests made using the HTTP API (POST to `/repos/{owner}/{repo}/actions/runners` and friends) that was introduced with https://codeberg.org/forgejo/forgejo/pulls/9962. The client already knows that it requested an ephemeral runner. Therefore, the information is redundant.
It can be included again should a compelling use case arise.
This part of the HTTP API hasn't been released yet. Therefore, it is safe to remove the field.
## Checklist
The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org).
### Tests for Go changes
(can be removed for JavaScript changes)
- I added test coverage for Go changes...
- [ ] in their respective `*_test.go` for unit tests.
- [x] in the `tests/integration` directory if it involves interactions with a live Forgejo server.
- I ran...
- [x] `make pr-go` before pushing
### Tests for JavaScript changes
(can be removed for Go changes)
- I added test coverage for JavaScript changes...
- [ ] in `web_src/js/*.test.js` if it can be unit tested.
- [ ] in `tests/e2e/*.test.e2e.js` if it requires interactions with a live Forgejo server (see also the [developer guide for JavaScript testing](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/e2e/README.md#end-to-end-tests)).
### Documentation
- [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change.
- [x] I did not document these changes and I do not expect someone else to do it.
### Release notes
- [ ] This change will be noticed by a Forgejo user or admin (feature, bug fix, performance, etc.). I suggest to include a release note for this change.
- [x] This change is not visible to a Forgejo user or admin (refactor, dependency upgrade, etc.). I think there is no need to add a release note for this change.
*The decision if the pull request will be shown in the release notes is up to the mergers / release team.*
The content of the `release-notes/<pull request number>.md` file will serve as the basis for the release notes. If the file does not exist, the title of the pull request will be used instead.
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/11350
Reviewed-by: Mathieu Fenniak <mfenniak@noreply.codeberg.org>
Co-authored-by: Andreas Ahlenstorf <andreas@ahlenstorf.ch>
Co-committed-by: Andreas Ahlenstorf <andreas@ahlenstorf.ch>
|
||
|---|---|---|
| .. | ||
| action.go | ||
| activity.go | ||
| activitypub.go | ||
| admin_user.go | ||
| attachment.go | ||
| commit_status.go | ||
| commit_status_test.go | ||
| cron.go | ||
| doc.go | ||
| fork.go | ||
| git_blob.go | ||
| git_hook.go | ||
| hook.go | ||
| issue.go | ||
| issue_comment.go | ||
| issue_label.go | ||
| issue_milestone.go | ||
| issue_reaction.go | ||
| issue_stopwatch.go | ||
| issue_test.go | ||
| issue_tracked_time.go | ||
| lfs_lock.go | ||
| mirror.go | ||
| miscellaneous.go | ||
| moderation.go | ||
| nodeinfo.go | ||
| notifications.go | ||
| org.go | ||
| org_member.go | ||
| org_team.go | ||
| package.go | ||
| pull.go | ||
| pull_review.go | ||
| quota.go | ||
| release.go | ||
| repo.go | ||
| repo_actions.go | ||
| repo_branch.go | ||
| repo_collaborator.go | ||
| repo_commit.go | ||
| repo_compare.go | ||
| repo_file.go | ||
| repo_flags.go | ||
| repo_key.go | ||
| repo_note.go | ||
| repo_refs.go | ||
| repo_tag.go | ||
| repo_topic.go | ||
| repo_tree.go | ||
| repo_watch.go | ||
| repo_wiki.go | ||
| runner.go | ||
| secret.go | ||
| settings.go | ||
| status.go | ||
| task.go | ||
| user.go | ||
| user_app.go | ||
| user_email.go | ||
| user_gpgkey.go | ||
| user_key.go | ||
| variable.go | ||
| visible_type.go | ||
| workflow.go | ||