mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-02-03 20:51:07 -05:00
Fixed action variables and secrets according to [Docu](https://forgejo.org/docs/next/user/actions/basic-concepts/#name-constraints): > Variable names must not start with the FORGEJO_, GITHUB_ or GITEA_ prefix. This wasn't correctly enforced, so I changed the regex ## Checklist The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org). ### Tests - I added test coverage for Go changes... - [x] in their respective `*_test.go` for unit tests. - [x] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I added test coverage for JavaScript changes... - [ ] in `web_src/js/*.test.js` if it can be unit tested. - [ ] in `tests/e2e/*.test.e2e.js` if it requires interactions with a live Forgejo server (see also the [developer guide for JavaScript testing](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/e2e/README.md#end-to-end-tests)). ### Documentation - [x] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [ ] I did not document these changes and I do not expect someone else to do it. ### Release notes - [ ] I do not want this change to show in the release notes. - [x] I want the title to show in the release notes with a link to this pull request. - [ ] I want the content of the `release-notes/<pull request number>.md` to be be used for the release notes instead of the title. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/10682 Reviewed-by: Andreas Ahlenstorf <aahlenst@noreply.codeberg.org> Reviewed-by: Mathieu Fenniak <mfenniak@noreply.codeberg.org> Co-authored-by: zokki <zokki.softwareschmiede@gmail.com> Co-committed-by: zokki <zokki.softwareschmiede@gmail.com>
91 lines
2.8 KiB
Cheetah
91 lines
2.8 KiB
Cheetah
<h4 class="ui top attached header">
|
|
{{ctx.Locale.Tr "actions.variables.management"}}
|
|
<div class="ui right">
|
|
<button class="ui primary tiny button show-modal"
|
|
data-modal="#edit-variable-modal"
|
|
data-modal-form.action="{{.Link}}/new"
|
|
data-modal-header="{{ctx.Locale.Tr "actions.variables.creation"}}"
|
|
data-modal-dialog-variable-name=""
|
|
data-modal-dialog-variable-data=""
|
|
>
|
|
{{ctx.Locale.Tr "actions.variables.creation"}}
|
|
</button>
|
|
</div>
|
|
</h4>
|
|
<div class="ui attached segment">
|
|
{{if .Variables}}
|
|
<div class="flex-list">
|
|
{{range .Variables}}
|
|
<div class="flex-item tw-items-center">
|
|
<div class="flex-item-leading">
|
|
{{svg "octicon-pencil" 32}}
|
|
</div>
|
|
<div class="flex-item-main">
|
|
<div class="flex-item-title">
|
|
{{.Name}}
|
|
</div>
|
|
<div class="flex-item-body">
|
|
{{.Data}}
|
|
</div>
|
|
</div>
|
|
<div class="flex-item-trailing">
|
|
<span class="color-text-light-2">
|
|
{{ctx.Locale.Tr "settings.added_on" (DateUtils.AbsoluteShort .CreatedUnix)}}
|
|
</span>
|
|
<button class="btn interact-bg tw-p-2 show-modal"
|
|
data-tooltip-content="{{ctx.Locale.Tr "actions.variables.edit"}}"
|
|
data-modal="#edit-variable-modal"
|
|
data-modal-form.action="{{$.Link}}/{{.ID}}/edit"
|
|
data-modal-header="{{ctx.Locale.Tr "actions.variables.edit"}}"
|
|
data-modal-dialog-variable-name="{{.Name}}"
|
|
data-modal-dialog-variable-data="{{.Data}}"
|
|
>
|
|
{{svg "octicon-pencil"}}
|
|
</button>
|
|
<button class="btn interact-bg tw-p-2 link-action"
|
|
data-tooltip-content="{{ctx.Locale.Tr "actions.variables.deletion"}}"
|
|
data-url="{{$.Link}}/{{.ID}}/delete"
|
|
data-modal-confirm="{{ctx.Locale.Tr "actions.variables.deletion.description"}}"
|
|
>
|
|
{{svg "octicon-trash"}}
|
|
</button>
|
|
</div>
|
|
</div>
|
|
{{end}}
|
|
</div>
|
|
{{else}}
|
|
{{ctx.Locale.Tr "actions.variables.none"}}
|
|
{{end}}
|
|
</div>
|
|
|
|
{{/** Edit variable dialog */}}
|
|
<div class="ui small modal" id="edit-variable-modal">
|
|
<div class="header"></div>
|
|
<form class="ui form form-fetch-action" method="post">
|
|
<div class="content">
|
|
<div class="field">
|
|
{{ctx.Locale.Tr "actions.variables.description"}}
|
|
</div>
|
|
<div class="field">
|
|
<label for="dialog-variable-name">{{ctx.Locale.Tr "name"}}</label>
|
|
<input autofocus required
|
|
name="name"
|
|
id="dialog-variable-name"
|
|
value="{{.name}}"
|
|
pattern="^(?!CI$)(?!FORGEJO_|GITEA_|GITHUB_)[a-zA-Z_][a-zA-Z0-9_]*$"
|
|
placeholder="{{ctx.Locale.Tr "secrets.creation.name_placeholder"}}"
|
|
>
|
|
</div>
|
|
<div class="field">
|
|
<label for="dialog-variable-data">{{ctx.Locale.Tr "value"}}</label>
|
|
<textarea required
|
|
name="data"
|
|
id="dialog-variable-data"
|
|
placeholder="{{ctx.Locale.Tr "secrets.creation.value_placeholder"}}"
|
|
></textarea>
|
|
</div>
|
|
</div>
|
|
{{template "base/modal_actions_confirm" (dict "ModalButtonTypes" "confirm")}}
|
|
</form>
|
|
</div>
|
|
|