upstream/forgejo
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2026-03-26 10:43:04 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 4
forgejo/modules/structs
History
Andreas Ahlenstorf f7873ba393 fix: normalize secrets consistently, display accurate help (#11052) 
Forgejo's UI claims that whitespace is removed from the beginning and the end of the values of Forgejo Actions variables and secrets. However, that is not correct. The entered values are stored as-is. Only CRLF is replaced with LF, which is also the desired behaviour.

This PR changes the incorrect text which is also no longer displayed as placeholder but as a proper help text below the input fields. Furthermore, tests were added to verify the behaviour.

While adding tests, I discovered and fixed another inconsistency. Depending on whether secrets were managed using the UI or the HTTP API, they were treated differently. CRLF in secrets entered in the UI was correctly replaced with LF while secrets created using the HTTP API kept CRLF.

Fixes #11003.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/11052
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: Andreas Ahlenstorf <andreas@ahlenstorf.ch>
Co-committed-by: Andreas Ahlenstorf <andreas@ahlenstorf.ch>
2026-02-09 17:02:18 +01:00
..
action.go bug: unify RepoActionRun and ActionRun structs (#8250) 2025-06-23 07:54:32 +02:00
activity.go [CHORE] Fix swagger deprecation message 2024-08-10 01:21:13 +02:00
activitypub.go Improved signature handling & instance actor (#8275) 2025-07-01 19:49:00 +02:00
admin_user.go feat: Add support for administrators to set email visibility on user accounts (#9668) 2025-10-15 03:21:15 +02:00
attachment.go fix(ui): Add pasted images to dropzone 2025-06-30 12:42:22 +02:00
commit_status.go docs: add back warning as a commit status (#8935) 2025-10-01 04:52:16 +02:00
commit_status_test.go refactor improve NoBetterThan (#26126) 2023-07-26 08:52:07 +00:00
cron.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
doc.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
fork.go feat: sync forks (#2364) 2025-04-07 07:00:38 +00:00
git_blob.go api: GitBlob consistent naming 2025-06-13 11:35:14 +02:00
git_hook.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
hook.go Revert "fix(api): document is_system_webhook field (#7784)" (#8286) 2025-06-26 00:36:18 +02:00
issue.go chore: fix typos throughout the codebase (#10753) 2026-01-26 22:57:33 +01:00
issue_comment.go [FEAT] allow setting the update date on issues and comments 2024-02-05 14:44:33 +01:00
issue_label.go Support using label names when changing issue labels (#30943) 2024-05-19 13:12:35 +02:00
issue_milestone.go [CHORE] Fix swagger deprecation message 2024-08-10 01:21:13 +02:00
issue_reaction.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue_stopwatch.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue_test.go chore: replace gopkg.in/yaml.v3 with go.yaml.in/yaml/v3 (#8956) 2025-08-20 15:31:12 +02:00
issue_tracked_time.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
lfs_lock.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
mirror.go feat: add configuration to only push mirror selected branches (#7823) 2025-07-12 00:39:35 +02:00
miscellaneous.go fix: Preview picture not visible on Markdown file (#5781) 2024-11-23 15:00:18 +00:00
moderation.go [MODERATION] User blocking 2024-02-05 15:56:45 +01:00
nodeinfo.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
notifications.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
org.go Inclusion of rename organization api (#33303) 2025-02-02 12:01:58 +01:00
org_member.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
org_team.go Update module github.com/golangci/golangci-lint/v2/cmd/golangci-lint to v2.6.1 (forgejo) (#10053) 2025-11-11 07:04:35 +01:00
package.go Fix package webhook (#27839) 2023-10-31 04:43:38 +00:00
pull.go fix(migrations): transfer PR flow information (#7421) 2025-04-03 06:47:37 +00:00
pull_review.go Fix invalid swagger syntax of $ref with sibling (#7019) 2025-02-21 14:09:21 +00:00
quota.go feat(quota): Humble beginnings of a quota engine 2024-08-02 11:10:34 +02:00
release.go [FEAT]Add Option to hide Release Archive links (#3139) 2024-04-24 15:15:55 +00:00
repo.go Add support for migrating from Pagure (#8513) 2025-08-11 16:56:26 +02:00
repo_actions.go chore: revise runner REST API endpoints (#10450) 2025-12-21 17:21:02 +01:00
repo_branch.go [FEAT] Configure if protected branch rule should apply to admins 2024-03-29 00:21:49 +01:00
repo_collaborator.go [CHORE] Fix swagger deprecation message 2024-08-10 01:21:13 +02:00
repo_commit.go Add file status for API "Get a single commit from a repository" (#16205) (#25831) 2023-07-20 16:35:47 +08:00
repo_compare.go feat: add files to compare (#6461) 2025-01-05 02:32:46 +00:00
repo_file.go feat(api): add last_commit_when to contents response (#7418) 2025-04-18 09:31:40 +00:00
repo_flags.go [FEAT] API support for repository flags 2024-02-05 16:09:42 +01:00
repo_key.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
repo_note.go [FEAT]Allow changing git notes (#4753) 2024-11-18 22:56:17 +00:00
repo_refs.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
repo_tag.go Add tag protection via rest api #17862 (#31295) 2024-06-16 13:42:59 +02:00
repo_topic.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
repo_tree.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
repo_watch.go Replace interface{} with any (#25686) 2023-07-04 18:36:08 +00:00
repo_wiki.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
runner.go feat: add HTTP API endpoint for runner registration (#10677) 2026-01-05 04:59:04 +01:00
secret.go fix: normalize secrets consistently, display accurate help (#11052) 2026-02-09 17:02:18 +01:00
settings.go Allow instance-wide disabling of forking 2024-02-25 12:00:17 +01:00
status.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
task.go style: reenable switch check 2024-08-18 15:19:01 +02:00
user.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
user_app.go feat: Add header annotations for accurate API documentation (#9380) 2026-01-06 10:29:15 +01:00
user_email.go fix: use ValidateEmail as binding across web forms 2024-08-28 22:25:17 -06:00
user_gpgkey.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
user_key.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
variable.go fix: normalize secrets consistently, display accurate help (#11052) 2026-02-09 17:02:18 +01:00
visible_type.go change org_type.go to visible_type.go and fix the notes (#22752) 2023-02-09 06:40:34 +00:00
workflow.go feat(api): return run_number in workflow dispatch (#7286) 2025-03-25 21:22:32 +00:00