mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-03-25 16:03:03 -04:00
ef7acda8be
I noticed that the wrong content type in an `/upload` request can trigger a 500, and I'm guessing it is more appropriate to return 400 instead. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/10954 Reviewed-by: Gusted <gusted@noreply.codeberg.org> Co-authored-by: Roberto Vidal <roberto.vidal@ikumene.com> Co-committed-by: Roberto Vidal <roberto.vidal@ikumene.com>
36 lines
1 KiB
Go
36 lines
1 KiB
Go
// Copyright 2023 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package context
|
|
|
|
import (
|
|
"io"
|
|
"net/http"
|
|
"strings"
|
|
)
|
|
|
|
// UploadStream returns the request body or the first form file
|
|
// Only form files need to get closed.
|
|
func (ctx *Context) UploadStream() (rd io.ReadCloser, needToClose bool, err error) {
|
|
contentType := strings.ToLower(ctx.Req.Header.Get("Content-Type"))
|
|
if strings.HasPrefix(contentType, "application/x-www-form-urlencoded") || strings.HasPrefix(contentType, "multipart/form-data") {
|
|
if err := ctx.Req.ParseMultipartForm(32 << 20); err != nil {
|
|
return nil, false, err
|
|
}
|
|
if ctx.Req.MultipartForm.File == nil {
|
|
return nil, false, http.ErrMissingFile
|
|
}
|
|
for _, files := range ctx.Req.MultipartForm.File {
|
|
if len(files) > 0 {
|
|
r, err := files[0].Open()
|
|
return r, true, err
|
|
}
|
|
}
|
|
return nil, false, http.ErrMissingFile
|
|
}
|
|
return ctx.Req.Body, false, nil
|
|
}
|
|
|
|
func IsFormError(err error) bool {
|
|
return err == http.ErrMissingFile || err == http.ErrMissingBoundary
|
|
}
|