upstream/haproxy
1
0
Fork 0
mirror of https://github.com/haproxy/haproxy.git synced 2026-04-24 07:37:53 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

MINOR: dns: dns_connect_nameserver: fix fd leak at error path

Browse source 
This fixes the commit 2c7e05f80e
("MEDIUM: dns: don't call connect to dest socket for AF_INET*"). If we fail to
bind AF_INET sockets or the address family of the nameserver protocol isn't
something, what we expect, we need to close the fd, obtained by
connect.

This fixes the issue GitHub #3085
This must be backported along with the commit 2c7e05f80e.
This commit is contained in:
Valentine Krasnobaeva 2025-08-22 09:55:40 +02:00 committed by Willy Tarreau
parent a498e527b4
commit 0dc8d8d027
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/dns.c
View file

@ -77,6 +77,7 @@ static int dns_connect_nameserver(struct dns_nameserver *ns)
send_log(NULL, LOG_WARNING,
"DNS : section '%s': can't bind socket for nameserver '%s' on 0.0.0.0:0.\n",
ns->counters->pid, ns->id);
close(fd);
return -1;
}
break;
@ -93,6 +94,7 @@ static int dns_connect_nameserver(struct dns_nameserver *ns)
send_log(NULL, LOG_WARNING,
"DNS : section '%s': can't bind socket for nameserver '%s' on :::0.\n",
ns->counters->pid, ns->id);
close(fd);
return -1;
}
break;
@ -110,6 +112,7 @@ static int dns_connect_nameserver(struct dns_nameserver *ns)
}
break;
default:
close(fd);
BUG_ON(1, "DNS: Unsupported address family.");
}